PR 254116 Tolerance Zone of Analysis view in Customreport is shown wrong

huangyhg

Tolerance Zone of Analysis view in Customreport is shown wrong
<< Daniel Schroepfer  --  03/31/08  23:53:06>>
Hello!
Customer create a Custom report with analysis view of a profile! If he drag and drop his profile dimension in the analysisview window, the tolerance zone is shown in a wrong way. It seems to be, that the tolerance zone is bestfited to the measured curve.
If Customer create a command for the analysis view  in his pp, the analysis is show ok in the Textonly - Template.
See example pp, pdf's and avi clip
Expected Results:
Should be working like the analysis view in a template
<<END>>

<< Jerry Naylor  --  06/02/08  13:51:45>>
wasaddedtoreadme42RMR2
<<END>>
<< Changes made by Daniel Schroepfer -- 05/26/08  09:20:42>>
Status:  REVIEW to CLOSED
<<END>>
<< Daniel Schroepfer  --  05/06/08  00:01:31>>
Sorry! I played to much!
I check this in the actual RC and close if ok!
Thank you and Regards
Daniel
<<END>>
<< Changes made by Daniel Schroepfer -- 05/06/08  00:01:35>>
Action:  Liqiang Zhu to Daniel Schroepfer
<<END>>
<< Changes made by Daniel Schroepfer -- 05/06/08  00:00:13>>
Action:  Daniel Schroepfer to Liqiang Zhu
<<END>>
<< Changes made by Daniel Schroepfer -- 05/05/08  23:53:17>>
Action:  Liqiang Zhu to Daniel Schroepfer
<<END>>
<< Don Turcotte  --  05/05/08  13:32:33>>
Merged into V42R.
Files inserted to server
------------------------
V42R\HYPER\HYPERANALCTRL4.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/05/08  13:33:34>>
Action:  Don Turcotte to Liqiang Zhu, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 05/05/08  11:10:59>>
Action:  Liqiang Zhu to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Daniel Schroepfer  --  04/29/08  10:57:37>>
Dear Don!
I test the fix in 4.2 Beta. It looks good. Can you please merge this fix in 4.2 MR2. I need this for the customer!
Thank you for help!
Regards Daniel
<<END>>
<< Don Turcotte  --  04/22/08  16:33:28>>
Merged into V43R.
Files inserted to server
------------------------
V43R\HYPER\HYPERANALCTRL4.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/22/08  16:34:25>>
Action:  Don Turcotte to Liqiang Zhu, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  04/22/08  15:21:10>>
Hi Don, please merge your fix into V43R as well.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 04/22/08  15:21:21>>
Action:  Liqiang Zhu to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< David Petrizze  --  04/22/08  03:41:39>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 04/22/08  03:41:42>>
Action:  David Petrizze to Liqiang Zhu
<<END>>
<< Don Turcotte  --  04/21/08  15:52:20>>
This worked with Feature Control Frame profiles, but not with legacy profiles.  The problem here is that the legacy profile command did not pass the form_and_loc parameter to the DimAnalysisActiveX control so the graphical analysis was drawn incorrectly.  The AnalysisView command worked because it calls graphical analysis directly and does not use the DimAnalysisActiveX control (the "old" way of reporting graphical analysis).
Fixed in V42 beta, V43B, V44B.
Files inserted to server
------------------------
V43B\HYPER\HYPERANALCTRL4.CPP
V44B\HYPER\HYPERANALCTRL4.CPP
V42\HYPER\HYPERANALCTRL4.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/21/08  15:52:41>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 03/31/08  18:51:18>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

else if( pCmd->type() == DIMENSION_PROFILE_SURFACE || pCmd->type() == DIMENSION_PROFILE_LINE )
    {
      // PR254116 - we also need form_and_loc if this is a legacy profile dimension
      CPCDdim_profile* pProfile = dynamic_cast<CPCDdim_profile*>(pCmd);
      if( pProfile )
      {
        int form_and_loc = (pProfile->m_form_and_loc || pProfile->m_bestfit==OPTIMIZED_FIT);
        m_dimanalysis_activex.SetFormAndLoc(form_and_loc);
      }
    }