PR 249287 Dimension nominal is not updated for generic feature using a variab

huangyhg

Dimension nominal is not updated for generic feature using a variable for its nominal
<< Cory Arnell  --  07/20/07  17:09:34>>
I have a scan in which I search the hits for the largest Z value. I create a generic feature with this hits values. The values in the generic feature change with each run but the Nom in the Dimension remains the same as the first run.
<<END>>

<< Paola Pallo  --  01/23/09  13:21:49>>
I realized late that this fix caused unwanted side effects ( PR 255447), so I rolled it back.
Cory, to get the expected result  in the dimension you should rework it as following :
DIM LOC2= LOCATION OF POINT F1  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH
AX    NOMINAL       MEAS
X     F1.TX     55.895 ---#----
Y     F1.TY     65.558 -#------
Z     F1.TZ     11.860 <-------
END OF DIMENSION LOC2
<<END>>
<< Paola Pallo  --  07/26/07  09:40:34>>
Uploaded. For review :
V42\CONSFEAT\GEN_CONS.CPP
V42\MENU\DIMENSIO.CPP
V43B\CONSFEAT\GEN_CONS.CPP
V43B\MENU\DIMENSIO.CPP
Please note that the generic feature should be used with  'DEPENDENT' parameter, since when it is 'INDEPEDENT' it's values are hardcoded ( not upgraded in following executions)
Cory, the attached PRG had a flaw : the variable HITN ( that is the index of the max value) should not be hardcoded to '3', but it should be assigned to the variable C ( index of MAXVAL).
<<END>>
<< Changes made by Paola Pallo -- 07/26/07  09:40:48>>
Action:  Paola Pallo to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Paola Pallo  --  07/25/07  17:52:47>>
I agree that there is an inconsistency between THEO values in the generic feature ( changing each run since the scan is in RELEARN mode) and the related dimension ( that is not upgraded in the execution and maintains its original THEO value).
I added a fix that I will upload tomorrow, but it should be carefully reviewed and tested (to esclude unwanted side-effects)
<<END>>
<< Paola Pallo  --  07/24/07  18:05:09>>
I'm taking a look.
<<END>>
<< Changes made by Tim Wernicke -- 07/20/07  18:21:01>>
Priority:  to Critical
<<END>>

huangyhg

sbit(RECALC_NOMS,TRUE); // 249287 to manage the case of changed THEO, we use RECALC_NOMS bit to upgrade any related dimensions
    // refer also to the global function FeatureIsFindNomsDuringExecution()

huangyhg

// 249287: when THEO data of a generic feature changed (its RECALC_NOMS is TRUE), to be coherent we should accordingly recalculate  also any related dimension's THEO
  if (feat->type() == GENERIC_CONSTRUCTION)
  {
    if(((CPCDcommand *)feat)->bit(RECALC_NOMS))
      ret= TRUE;
  }