PR#253508 Constructing a cast point from a curve changed the ID of first inp

huangyhg

Constructing a cast point from a curve changed the ID of  first input to the curve.
<< Dan Zwick  --  02/26/08  11:41:40>>
Using the part program from 253154, I inserted a cast point for CRV13. This changed the first input ID to CRV13 to the ID of the new cast point.
Steps to reproduce:
Get test.prg from PR 253154. Insert a cast point for CRV13 just after CRV13.

Results:
The first input ID for CRV13 changes to the ID for the cast point.
<<END>>

huangyhg

<< Dan Zwick  --  02/27/08  09:54:37>>
I uploaded V44B\CONSFEAT\CURVE.CPP.
<<END>>

<< Changes made by Dan Zwick -- 02/27/08  09:55:51>>
Status:  OPEN to RESOLVED
<<END>>

<< Changes made by Tim Wernicke -- 02/26/08  15:25:30>>
Priority:  to High
<<END>>

<< Dan Zwick  --  02/26/08  11:52:09>>
I uploaded the fix to 4.3B. I uploaded
V43B\CONSFEAT\CURVE.CPP.
<<END>>

<< Dan Zwick  --  02/26/08  11:47:05>>
Andy and I already investigated this and Andy discovered an index error in replace_ptr for the curve. The line
    if(i == (index+1) || m_inputs == oldptr)
should be
    if((i+1) == index || m_inputs == oldptr).
This goes back to 4.0 and should probably be changed in as many versions as possible. I checked replace_ptr for the other constructed features, but only the curve seems to have a problem. In the meantime, I can upload the fix to 4.3B and 4.4B.
<<END>>

huangyhg

// V44B\CONSFEAT\CURVE.CPP
if(i == (index+1) || m_inputs == oldptr)