PR 256732 Bonus Tolerance Problems

huangyhg

Bonus Tolerance Problems
<< Ron Jakl  --  08/26/08  13:50:00>>
There is something odd about the way the bonus tolerance is calculated.  See attached program for example.
A customer sent me this because on occasion they get results that have zero for the bonus tolerance when running this part program.
Using their program I found that if I create the true position dimension using the FCF dialog I also get zero for the bonus tolerance - which is what they see.  If I edit the true position dimension using the command view (remove, then add back a feature) I get a result that show values for bonus tolerances and a different true position result.
Expected Results:
No difference and bonus tolerance when applicable.
<<END>>

<< Changes made by Don Turcotte (Field Changes) -- 06/02/09  09:04:30>>
Action:  Don Turcotte to Ron Jakl, Status:  OPEN to RESOLVED
<<END>>
<< Changes made by Don Turcotte (Resolution Data) -- 06/02/09  09:04:26>>
** Bug Fix - Likely Exists in Previous Versions -  -  -  **
<<END>>
<< Don Turcotte (Development Notes)  --  06/02/09  09:03:41>>
Merged fix for 0 bonus when creating FCF with multiple features into V432.
Files inserted to server
------------------------
V432\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Tim Wernicke (Field Changes) -- 05/28/09  22:13:44>>
Action:  Tim Wernicke to Don Turcotte, Status:  MOREINFO to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Tim Wernicke (Management Notes)  --  05/28/09  22:13:42>>
Hi Don, please go ahead with the merge in V432.  Thanks.
<<END>>
<< Changes made by Don Turcotte (Field Changes) -- 05/28/09  11:52:31>>
Action:  David Petrizze to Tim Wernicke
<<END>>
<< Don Turcotte (Development Notes)  --  05/28/09  11:52:31>>
Retested in V432, V44B.  Bonuses in V432 are zero when the FCF is first created with multiple features.  Ok in V44B.  Sent e-mail to Tim:
"Tim,
Chuck Chronicle  has requested this for V432 (the fix is only in V44B).  In V432 the bonuses are reported as 0 when the FCF true position is first created with multiple features.
"
<<END>>
<< Changes made by Yanhua Huang -- 03/13/09  14:38:53>>
Assigned:  Yanhua Huang to Don Turcotte
<<END>>
<< Chuck Chronicle  --  03/03/09  09:10:48>>
Do we have any info on this?  I've got a conference call tomorrow about this and other issues.
<<END>>
<< Changes made by Chuck Chronicle -- 02/26/09  12:20:09>>
Action:  Chuck Chronicle to David Petrizze
<<END>>
<< Chuck Chronicle  --  02/26/09  08:12:35>>
What versions is this fix going to be applied to?  I need to have it in 4.3 MR2 for NC.
<<END>>
<< Changes made by Chuck Chronicle -- 02/26/09  08:13:23>>
Status:  RESOLVED to MOREINFO
<<END>>
<< Changes made by Chuck Chronicle -- 02/26/09  08:13:07>>
Action:  Ron Jakl to Chuck Chronicle
<<END>>
<< Changes made by Neil Kay -- 02/25/09  19:19:16>>
Action:  David Petrizze to Ron Jakl, Status:  REVIEW to RESOLVED
<<END>>
<< Chuck Chronicle  --  02/25/09  10:16:38>>
I have a customer who is also having a zero bonus tolerance issue.  This needs to be fixed in 4.3 MR2.
<<END>>
<< Changes made by Chuck Chronicle -- 02/25/09  10:16:43>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Yanhua Huang  --  01/07/09  13:59:50>>
I can reproduce the nominal issue in V43B, when create a new true position with "Datum Reference Frame" in V43B. So filed PR258937 for this issue.
<<END>>
<< Changes made by Yanhua Huang -- 01/07/09  14:00:27>>
Action:  Yanhua Huang to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  01/06/09  22:24:17>>
3. When alignment type = "Datum Reference Frame", feature nominals are wrong.
<<END>>
<< Changes made by Yanhua Huang -- 01/06/09  22:24:27>>
Status:  REVIEW to OPEN
<<END>>
<< Don Turcotte  --  01/05/09  14:33:54>>
Reveiwed.
This corrects the problem of the bonuses being zero but there is still some other problem in V44B since the DEV values are now very large when you F9 + OK on the true position FCF.  This is because the feature nominals are not correct in the axes list.  I tried commenting out your changes but this problem with the feature nominals remained so this may be an additional problem.  The problem with the feature nominals does not occur in V43B or V432 although those versions have zero bonuses.
<<END>>
<< Changes made by Don Turcotte -- 01/05/09  14:34:05>>
Action:  Don Turcotte to Yanhua Huang
<<END>>
<< Yanhua Huang  --  01/05/09  22:26:58>>
2. Copy "m_output_align" when call operator=(CPCDFeatCtrlFrm& cmd)
set_output_alignment(cmd.get_output_alignment());  
******************************
Mon Jan 05 22:25:30 2009
******************************
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Yanhua Huang  --  01/05/09  17:40:52>>
1. in the advanced page of FCF dialog,
default select state (single feature or multiple features) = the first line of feature list
******************************
Mon Jan 05 17:40:32 2009
******************************
Files inserted to server
------------------------
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Yanhua Huang  --  01/04/09  17:48:17>>
Thanks Ron,
Now using the FCF dialog (edit) get the same bonus as edit the dimension in edit window.
******************************
Sun Jan 04 17:46:07 2009
******************************
Files inserted to server
------------------------
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Yanhua Huang -- 01/04/09  17:49:20>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Yanhua Huang -- 12/03/08  10:37:56>>
Status:  MOREINFO to OPEN
<<END>>
<< Ron Jakl  --  12/02/08  09:25:17>>
Hi Yanhua,
I did not receive a probe file that were using with this program from the customer.  Before I submitted this problem I ran some tests on my computer  with a generic, clean, uncalibrated probe file and noticed the problems that I have described above.
The part that I found interesting is that using the dialog I ended up with a true position showing zero's for all bonus values.  If I edit the dimension in the command view I can get the dimension to display all the expected bonus values (using the same probe file).
Ron.
<<END>>
<< Changes made by Ron Jakl -- 12/02/08  09:25:20>>
Action:  Ron Jakl to Yanhua Huang
<<END>>
<< Yanhua Huang  --  12/02/08  14:45:51>>
Please attach your probe file, thanks in advance.
<<END>>
<< Changes made by Yanhua Huang -- 12/02/08  14:47:34>>
Action:  Yanhua Huang to Ron Jakl, Status:  OPEN to MOREINFO
<<END>>
<< Changes made by Tim Wernicke -- 08/26/08  14:36:16>>
Category:  true pos to GD&T, Action:  Tim Wernicke to Yanhua Huang, Assigned:   to Yanhua Huang, Priority:  to Critical
<<END>>

huangyhg

// PR256732 - yanhua
      BOOL bForceUpdateInternalCommands = FALSE;
      if (featCnt > 0 && 0 == idx) // multiplied features
        bForceUpdateInternalCommands = FALSE;  
      else
        bForceUpdateInternalCommands = (idx==0) ? TRUE : FALSE; // PR257172
      fcf->SetAxesList(tmpArray, TRUE /* <14May2009 #246272> */, idx, FALSE, bForceUpdateInternalCommands); // PR257172 // PR255040 // PR237360