PR 237360 Cannot enter size tolerance for datums at material condition with p

huangyhg

Cannot enter size tolerance for datums at material condition with profile or orientation (perpendicularity,parallelism,angularity) dimensions
<< Don Turcotte  --  12/20/05  08:03:46>>
There is no way to enter a size tolerance for datums at material condition when dimensioning profile or orientation (perpendicularity,parallelism,angularity).  The Advanced page has an "axes" dialog at the bottom for true position.  This dialog should be turned on for profile and orientation (just the axes list and not "Alignment" or "Fir to Datums" or the "True Position" group box) to allow the user to enter a size tolerance for the datums on these dimensions when the datums are at material condition.
Profile should list D1,D2, and/or D3 (whichever of these are datums of size).
Orientation should list DF, D1,D2 and/or D3 (whichever of these are datums of size).  DF is also included here although the considered feature size tolerance is included on the feature control frame.  This is consistent with the way that true position works.
<<END>>
<< Changes made by Don Turcotte -- 01/11/06  07:55:26>>
Status:  RESOLVED to CLOSED
<<END>>
<< Bret Naylor  --  01/10/06  13:24:29>>
Reviewed.
<<END>>
<< Changes made by Bret Naylor -- 01/10/06  13:24:39>>
Action:  Bret Naylor to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>
<< Paola Pallo  --  01/09/06  16:10:01>>
Reviewed.
<<END>>
<< Changes made by Paola Pallo -- 01/09/06  16:10:17>>
Action:  Paola Pallo to Bret Naylor
<<END>>
<< Don Turcotte  --  01/04/06  11:02:01>>
This is now working for orientations (perpendicularity, parallelism, angularity) and profile ( line and surface ).
Files inserted to server
------------------------
V40\DIMENS\BASIC_DI.CPP
V40\DIMENS\DIM_ANGU.CPP
V40\DIMENS\DIM_PARA.CPP
V40\DIMENS\DIM_PERP.CPP
V40\DIMENS\DIM_PROF.CPP
V40\DIMENS\FEATCTRLFRM.CPP
V40\INCLUDE\BASIC_DI.H
V40\INCLUDE\COMMAND.H
V40\INCLUDE\FEATCTRLFRM.H
V40\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V40\SOURCE\COMMAND.CPP
V40\SOURCE\MAINFRM.CPP
V41\DIMENS\BASIC_DI.CPP
V41\DIMENS\DIM_ANGU.CPP
V41\DIMENS\DIM_PARA.CPP
V41\DIMENS\DIM_PERP.CPP
V41\DIMENS\DIM_PROF.CPP
V41\DIMENS\FEATCTRLFRM.CPP
V41\INCLUDE\BASIC_DI.H
V41\INCLUDE\COMMAND.H
V41\INCLUDE\FEATCTRLFRM.H
V41\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V41\SOURCE\COMMAND.CPP
V41\SOURCE\MAINFRM.CPP
<<END>>
<< Changes made by Don Turcotte -- 01/04/06  11:02:10>>
Action:  Don Turcotte to Paola Pallo, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  01/03/06  17:26:37>>
I have this working correctly now for orientations, regardless of how many considered features are selected.  I have also modified orientations (when created from an FCF) to support primary, secondary, tertiary datums.
I have also implemented the D1,D2,D3 axes for profile (line and surface) when the datums are at material condition.  I added code to report the size table in this case.  I currently have a problem with the size tols not getting assigned (at least they don't show up in the size table of the report).
The problem noted below with command_dialog_ok(...) no longer exists with the latest download.

<<END>>
<< Don Turcotte  --  12/22/05  17:18:33>>
This now works for orientation FCFs if there are only one or two considered features.  When there are 3 or more considered features, only the first and last feature have size tols in the report even though I set size tols on the all the features on the Advanced page of the FCF dialog.  Setting the D1 (datum) size tols always works.  The current implementation of orientation dimensions don't support more than one datum.  
Stepping through the code with the debugger, the size tols are correctly inserted in the dimension commands when the FCF is created.  I haven't figured out yet where they get lost.  
I noted that this doesn't work correctly for other dimensions either so this may simply be an existing bug and not something new created by the implementation of axes for orientation FCFs.
Also, with the latest build, the ap crashes in command_dialog_ok(...) trying to create a datdef command or legacy dimension.
I have uploaded what I have so far since this works correctly for the most common case of a single considered feature.
Files inserted to server
------------------------
V40\DIMENS\DIM_ANGU.CPP
V40\DIMENS\DIM_PARA.CPP
V40\DIMENS\DIM_PERP.CPP
V40\DIMENS\FEATCTRLFRM.CPP
V40\INCLUDE\FEATCTRLFRM.H
V40\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V41\DIMENS\DIM_ANGU.CPP
V41\DIMENS\DIM_PARA.CPP
V41\DIMENS\DIM_PERP.CPP
V41\DIMENS\FEATCTRLFRM.CPP
V41\INCLUDE\FEATCTRLFRM.H
V41\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Don Turcotte  --  12/21/05  17:33:53>>
I have implemented the axes list for orientation dimensions.  The possible axes for orientations are DF, D1,D2,D3.   The axes show up in the list and can be edited, but the values don't stick in the dimension.  The first time CPCDFeatCtrlFrm::SetAxesList(...) is call the values for plus/minus tol for DF and D1 are correct but in subsequent calls they get lost.  I am still debugging this.
I added code to support the axes list for surface profile also (just D1,D2,D3) but I noticed that there is code in DIM_PROF.cpp to compute the datum bonus by searching up for a preceding location dimension with D axis to get the plus/minus tol on the datum.
<<END>>
<< Changes made by Bret Naylor -- 12/20/05  14:20:20>>
Action:  Paola Pallo to Don Turcotte, Assigned:  Paola Pallo to Don Turcotte
<<END>>