PR 249085 Lower tier FCF profile doesn't verify datums when "form o

huangyhg

Lower tier FCF profile doesn't verify datums when "form only" selected

<< Don Turcotte  --  07/10/07  14:43:25>>
When a profile FCF is created with "Form only" selected, PC-DMIS does not verify the datums used in the lower tier since datums are not required for "Form only".  If datums are used in the lower tier, they should always be verified to be correct.  If the profile FCF is not a composite, then the lower tier datums can be in any order relative to the upper tier or they can be completely different datums.  This is true regardless of the setting of "Form Only".  When the profile FCF is a composite, the datums in the lower tier must be the same datums in the same order of precedence, although not all three datums need be specified.
<<END>>


<< Changes made by Don Turcotte -- 05/27/08  09:39:49>>
Status:  RESOLVED to CLOSED
<<END>>
<< Domenico Varacalli  --  04/08/08  11:23:10>>
I have verified with both the versions. (V4.2MR2 - March 25, 2008) and (V4.3R - Apr 2, 2008).
The specific cases of FCF on the profile (Line and Surface) verify the correctness of the rule when thetolerance is composite.
I have also verified the cases in which the profile FCF is not a composite. This part correctly it works.
<<END>>
<< Jerry Naylor  --  12/24/07  16:17:53>>
wasaddedtoreadme42RMR2
<<END>>
<< David Petrizze  --  12/20/07  08:48:32>>
Reviewed.  I have reviewed Don's changes and they look good to me.
<<END>>
<< Changes made by David Petrizze -- 12/20/07  08:49:03>>
Action:  Domenico Varacalli to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>
<< Tim Wernicke  --  12/19/07  15:41:26>>
Thanks Don.
Mimmo, could you please confirm this as part of your 4.3 GD&T testing?
<<END>>
<< Changes made by Tim Wernicke -- 12/19/07  15:41:30>>
Action:  Tim Wernicke to Domenico Varacalli
<<END>>
<< Don Turcotte  --  12/19/07  14:17:51>>
Merged into V42R and V43R.
I also merged Dave's fix to FeatCtrlFrmCells.cpp into V42 beta since the other changes here were also made to V42 beta.  All the changes except Dave's fix to FeatCtrlFrmCells.cpp were made to V43B before the code split to V43R so only that file was uploaded to V43R.
Files inserted to server
------------------------
V42R\DIMENS\DIM_PROF.CPP
V42R\DIMENS\FEATCTRLFRMUTIL.CPP
V42R\INCLUDE\DIM_PROF.H
V42R\INCLUDE\FEATCTRLFRMUTIL.H
V42R\MENU\FEATCTRLFRMCELLS.CPP
V42R\MENU\FEATCTRLFRMDLG.CPP
V42\MENU\FEATCTRLFRMCELLS.CPP
V43R\MENU\FEATCTRLFRMCELLS.CPP
<<END>>
<< Changes made by Don Turcotte -- 12/19/07  14:18:22>>
Action:  Don Turcotte to Tim Wernicke, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  12/19/07  09:52:02>>
Hi Don, please merge the changes into V42R, V43R per my e-mail.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 12/19/07  09:52:34>>
Status:  RESOLVED to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte  --  12/18/07  11:19:15>>
Reviewed.
Thanks,Dave
<<END>>
<< Changes made by Don Turcotte -- 12/18/07  11:19:58>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>
<< Changes made by Don Turcotte -- 12/18/07  11:19:15>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< David Petrizze  --  12/17/07  17:01:40>>
For review:
******************************
Mon Dec 17 16:20:18 2007
******************************
Files inserted to server
------------------------
V43B\MENU\FeatCtrlFrmCells.CPP
V44B\MENU\FeatCtrlFrmCells.CPP
<<END>>
<< Changes made by David Petrizze -- 12/17/07  17:01:49>>
Action:  David Petrizze to Don Turcotte
<<END>>
<< David Petrizze  --  12/14/07  17:57:07>>
I have fixed this but am not in a position to upload.  Will take care of this on Monday.
<<END>>
<< Changes made by David Petrizze -- 12/14/07  17:57:21>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  12/12/07  17:30:26>>
Digging into this more...  Dave will call tomorrow to work with me on this.
<<END>>
<< Don Turcotte  --  12/10/07  15:58:04>>
I spent time looking at this again but will need to discuss this with Dave to proceed further.
<<END>>
<< Don Turcotte  --  10/12/07  17:26:31>>
I have been looking at this again.  In the process I found a problem with true position FCFs that was introduced by PR241909.  Composite true position FCFs and two single segment true position FCFs allow different datums on lower segment than on upper segment.  I filed this as PR250927.
I still have not resolved the issue here which is that when the lower segment profile can have different datums than the upper segment, a material condition on a lower segment datum will write over the following cell so the next datum cannot be entered.
<<END>>
<< Don Turcotte  --  07/11/07  14:24:59>>
I have completed this and uploaded for V42 beta and V43B.  The only remaining issue is that when the upper tier datum does not have an MMC condition but the lower tier datum does, then the MMC symbol is placed in the next box in the FCF editor (and preview).  The graphics display and report are ok in this case.  I have not been able to figure out how to correct this so I will talk to Dave who wrote the code that controls the FCF dialog cells.
Files inserted to server
------------------------
V42\DIMENS\DIM_PROF.CPP
V42\DIMENS\FEATCTRLFRMUTIL.CPP
V42\INCLUDE\DIM_PROF.H
V42\INCLUDE\FEATCTRLFRMUTIL.H
V42\MENU\FEATCTRLFRMDLG.CPP
V43B\DIMENS\DIM_PROF.CPP
V43B\DIMENS\FEATCTRLFRMUTIL.CPP
V43B\INCLUDE\DIM_PROF.H
V43B\INCLUDE\FEATCTRLFRMUTIL.H
V43B\MENU\FEATCTRLFRMDLG.CPP
<<END>>
<< Don Turcotte  --  07/10/07  17:47:44>>
I have modified the dialog so that the datums are always verified regardless of "Form Only".  I have also changed the dialog so that lower tier profile when not composite allows different datums or different datum order.  One cosmetic issue with dialog is that when upper tier datum does not have an MMC condition (e.g., plane), but lower tier datum does, then the MMC symbol is placed in the next box over.  The graphics display and report are ok in this case, though.
I also need to modify the dim_profile math so that when the lower tier has different datums or different order, the math is done correctly.
<<END>>