PR 254873 - Outtol profile dimension showing red text and green/blue bar

huangyhg

<< Anders Isaksson  --  05/09/08  10:53:23>>
Look at PROF2, PROF7 in the attached program. The profile dimensions are outtol, the numbers are red in the report, but the deviation bar is a mix of green (to the left of center) and blue (to the right of center)!
<<END>>

huangyhg

<< Don Turcotte  --  05/13/08  11:48:27>>
When UseISOCalculations is set in the registry the profile dimension is treated as a unilateral dimension.  In this case, the DEV value should be 2 times max or min (whichever absolute value is larger).  The percentage for the linear graphic was not being calculated correctly in this case.  Also, for FCF profile the +TOL reported was 0.0.  I have fixed these problems in V43R, V43B, V431, V44B as well as V42R, V42B (see PR# 254872).

After setting UseISOCalculations to 1 in the registry, start pc-dmis and load the program.  You must then do an F9 + Create on each profile dimension to re-evaluate the dimension and get the corrected report.

Files inserted to server
------------------------
V42R\DIMENS\FEATCTRLFRM.CPP
V42R\MENU\DIMENSIO.CPP

V43B\DIMENS\FEATCTRLFRM.CPP
V43B\MENU\DIMENSIO.CPP

V43R\DIMENS\FEATCTRLFRM.CPP
V43R\MENU\DIMENSIO.CPP

V431\DIMENS\FEATCTRLFRM.CPP
V431\MENU\DIMENSIO.CPP

V44B\DIMENS\FEATCTRLFRM.CPP
V44B\MENU\DIMENSIO.CPP

V42\DIMENS\FEATCTRLFRM.CPP
V42\MENU\DIMENSIO.CPP
<<END>>

<< Changes made by Don Turcotte -- 05/13/08  11:48:53>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>

<< Anders Isaksson  --  05/13/08  12:49:11>>
OK. Actually, in this case we had forgotten to set UseISOCalculations. With that set to 1, we get only blue in the bar. The mix of green and blue (intol AND outtol) was very confusing.

Unfortunately something is still mixed up. Now the deviation bar is drawn as for a unilateral tolerance, filling the whole rectangle, at the same time PROF9 and PROF10 show negative deviations and have only a very small red rectangle to the extreme left.

Is a FORMANDLOCATION a unilateral or a bilateral tolerance when UseISOCalculations is set to 1? The numbers indicate bilteral while the bar is drawn unilateral.

The calculations are also suspect, looking at the MIN and MAX values, PROF8 should be OK. The tolerance is +/- 0.5 and the MAX deviation is 0.409 (The full tolerance span is 1.0, the ASME deviation is 0.409 - (-0.144) = 0.553, and the ISO deviation is 0.409 * 2 = 0.818).

<<END>>

<< Changes made by Anders Isaksson -- 05/13/08  12:49:31>>
Action:  Anders Isaksson to Don Turcotte, Status:  RESOLVED to OPEN
<<END>>

<< Don Turcotte  --  05/12/08  14:53:36>>
This is simply a function of how you have set up your dimension color table.  Profile formandlocation is a bilateral tolerance.  The left hand side of the graphic shows the deviation below the norminal surface or line (the min value in relation to the -TOL).  The right hand side of the graphic shows the deviation above the nominal surface or line (the max value in relation to the +TOL).  Your color table has defined an "Out of 100% of Negative Tolerance" color of red.  This controls the color on the left hand side of the graphic.  The color table has defined an "Out of 100% of Positve Tolerance" color of blue.  This controls the color on the right hand side of the graphic.  For PROF2 and PROF7, the out of tol condition occurs on the max (right hand) side so this is drawn as blue.  If you edit your color table to specify red as the "Out of 100% of Positve Tolerance", then the graphic will show red on the right hand sides of these two profile dimensions.

To edit the dimension colors use:
  Edit | GraphicsDisplayWindow | DimensionColor...
<<END>>

huangyhg

1.
T:\V44B\MENU\DIMENSIO.CPP(7589): // PR254873 - if UseISOCalculations, profile is unilateral and plus tol should be full tol
// PR254873 - if UseISOCalculations, profile is unilateral and plus tol should be full tol
if ( dcmd->type() == DIMENSION_PROFILE_SURFACE || dcmd->type() == DIMENSION_PROFILE_LINE )
{
if(global_UseISOCalculations)
{
plus += minus;
minus = 0.0;
}
}
2.
T:\V44B\DIMENS\FEATCTRLFRM.CPP(13256): SetProfilePlusTol(_ttof(GetLine2TolStr())); // PR254873
if((GetProfileFormOption() == FCF_FORM_ONLY && GetProfileBestFitMathOption() != OPTIMIZED_FIT) || global_UseISOCalculations) // #235252
{
((CPCDdim_profile *)newptr)->set_plus_tol(_ttof(GetLine2TolStr()));
SetProfilePlusTol(_ttof(GetLine2TolStr())); // PR254873
SetProfileMinusTol(0.0);
}
3.
T:\V44B\DIMENS\FEATCTRLFRM.CPP(13327): SetProfilePlusTol(_ttof(GetLine2TolStr())); // PR254873