Rreview - PR 254633 Clicking Use Legacy Dimensions on and off sometimes doesn

huangyhg

Clicking Use Legacy Dimensions on and off sometimes doesn't produce the correct flatness dimension

<< Dan Zwick  --  04/24/08  17:14:08>>
Sometimes a legacy flatness dimension is computed when Use Legacy Dimensions is unchecked and sometimes an FCF flatness dimension is computed even though Use Legacy Dimensions is checked.

Steps to reproduce:
Load the attached part program. Click on Insert | Dimension | Use Legacy Dimensions (it should be unchecked). Insert a flatness dimension at the end of the part program with Insert | Dimension | Flatness using PLN2. This should result in a flatness deviation of 0.18683. Now click Use Legacy Dimensions off and then insert another (FCF) flatness dimension for PLN2. The same flatness deviation of 0.18683 is computed. The legacy flatness is being computed because m_bUseLegacyForm is still 1 in CPCDplane_feature::flatness, although the FCF dialog came up.
<<END>>

<<*Yanhua Huang  --  08/10/08  22:48:50>>
Reviewed code of V43R and V44B. Did test in V43R and V44B.
works.
<<END>>
<< Changes made by Neil Kay -- 07/23/08  16:58:04>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Dan Zwick  --  04/25/08  08:59:23>>
I tested this with 4.3R this morning and now it seems to work correctly. Thanks, Don.
<<END>>
<< Don Turcotte  --  04/25/08  10:27:21>>
The problem here is that the m_bUseLegacyForm flag was not being set on the feature in the CPCDdim_flatness::do_math(...).  This was done for circularity and cylindricity when the Y14.5 form was implemented for these dimensions, but not for flatness and straightness.  I made this fix for both flatness and straightness, even though only flatness uses the flag.  In the future, we will implement Y14.15 straightness so I am trying to avoid this issue again with straightness.
With the fix, the FCF flatness of PLN2 in the attached program reports a deviation of 0.14630 (Y14.5 flatness).  The legacy flatness reports a deviation of 0.18683 (least squares flatness).
Fixed in V43R, V43B, V44B.
Files inserted to server
------------------------
V43B\DIMENS\DIM_FLAT.CPP
V43B\DIMENS\DIM_STRA.CPP
V43R\DIMENS\DIM_FLAT.CPP
V43R\DIMENS\DIM_STRA.CPP
V44B\DIMENS\DIM_FLAT.CPP
V44B\DIMENS\DIM_STRA.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/25/08  10:27:46>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Bill Wilcox -- 04/25/08  07:44:01>>
Priority:  to Stop Rel.
<<END>>