Review-PR 254670 Positive Reporting Does not work when Feature Nominals are u

huangyhg

Positive Reporting Does not work when Feature Nominals are updated during execution
<< Matthew Kopesky  --  04/26/08  13:03:41>>
Attached a part program - The positive reporting feature does not behave as needed when the nominals are being updated during execution by fileIO
Examples
1 - Feed in nominal data into an auto feature and related dimension nominal. The report will make the nominal negative when it's normally a positive number (when the input nominal is negative everything works)
2 - Force the nominal to be positive with an Assignment or ABS() function. Positive reporting fails to make the measured result positive
Steps to reproduce:
This can be duplicated offline - Attached part program / probe file / text file with nominals in it. You will have to run the program twice and pick two different holes when the input comment prompts you.
<<END>>

<< Changes made by Neil Kay -- 07/23/08  17:00:18>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Don Ruggieri  --  05/16/08  16:36:44>>
I tested this in v4.2MR1 and v43R, and both seem to be working now as described in the Help documentation.  I've run multiple tests with the ALLDATA and DEVIATION option, as well as with Positive Reporting OFF and ON.
<<END>>
<< Don Turcotte  --  05/14/08  11:47:42>>
I have fixed this so when positive reporting is on, the MEAS / NOM is always positive , and the DEV / OUTTOL show positive when the axis is long, and negative when the axis is short.  Now that positive reporting is working, you must remove the ABS() on nominal X and Y in your program, otherwise OUTTOL will report large values since you will be converting all the input values from the txt file to positive numbers.
I have attached my test program in which I modified the FILE/OPEN statement to point to my hard drive and I replaced the COMMENT/INPUT to a loop which always iterates through all four circles.  I also removed the ABS() from X, Y.  I have run this online with the simulator to verify the results.
Fixed in V42R MR2, V43R, V431 as well as the betas for V42, V43B, V44B
Files inserted to server
------------------------
V42R\DIMENS\LOCATION.CPP
V43B\DIMENS\LOCATION.CPP
V43R\DIMENS\LOCATION.CPP
V431\DIMENS\LOCATION.CPP
V44B\DIMENS\LOCATION.CPP
V42\DIMENS\LOCATION.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/14/08  11:47:51>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  05/13/08  17:28:05>>
I tried this in several versions of PC-DMIS together with Don R.  They all seem wrong but are not consistent with each other.  I have a fix which I think corrects the problem, but I'm not certain how this should work in all cases so I sent e-mail to Matt Kopesky:
"Matt,
Is this working correctly in an earlier version of PC-DMIS (What version of PC-DMIS is Caterpillar running)?  We have tried this in V3.5 MR2, V37 MR3, V42 MR1 and V43 beta.   None of these seems to be correct, but they do no all produce the same results.  Could you send me a PDF of a correct offline execution of all 4 circles with both ABS() on X,Y and ABS() removed from X,Y.  We need to understand what results you expect to see for NOMINAL, MEAS, DEV and OUTTOL to be able to fix this problem
"
<<END>>
<< Changes made by David Petrizze -- 05/13/08  09:52:08>>
Action:  CMM Group to Don Turcotte, Assigned:  CMM Group to Don Turcotte
<<END>>
<< Bill Wilcox  --  05/05/08  23:00:30>>
Tim, this is not a reporting issue. It is a problem with the dimension commands. It seems this should be assigned to the CMM group.
<<END>>
<< Changes made by Bill Wilcox -- 05/05/08  23:00:40>>
Category:  Reporting to dimensions, Action:  Liqiang Zhu to CMM Group, Assigned:  Liqiang Zhu to CMM Group
<<END>>
<< Tim Wernicke  --  05/05/08  16:16:47>>
Hi Liqiang, this is affecting Caterpillar here in the US.  We need a solution for them very soon.
<<END>>
<< Changes made by Tim Wernicke -- 05/05/08  16:16:55>>
Priority:  Critical to Stop Rel.
<<END>>
<< Changes made by Ken Woodbine -- 04/27/08  20:25:53>>
Action:  Tim Wernicke to Liqiang Zhu, Assigned:   to Liqiang Zhu, Priority:  to Critical
<<END>>
<< Matthew Kopesky  --  04/26/08  13:07:53>>
Uploaded files - This is a Caterpillar - East Peoria issue that is a serious concern as they use this tool in nearly every program.
<<END>>