PR 247888 Form divation of the inner sphere display the wrong vectors

huangyhg

Form divation of the inner sphere display the wrong vectors
<< Jean Wang -- 04/30/07 16:59:45>>
When I display the "textual form divation analysis", and I found that IJK vectors wrong. Please see the sphere1.rar on the server.
<<END>>

<< Don Turcotte  --  02/26/09  09:21:30>>
The vector reported in textual_analysis for both circularity and cylindricity needed to be normalized.  All other dimensions are ok.
Fixed in V44B.
Files inserted to server
------------------------
V44B\DIMENS\DIM_CIRC.CPP
V44B\DIMENS\DIM_CYLY.CPP
<<END>>
<< Changes made by Don Turcotte -- 02/26/09  09:21:56>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  02/25/09  22:42:11>>
1. The I, J, K vector in this report should be normalized.
<<END>>
<< Changes made by Yanhua Huang -- 02/25/09  22:42:16>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Don Turcotte  --  02/23/09  09:45:27>>
Sent e-mail to Yanhua:
"Yanhua,
Jean is referring to the TEXT=ON report of the FCF dimension.







The I, J, K vector in this report should be normalized.  I think this may be the only problem here.

"
<<END>>
<< Changes made by Neil Kay -- 12/12/08  09:24:33>>
Action:  Wade Burton to Yanhua Huang, Assigned:  Don Turcotte to CMM Group
<<END>>
<< Changes made by Neil Kay -- 07/23/08  12:22:21>>
Action:  David Petrizze to Wade Burton
<<END>>
<< Don Turcotte  --  08/14/07  15:08:15>>
The problem here is that both circularity and cylindricity were computing the vector without regard to whether the feature was inner or outer.
Fixed in V42 beta and V43B.
Files inserted to server
------------------------
V42\DIMENS\DIM_CIRC.CPP
V42\DIMENS\DIM_CYLY.CPP
V43B\DIMENS\DIM_CIRC.CPP
V43B\DIMENS\DIM_CYLY.CPP
<<END>>
<< Changes made by Don Turcotte -- 08/14/07  15:08:21>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 04/30/07  09:05:08>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to High
<<END>>

huangyhg

V42\DIMENS\DIM_CIRC.CPP
void CPCDdim_circularity::textual_analysis(BOOL send_to_report /* TRUE */)
   
// PR247888
    if( m_feature1->bit(INOUT) ) // if inner, reverse the vector
      vector = - vector;