PR 252759 Concentricity calcualtion wrong

huangyhg

<< Robert Podeu  --  01/18/08  14:18:09>>
In the attached part program you can see the difference in the calculation of the conentricity in V3.7 and V4.2 MR1. In V4.2 you have to choose the wrong working plane to get the correct dimension. Will this be solved in MR2?
<<END>>

<< Don Turcotte  --  09/03/08  11:43:26>>
Merged into V42R MR2, V431 (V43 MR1) per PR #256825.  Please read that PR for details.
<<END>>
<< Don Turcotte  --  08/26/08  14:32:00>>
This problem has been fixed by PR # 256704.  Please read that PR for details.
<<END>>
<< Changes made by Don Turcotte -- 08/26/08  14:32:00>>
Status:  OPEN to RESOLVED
<<END>>
<< Changes made by Robert Podeu -- 08/26/08  09:38:52>>
Assigned:  Don Turcotte to Tim Wernicke
<<END>>
<< Changes made by Robert Podeu -- 08/23/08  13:21:06>>
Action:  Tim Wernicke to Robert Podeu
<<END>>
<< Changes made by Robert Podeu -- 08/23/08  13:20:02>>
Status:  RESOLVED to OPEN
<<END>>
<< Robert Podeu  --  08/22/08  13:34:32>>
The calculation of a concentricity in V4.3R 26.06.2008 is only working correct in workplan Zplus or Zminus. In the other working plans the calculation is wrong. Will this be fixed in V4.3R?
<<END>>
<< Changes made by Robert Podeu -- 08/22/08  13:35:26>>
Action:  Jerry Naylor to Tim Wernicke
<<END>>
<< Changes made by Robert Podeu -- 08/22/08  13:34:38>>
Action:  Robert Podeu to Jerry Naylor
<<END>>
<< Jerry Naylor  --  02/11/08  11:37:42>>
wasaddedtoreadme43B
<<END>>
<< David Petrizze  --  01/30/08  17:11:20>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 01/30/08  17:11:24>>
Action:  David Petrizze to Robert Podeu, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  01/30/08  14:17:13>>
I have fixed the additional problem of the graphical analysis not defaulting to the correct view.
Fixed in V43B, V44B.
Files inserted to server
------------------------
V43B\HYPER\HYPERANALCTRL4.CPP
V44B\HYPER\HYPERANALCTRL4.CPP
<<END>>
<< Changes made by Don Turcotte -- 01/30/08  14:17:58>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  01/24/08  13:44:03>>
I have verified that there is still an issue with graphical analysis.  The calculations are correct, but the viewpoint always defaults to the XY plane.  Double-clicking on the graphical analysis in the report allows you to rotate the drawing to show that everything is drawn correctly but in the wrong view.
<<END>>
<< David Petrizze  --  01/23/08  20:01:56>>
Don Please review Domenico's latest comment
<<END>>
<< Changes made by David Petrizze -- 01/23/08  20:02:02>>
Status:  REVIEW to OPEN
<<END>>
<< Changes made by Tim Wernicke -- 01/23/08  15:40:08>>
Action:  David Petrizze to Don Turcotte
<<END>>
<< Domenico Varacalli  --  01/23/08  18:37:06>>
I have verified the Concentricity also with the last version 4.3RC, changing all the workplanes, (Plus and Minus).
For these examples I have used circles, with tolerances FCF and Lagacy, reversing the order of the Datum and the checked Features.
The results of the calculations seem correct and coherent for both the methods (FCF and Lagacy), but there is perhaps some problem
in the graphic representation. To see the PDF files: 3,4,7,8. (252759_1.zip). For instance (file CONCEN_3.PDF) I do not uderstand why
the Concentricity of CIR2 is represented by the red vector and that of the CIR8 is not represented. Is the plane of projection wrong in the sketch?
I see always drawn X and Y.
<<END>>
<< Don Turcotte  --  01/21/08  17:24:24>>
I have fixed this so both the legacy and FCF concentricity dimensions give consistent (correct) results regardless of the active workplane.  I have tested this with the program attached to this PR and also the program attached to PR # 245284 (Concentricity to a datum circle should be a 2D calculation (don't level to datum circle)).
Files inserted to server
------------------------
V42\DIMENS\DIM_CONC.CPP
V43B\DIMENS\DIM_CONC.CPP
V44B\DIMENS\DIM_CONC.CPP

<<END>>
<< Changes made by Don Turcotte -- 01/21/08  17:27:05>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 01/18/08  08:36:58>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

V44B\HYPER\HYPERANALCTRL4.CPP
  
  else if( dimtype == DIMENSION_CONCENTRICITY ) // PR252759
    {
      CPoint3 vector;
      vector[0] = m_dimanalysis_activex.GetMeasVector2_I();
      vector[1] = m_dimanalysis_activex.GetMeasVector2_J();
      vector[2] = m_dimanalysis_activex.GetMeasVector2_K();

      G3VIEWSET viewset;
      m_pDisplay->GetViews(viewset);
      CTransform ViewTrans;

      ViewTrans.newmat(vector);

      for (int i = 0; i < 4; i++)
      {
        for (int j = 0; j < 3; j++)
        {
          viewset.views[0].Trans[j] = ViewTrans.m_data[j];
        }
      }
      m_pDisplay->SetViews(viewset);
    }