PR 255186 Line Straightness graphic not drawn in the correct place

huangyhg

Line Straightness graphic not drawn in the correct place
<< Bob Hospadaruk  --  05/27/08  16:50:17>>
Open enclosed program.  Search for dimension STRA7.  Look in the graphic window.  The graphic for the dimension is drawn well into the material of the part.  I might be off by the tip diameter?
Another huge problem for our demo
<<END>>

<< Changes made by Neil Kay -- 02/25/09  19:13:00>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Dan Zwick  --  06/03/08  10:46:35>>
Ok, go ahead and back out my changes. There are two functions: one that says that the number of inputs is limited, and one that sets the maximal number of inputs. You might want to consider setting a limit on the number of inputs they can select at once. If they do a Ctl-A and select all of them by mistake it could produce several hundred at once.
<<END>>
<< Paola Pallo  --  06/03/08  15:27:15>>
Dan, my fix  is intended to create multiple separate filter set commands ( each one having one input and one output)  using the multiple selection capability of the dialog .
Looking the code of filterob.cpp\ read_dialog() method, this was the original design, and  now it works correctly .
The fix done in 255185  is a limitation, allowing the single selection only, and it would be backed out .
<<END>>
<< Dan Zwick  --  05/30/08  10:33:15>>
Paola, I fixed the multiple inputs crash by only allowing one input to the constructed filter for PR 255185. I'm not sure what your changes do, but as it now stands there can only be one input. So either your changes are superfluous, or my changes need to be backed out --- if you have somehow found a way for a constructed filter to handle more than one input. If so, I would like to know how this is done now since a constructed feature can only have one output.
<<END>>
<< Paola Pallo  --  05/29/08  18:05:56>>
There are more problems here (not specifically related to the workplane as initially thought)
The graphic window  issue ( the straightness is drawn shifted into the material)  is the same problem already addressed in 254949, and it should be fixed . Please refer to it for more details.
The application error displayed in filterset.jpg was related to a bug in the  multiple creation of filter set commands, and I fixed it.  
As agreed with Tim I merged my fix also in v43R and v431. For review:
------------------------
V431\CONSFEAT\FILTEROB.CPP
V43R\CONSFEAT\FILTEROB.CPP
V43B\CONSFEAT\FILTEROB.CPP
V44B\CONSFEAT\FILTEROB.CPP
<<END>>
<< Changes made by Paola Pallo -- 05/29/08  18:06:35>>
Action:  Paola Pallo to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  05/29/08  10:06:47>>
Please go ahead with your runtime fix per our Skype.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 05/29/08  10:06:50>>
Priority:  Critical to Stop Rel.
<<END>>
<< Bob Hospadaruk  --  05/29/08  10:50:11>>
I did have a mistake in the correct workplane which I now fixed, but the line is still drawn off location in the straigntness graphic.
<<END>>
<< Paola Pallo  --  05/28/08  18:19:40>>
I suspect an issue with the working plane ( here it's YMINUS)  not correctly considered when managing the point data.
Sometimes in the past we had wrong results because using the default (ZPLUS) instead of the current one. I will investigate further tomorrow
<<END>>
<< Changes made by Tim Wernicke -- 05/27/08  18:19:52>>
Action:  Tim Wernicke to Paola Pallo, Assigned:   to Paola Pallo, Priority:  to Critical
<<END>>