PR 256827 Default feature tolerance not working as expected

huangyhg

<< Christian Furnival  --  09/02/08  16:39:23>>
For test purposes I set my circle tolerance to 0.5 and then set my 2D profile to 1.
I measured a circle, and then used 2D Profile on the same feature.  I did a quick location dimension on both features and got the following.

Circle
X 0.500
Y 0.500
D 0.500

2DProfile
X 1.000
Y 1.000
Z 1.000

The tolerance was as expected.  I then changed the default tolerance for both feature types.
I set the circle to 1, and the 2D Profile to 0.5.
And again, measured 2 new features with location dimensions.
These were the results.

Circle
X 1.000
Y 1.000
D 0.500

2DProfile
X 1.000
Y 1.000
Z 1.000

My questions are:
On the circle, why did the X and Y tolerance change to the new default value but not the diameter??
On the 2D Profile the tolerance remained as 1.000, this did not change to to the new default value.

I have attached my PP and PRB files.
<<END>>


<< Christian Furnival  --  02/24/09  16:25:51>>
Fixed in 44b dated 23rd Feb
<<END>>
<< Changes made by Christian Furnival -- 02/24/09  16:26:52>>
Status:  RESOLVED to CLOSED
<<END>>
<< Changes made by Troy Johnson -- 02/03/09  15:38:12>>
Action:  Troy Johnson to Christian Furnival
<<END>>
<< Jared Hess  --  02/03/09  13:41:54>>
I've modified the paragraph but added in a note before it to mentione that Default Feature Tolerance only applies to legacy dimensions. The first three paragraphs now read as follows:
---
The Default Feature Tolerance area, enabled when you select the Feature Type option from the Apply Defaults Based On area, lets you define default dimension tolerances based on individual feature types.
Note: This capability only applies for legacy dimensions.
Whenever PC-DMIS creates a dimension automatically, because you used the Auto Dimension Setup... button, the default dimension tolerance associated with that feature type will be used, unless that same feature type already exists in the part program. In that case, PC-DMIS will instead use the tolerance for the existing feature for any new automatic dimensions of that same feature type. This way you only need to modify the tolerance once for a feature type and PC-DMIS will use that same tolerance for other features of the same type throughout the rest of your part program.
---
<<END>>
<< Changes made by Jared Hess -- 02/03/09  13:43:29>>
Action:  Christian Furnival to Troy Johnson
<<END>>
<< Changes made by Jared Hess -- 02/03/09  13:43:13>>
Action:  Jared Hess to Christian Furnival, Status:  DOCUMENT to RESOLVED
<<END>>
<< Troy Johnson  --  02/03/09  09:31:10>>
Jared, Yanhua pointed out that the Auto option in the location dialog doesn't refer to the auto dimensioning capability but rather automatically choosing the correct axes to dimension. We probably ought to remove that. I would suggest that we reword the paragragph to something like this:
Whenever PC-DMIS creates a dimension automatically because you used the Auto Dimension Setup... button, the default dimension tolerance associated with that feature type will be used, unless that same feature type already exists in the part program. In that case, PC-DMIS will instead use the tolerance for the existing feature for any new automatic dimensions of that same feature type. This way you only need to modify the tolerance once for a feature type and PC-DMIS will use that same tolerance for other features of the same type throughout the rest of your part program. It should be noted that this capability only applies for legacy dimensions.
<<END>>
<< Changes made by Troy Johnson -- 02/03/09  09:31:26>>
Action:  Troy Johnson to Jared Hess
<<END>>
<< Jared Hess  --  01/29/09  16:21:29>>
Troy, I have this documentation:
http://10.57.112.13/WAIhelp/Core/06_pref_topics/Default_Feature_Tolerance.htm can you take a moment and review it to ensure it's correct or if it need to be clearer? It's only a couple of paragraphs.
<<END>>
<< Changes made by Jared Hess -- 01/29/09  16:22:01>>
Action:  Jared Hess to Troy Johnson
<<END>>
<< Changes made by Tim Wernicke -- 01/27/09  08:28:13>>
Priority:  Critical to Stop Rel.
<<END>>
<< Troy Johnson  --  01/26/09  17:28:21>>
I reviewed this with Dave and he agrees with the changes. I have uploaded to V43B, V432 and V44B. Files uploaded:
V432\DIMENS\START_LO.CPP
V432\INCLUDE\DEFINES.H
V432\MENU\DIMENSIO.CPP
V432\SOURCE\COMMAND.CPP
V43B\DIMENS\START_LO.CPP
V43B\INCLUDE\DEFINES.H
V43B\MENU\DIMENSIO.CPP
V43B\SOURCE\COMMAND.CPP
V44B\DIMENS\START_LO.CPP
V44B\INCLUDE\DEFINES.H
V44B\MENU\DIMENSIO.CPP
V44B\SOURCE\COMMAND.CPP
Jared, we can now update the documentation.
<<END>>
<< Changes made by Troy Johnson -- 01/26/09  17:28:32>>
Action:  Troy Johnson to Jared Hess, Status:  OPEN to DOCUMENT
<<END>>
<< Jared Hess  --  01/26/09  11:27:33>>
1-21-08 Worked on Auto Dimensioning dialog box changes.; Took new capture of dialog and have asked Troy to review existing documentation on this.
<<END>>
<< Troy Johnson  --  01/23/09  17:00:28>>
I believe I have this fixed and working as the original design was intended. Since the original design was obviously not clear, I will try and clarify it here. We added the ability to set default tolerance values based on feature type rather than a generic tolerance for all features. However, if there was already a feature in the part program we use the tolerance applied to the previous feature in the program. That way the user only has to modify the tolerance once and it will continue to follow that tolerance for the rest of that part program or until the user modifies the tolerance again.
So, in the test that Christian did I was suprised that the second circle and line used the new feature tolerance because that was not how it was supposed to work. I have made a couple of modifications to the source to make it work as it was intended to. However, because some of the modifications are in areas of the code that are used all over, I'd like to have Dave or Don T. review them with me before I actually upload them. I will check with Dave on Monday and see if he has some time.
<<END>>
<< Troy Johnson  --  01/22/09  17:08:34>>
Looking into this to understand everything brought up by Christian and Yanhua.
<<END>>
<< Changes made by Troy Johnson -- 01/22/09  12:53:02>>
Action:  Portable Group to Troy Johnson, Assigned:  Portable Group to Troy Johnson
<<END>>
<< Changes made by David Petrizze -- 01/16/09  08:31:35>>
Action:  Yanhua Huang to Portable Group, Assigned:  Yanhua Huang to Portable Group
<<END>>
<< Jared Hess  --  12/22/08  12:08:06>>
12-16-08 I looked into this to make needed documenation changes but I need a later v44 in order to look at it and there hasn't been a good build since late November so I'm holding off on anything for now.
<<END>>
<< Yanhua Huang  --  12/18/08  22:55:34>>
Sent an Email to Troy, Dave and Don T.
Hi all,
Do you agree the rule below for "Default feature tolerance"?
"Default feature tolerance" just affects the first legacy dimension (automatical creation).
When "Default feature tolerance" is checked and  automatically create legacy dimensions (location, legacy true position, legacy runout and legacy form dimensions), will specify the following rule.
1. If do not find the previous dimension, use default feature tolerance.
2. If find the previous dimension, use the previous dimension tolerance.
<<END>>
<< Yanhua Huang  --  12/18/08  22:50:38>>
Sent an Email to Troy.
Troy,
Forget?
I have not received your email by now.
yanhua
[12/17/2008 11:00:24 PM] yanhua Huang says: hi in?
[12/17/2008 11:00:59 PM] Troy Johnson says: I am now, yes. Getting ready to join a meeting.
[12/17/2008 11:02:24 PM] yanhua Huang says: The default dimension tolerance associated with that feature type will be specified by the rule which  will only be followed when the initial value is very small. Is the rule OK?
[12/17/2008 11:04:51 PM] Troy Johnson says: I don't think so. Why does the initial value have to be really small and what does "really small" mean?
[12/17/2008 11:05:52 PM] yanhua Huang says: I sent email to you. The Email title is
Create a topic about "default feature tolerance"  in wiki- PR256827 - Default feature tolerance not working as expected- please give me a response
[12/17/2008 11:07:54 PM] Troy Johnson says: I will look over the e-mail and respond today.

<<END>>
<< Yanhua Huang  --  12/16/08  21:19:12>>
Create a topic about "default feature tolerance"  in wiki  
https://wiki.wilcoxassoc.com/twiki/bin/view/Forum/WhatIHaveLearned0001
<<END>>
<< Changes made by Yanhua Huang -- 12/16/08  21:19:24>>
Action:  Don Turcotte to Yanhua Huang
<<END>>
<< Changes made by Yanhua Huang -- 12/16/08  21:19:13>>
Status:  REVIEW to OPEN
<<END>>
<< Yanhua Huang  --  12/15/08  15:18:33>>
Send Email to Jared.
Jared, please update the description of "Default Feature Tolerance " in PCDIMS help doc V44B.
Default Feature Tolerance
The Default Feature Tolerance area, enabled when you select the "Feature Type" option from the "Apply Defaults Based On" area, lets you define default dimension tolerances based on individual feature types.
The default dimension tolerance associated with that feature type will be used in one of two ways.
1. Create legacy dimensions automatically when the tolerance of the previous dimension (Note that the found previous dimension type is same as the creating dimension type) is zero.
2. Create a location dimension automatically or manually when fabs (the tolerance of the previous location dimension) < epsilon (1e-8).
<<END>>
<< Changes made by Yanhua Huang -- 12/15/08  15:19:20>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  12/12/08  23:36:35>>
Note:
"Default feature tolerance" just takes effect when fabs (minus tolerance or plus tolerance) < 1e-8, mainly eliminate zero.
******************************
Fri Dec 12 22:55:42 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\LOCATION.CPP
<<END>>
<< Yanhua Huang  --  12/12/08  22:59:48>>
Default Feature Tolerance
The Default Feature Tolerance area, enabled when you select the Feature Type option from the Apply Defaults Based On area, lets you define default dimension tolerances based on individual feature types. Whenever PC-DMIS creates a dimension automatically, either because the Auto option is selected in the Location dialog box or because you used the Auto Dimension Setup... button, the default dimension tolerance associated with that feature type will be used.
.......from PCDMIS help Doc V43.
>There is an error in the description. "When the Auto option is selected in the Location dialog box", the "Auto" means automatically create axis information, not create a dimension automatically.
<<END>>
<< Yanhua Huang  --  12/12/08  22:50:51>>
These tolerance values seems be working as the initial design of Portable group.
Christian said.
I set the circle to 1, and the 2D Profile to 0.5.
And again, measured 2 new features with location dimensions.
These were the results.
Circle 2
X 1.000 ------>use prev tolerance of the first 2D profile (X axis)
Y 1.000 ------>use prev tolerance of the first 2D profile (Y axis)
D 0.500 ------>use prev tolerance of the first Cirlce (D axis)
2DProfile 2
X 1.000 ------>use prev tolerance of the secondary Circle  (X axis)
Y 1.000 ----->use prev tolerance of the secondary Circle  (Y axis)
Z 1.000 ----->use prev tolerance of the first 2D profile  (Z axis)
<<END>>
<< Yanhua Huang  --  12/12/08  22:40:44>>
Abandon the last solution. This is not an issue.  
"Default feature tolerance" just takes effect when fabs (minus tolerance or plus tolerance) < 1e-8, mainly eliminate zero.
<<END>>
<< Yanhua Huang  --  12/12/08  22:34:19>>
Completed investigation using ARM machine & online mode.
Shan (a member of Portable group) gave me a show about how "Readout" did work.
"Readout" gives a real-time display a real feature location (DX, DY, DZ, T, Color (outTol) etc.) when ARM probe is close to a measured feature. So they need a default feature tolerance (or named deviation range [plus tolerance, minus tolerance]) as the reference.
Color (OutTol) = (T - default feature tolerance > 0) ? TRUE : FALSE
"T": real-time deviation = norm2 length (DX, DY, DZ)
<<END>>
<< Yanhua Huang  --  12/11/08  22:06:06>>
Waiting troy's response. I will investigate "readout" using arm machine & online tommorrow.
<<END>>
<< Yanhua Huang  --  12/11/08  11:49:31>>
Chat log_1 with troy as below.
[12/10/2008 11:45:28 PM] yanhua Huang says: could you look  PR256827?
This issue seems be taken by PR250963 (Portable group added "default feature tolerance" function).
Could you Email me the design intent for "Default feature tolerance"?
[12/10/2008 11:49:15 PM] Troy Johnson says: The design intent was to allow the user to apply default tolerance either by feature type or by significant digits after the decimal separator. The feature type default tolerance is new. The default tolerance by significant digit is the legacy way that PC-DMIS use to do it.
[12/10/2008 11:49:32 PM] Troy Johnson says: I will not be able to look into it today. I will be in meetings all day today.
[12/10/2008 11:53:31 PM] yanhua Huang says: got it, woody said so. It is not an emergency. just waiting for your response. good day, bye
<<END>>
<< Yanhua Huang  --  12/10/08  22:51:42>>
Default Feature Tolerance
The Default Feature Tolerance area, enabled when you select the Feature Type option from the Apply Defaults Based On area, lets you define default dimension tolerances based on individual feature types. Whenever PC-DMIS creates a dimension automatically, either because the Auto option is selected in the Location dialog box or because you used the Auto Dimension Setup... button, the default dimension tolerance associated with that feature type will be used.
.......from PCDMIS help Doc V43.
<<END>>
<< Yanhua Huang  --  12/10/08  22:46:09>>
There is a conflict which was taken by PR250963 (Portable group added "default feature tolerance" function).
PR250963 took new issues for default tolerance of dimensions, one issue is when "default feature tolerance" is checked,  when create the secondary location dimension, sometime its default tolerance uses "default feature tolerance", sometime uses the previous location tolerance. Another issue is the "default feature tolerance" is not being set in the grid of location dialog.
Shan told me "default feature tolerance" was used for readout.
Portable group added the new rule - "default feature tolerance", but the new rule did affect the previous rule - using the previous tolerance of the same dimension type, when the Auto option is selected in the Location dialog box.
[10:11:47 PM] yanhua Huang says: check or not check "auto" option, always walk into void CPCDlocation::SetDefaultTolerance(CPCDcommand* pOwner)
[10:13:39 PM] Donald Turcotte says: We should discuss this with Troy and Dave to make sure this is the design intent (that the help is correct).  If it is, we will need to add checks to use either the prev tolerance or the default tolerance.  Or decide what the correct behavior should be since there is obviously a conflict here in what is being done.
<<END>>
<< Joe Zink  --  12/09/08  10:20:13>>
Yanhua,
I do not recommend that you replace Default Feature Tolerance.
This problem appears to be only with the Apply All button. In that case, it does not apply the tolerance to all dimensions. For example, if I set tolerance to 0.035 and the type is Circle, and click Apply All, when I dimension a circle for location, I get circle dimensions with the correct tolerances. However, if I then dimension a cone for location, the X, Y and Z locations have the correct tolerance of 0.035, but A and L do not. Note that A and L have no meaning for circles.
I hope this helps.
Joe
<<END>>
<< Yanhua Huang  --  12/09/08  22:15:40>>
Is it better to replace "default feature tolerance" by "plus tolerance" and "minus tolerance"?
<<END>>
<< Yanhua Huang  --  12/09/08  21:49:50>>
This reason is that set prev tolerance or default tolerance when call CPCDlocation::SetDefaultTolerance. Is the rule (below) acceptable?
******************************
Tue Dec 09 21:39:12 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\LOCATION.CPP
<<END>>
<< Yanhua Huang  --  12/09/08  21:34:23>>
\\V44B\DIMENS\LOCATION.CPP
void CPCDlocation::SetDefaultTolerance(CPCDcommand* pOwner)
{
.................
                if (!GETOPTION(DEFTOLS)) // PR256827 - yanhua
{
  dDefaultTol = GetDefaultFeatureTypeTolerance(pOwner);
  /*-----------------------------------------------------------------------------------------------------------------
  1. Default feature tolerance (checked) = true
      eliminate fabs (default feature tolerance) <= 0.00000001, such as 0
  1.1 if fabs (default feature tolerance) <= 0.00000001, use the previous dimension tolerance.
  1.2 if fabs (default feature tolerance) >   0.00000001, use the default feature tolerance.
  ------------------------------------------------------------------------------------------------------------------*/
  if (fabs(dDefaultTol) > DIFF_TOL)   
  {
   dPreviousPlusTol = dDefaultTol;
   dPreviousMinusTol = dDefaultTol;
  }
}
...............
}
<<END>>
<< Changes made by Tim Wernicke -- 09/02/08  11:31:42>>
Action:  Don Turcotte to Yanhua Huang, Assigned:  Don Turcotte to Yanhua Huang, Priority:  to Critical
<<END>>