PR 255683 syn display for analysis in the advanced page and edit window for a

huangyhg · 发表于 2009-3-26 14:42:06

syn display for analysis in the advanced page and edit window for all FCF
<< Yanhua Huang  --  06/30/08  21:53:52>>
1) If FCF is true postion | profile with datum, we should use "NONE, POSITION, FORM, BOTH".
2) If FCF is profile without datum, we should use only "NONE, FORM".
3)  For other dimensions, use "OFF, ON"
<<END>>

<< Yanhua Huang  --  03/21/09  21:16:13>>
Correct, thanks, Jared.
<<END>>
<< Changes made by Yanhua Huang -- 03/21/09  21:16:27>>
Status:  MOREINFO to CLOSED
<<END>>
<< Changes made by Jared Hess -- 03/20/09  16:33:47>>
Action:  Jared Hess to Yanhua Huang, Status:  CLOSED to MOREINFO
<<END>>
<< Jared Hess (Documentation Notes)  --  03/20/09  16:32:57>>
Anyway, for now, based on the PR and the email you sent me, I've modified the "Feature Control Frame Command Block" documentation topic to read as follows:
CADGRAPH = OFF/ON/POSITION/FORM/BOTH - Display the graphical analysis on the model
in the Graphics Display window.
True Position and Profile dimensions with datums use OFF/POSITION/FORM/BOTH.
Profile dimensions without datums only use OFF/FORM.
All other dimensions use OFF/ON

REPORTGRAPH = OFF/ON/POSITION/FORM/BOTH - Display the graphical analysis on report.
True Position and Profile dimensions with datums use OFF/POSITION/FORM/BOTH.
Profile dimensions without datums only use OFF/FORM.
All other dimensions use OFF/ON

TEXT = OFF/ON/POSITION/FORM/BOTH - Display the textual analysis on report.
True Position and Profile dimensions with datums use OFF/POSITION/FORM/BOTH.
Profile dimensions without datums only use OFF/FORM.
All other dimensions use OFF/ON
Does this look correct? Is anything else needed?
<<END>>
<< Yanhua Huang  --  03/20/09  17:48:42>>
Jared, please document this.
<<END>>
<< Changes made by Yanhua Huang -- 03/20/09  17:49:13>>
Action:  Yanhua Huang to Jared Hess
<<END>>
<< Yanhua Huang  --  02/26/09  14:29:11>>
Tested, working as below.
3. profile use new analysis options in edit winldow which is same as the FCF advanced page.
3.1 For true position | profile with datum, use "OFF, POSITION, FORM, BOTH"
3.2 For profile without datum, use only "OFF, FORM"
3.3 For other dimensions, use "OFF, ON"
<<END>>
<< Changes made by Yanhua Huang -- 02/26/09  14:29:40>>
Status:  RESOLVED to CLOSED
<<END>>
<< Changes made by Neil Kay -- 02/25/09  19:22:01>>
Action:  David Petrizze to Yanhua Huang, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  02/02/09  17:12:19>>
Reviewed.
OK
<<END>>
<< Changes made by Don Turcotte -- 02/02/09  17:12:19>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  01/16/09  16:53:10>>
Fixed #4 reported by Don T.
4. I found one new problem.  If you create a profile formandlocation and set CADGRAPH=BOTH, REPORTGRAPH=BOTH, TEXT=POSITION, then F9 on the FCF and remove the datum (to change to formonly).  Then OK.  The settings for CADGRAPH, REPORTGRAPH, TEXT don't always all go to FORM (as they should).  Even when they do, if I then F9 again on the FCF and go to the advanced tab, the settings on the advanced tab don't agree with the edit window.
Some changed code as below.
  if (m_ReportGraphicalCombo.GetCount() > fcf->m_reportgraphanal && fcf->m_reportgraphanal >= 0)
m_ReportGraphicalCombo.SetCurSel(fcf->m_reportgraphanal);
  else if (m_ReportGraphicalCombo.GetCount()  <= fcf->m_reportgraphanal && m_ReportGraphicalCombo.GetCount() > 0)
m_ReportGraphicalCombo.SetCurSel(m_ReportGraphicalCombo.GetCount() - 1);
  else
m_ReportGraphicalCombo.SetCurSel(0);
******************************
Fri Jan 16 16:46:35 2009
******************************
Files inserted to server
------------------------
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Yanhua Huang -- 01/16/09  16:53:40>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Don Turcotte -- 01/06/09  13:29:48>>
Action:  Don Turcotte to Yanhua Huang, Status:  REVIEW to OPEN
<<END>>
<< Don Turcotte  --  12/12/08  15:45:27>>
The issues #1, #3 have been fixed.  #2 is ok as is.
I found one new problem.  If you create a profile formandlocation and set CADGRAPH=BOTH, REPORTGRAPH=BOTH, TEXT=POSITION, then F9 on the FCF and remove the datum (to change to formonly).  Then OK.  The settings for CADGRAPH, REPORTGRAPH, TEXT don't always all go to FORM (as they should).  Even when they do, if I then F9 again on the FCF and go to the advanced tab, the settings on the advanced tab don't agree with the edit window.
<<END>>
<< Yanhua Huang  --  11/14/08  23:03:13>>
I asked Dave about #2 issue, Dave told me as below.
[11/11/2008 11:14:34 PM] yanhua Huang says: I sent you an email.
Email title is - question about PR 255683- is it an issue that all variable ist are in alphabetical order in summary mode of edit window?
[11/11/2008 11:16:01 PM] Dave Petrizze says: It could be SORT by default
[11/11/2008 11:16:13 PM] Dave Petrizze says: I would say this is not an issue, don't worry about it
<<END>>
<< Changes made by Yanhua Huang -- 11/14/08  23:03:48>>
Action:  Yanhua Huang to Don Turcotte, Status:  MOREINFO to REVIEW
<<END>>
<< Yanhua Huang  --  11/11/08  15:45:22>>
The reason for #1 and #3 is that the changed code for item 3 of PR255412.
<<END>>
<< Yanhua Huang  --  11/11/08  15:24:09>>
#1 and #3 are fixed.
******************************
Tue Nov 11 15:21:20 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< System Administrator  --  2008/10/23  17:35:30>>
PLEASE VERIFY THAT THIS IS AN ISSUE IN PC-DMIS 4.4 AUDIT VERSION.  IF SO, PLEASE RESET THE STATUS TO OPEN.  OTHERWISE PLEASE CLOSE.
<<END>>
<< Changes made by System Administrator  --  2008/10/23  17:35:30>>
Status:  OPEN to MOREINFO
<<END>>
<< Don Turcotte  --  10/09/08  09:20:56>>
Reviewed.
There are several issues here:
1.  Create a new FCF profile.  On the FCF editor dialog, select a feature but no datum (this is form only).  Go to the advanced tab and the choices for "Report Textual Analysis", "Report Graphical Analysis", and "CAD Graphical Analysis" are "OFF, FORM" .  This is correct.  Now go back to the FCF editor dialog and select a datum (formandlocation).  Go to the advanced tab and the choices are still "OFF,FORM".  They should now be "OFF, POSITION, FORM, BOTH"
2.  Create an FCF profile with a datum (formandlocation).  The options in the edit window for "Report Textual Analysis", "Report Graphical Analysis", and "CAD Graphical Analysis" are "BOTH, FORM, OFF, POSITION".  This is the correct list but it is now in alphabetical order.  This occurs in both the command mode and summary mode edit windows, but is more obvious in the summary mode edit window.  This list must not be in alphabetical order.  There is some setting which will tell the editor to display a togglestring in alphabetical order or not.
2.  In the edit window for an FCF profile with a datum (formandlocation), change the setting for "Report Textual Analysis", "Report Graphical Analysis", or"CAD Graphical Analysis" to "

OSITION".  Then F9 on the FCF and go to the advanced tab.  The list of options for these fields is correctly shown as "OFF, POSITION, FORM, BOTH".  Now go back to the FCF editor dialog and remove the datums (form only).  Go to the advanced tab and the options are still "OFF, POSITION, FORM, BOTH".  The options should now be "OFF, FORM"
<<END>>
<< Changes made by Don Turcotte -- 10/09/08  09:21:11>>
Action:  David Petrizze to Yanhua Huang, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Don Turcotte -- 10/09/08  09:20:56>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  07/28/08  17:51:27>>
3. if schema >= 4037, profile use new analysis options in edit winldow which is same as the FCF advanced page.
3.1 For true position | profile with datum, use "OFF, POSITION, FORM, BOTH"
3.2 For profile without datum, use only "OFF, FORM"
3.3 For other dimensions, use "OFF, ON"
******************************
Mon Jul 28 16:18:46 2008
******************************
Files inserted to server
------------------------
V44B\INCLUDE\EDITRSTR.H
V44B\INCLUDE\strings.h
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V44B\RESOURCE\LANGS\ENGLISH\STRINGS.RC
V44B\SOURCE\EDITRSTR.CPP
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Yanhua Huang -- 07/28/08  17:52:05>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  07/28/08  12:55:40>>
1) use OFF,POSITION,FORM,BOTH, add a new string as S_ES_OFF_POSITION_FORM_BOTH_TOGGLE.
2) use OFF,FORM, change S_ES_NONE_FORM_TOGGLE to S_ES_OFF_FORM_TOGGLE.
3) S_ES_OFF_ON_TOGGLE have existed in V43B.
Yanhua
<<END>>
<< Don Turcotte  --  07/11/08  11:17:43>>
Reviewed.
The toggle string OFF, ON,FORM,BOTH should be OFF,POSITION,FORM,BOTH.  For formonly, the choices are NONE,FORM.  To be consistent this should be OFF,FORM.  Maybe we need a separate toggle string (or does one already exist?) for OFF, ON.
<<END>>
<< Changes made by Don Turcotte -- 07/11/08  11:17:55>>
Action:  David Petrizze to Yanhua Huang, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Don Turcotte -- 07/11/08  11:17:43>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  07/11/08  19:17:10>>
miss upload this file.
******************************
Fri Jul 11 19:15:01 2008
******************************
Files inserted to server
------------------------
V44B\RESOURCE\LANGS\ENGLISH\STRINGS.RC
<<END>>
<< Yanhua Huang  --  07/02/08  10:31:07>>
Did test it. Test should mainly focus profile with datum or without datum and check verification result.
1. If schema < 4037, keep the same display as the former version V44B in the advanced page of FCF, but synchronize analysis options in edit window  as the advanced page of FCF.
1.1 For true position, use "NONE, POSITION, FORM, BOTH"
1.2 For other dimension, use "OFF, ON"
2. if schema >= 4037, profile use new analysis options.
2.1 For true position | profile with datum, use "NONE, POSITION, FORM, BOTH"
2.2 For profile without datum, use only "NONE, FORM"
2.3 For other dimensions, use "OFF, ON"
Yanhua,
   OFF    =  NONE
   ON       =  POSITION
   FORM  =  FORM
   BOTH =  BOTH

These should probably be using the same toggle string to avoid this confusion.  The toggle string used by the dialog is more descriptive.

Regards,
Don

--------------------------------------------------------------------------------
From: Yanhua HUANG
Sent: Monday, June 30, 2008 8:43 AM
To: Yanhua HUANG; Don Turcotte
Cc: Don Ruggieri
Subject: What are report textual analysis correct items?

Don,
I created true position in V44B today. But found items difference in ¡°report textual analysis¡± between FCF dialog (Figure.1) and edit window (Figure.2). What are report textual analysis correct items?
yanhua
<<END>>
<< Changes made by Yanhua Huang -- 07/02/08  10:29:07>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  07/02/08  01:07:08>>
******************************
Wed Jul 02 00:59:05 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\EDITRSTR.H
V44B\INCLUDE\FEATCTRLFRM.H
V44B\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V44B\INCLUDE\PCDSCHEMA.H
V44B\INCLUDE\strings.h
V44B\MENU\DIMENSIO.CPP
V44B\MENU\FEATCTRLFRMDLG.CPP
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V44B\SOURCE\EDITRSTR.CPP
<<END>>

		自动登录	找回密码
密码			注册