PR 256733 Iterate and repierce is not controllable from dimensions

huangyhg

Iterate and repierce is not controllable from dimensions
<< Andy Roberts  --  08/26/08  11:54:13>>
When a profile dimension is created we internally use and alignment to try to match the theo and meas hits.  The alignment will iterate and repierce if the machine is portable and the mode is surface mode.  This is the default value.
The user can't control it otherwise.  It seems like this should be either always off, or controllable by the user.  There is also a tolerance and a maximum number of iterations that are used if it is on.
<<END>>


<< Changes made by Yanhua Huang -- 03/24/09  20:59:56>>
Action:  David Petrizze to Andy Roberts, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  12/03/08  15:51:55>>
Reviewed.
OK
<<END>>
<< Changes made by Don Turcotte -- 12/03/08  15:51:55>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  12/04/08  00:33:38>>
Simple fixed in V44B.
For profile, set the SetIsIterateAndRepierceCAD FALSE for both 3D and 2D best fits in the current version of V44B.  
We will allow the user to control this only in a future enhancement to a later version.
******************************
Thu Dec 04 00:28:44 2008
******************************
Files inserted to server
------------------------
V44B\ALIGNMNT\BF3D_ALI.CPP
V44B\DIMENS\DIM_PROF.CPP
V44B\INCLUDE\BF3D_ALI.H
<<END>>
<< Changes made by Yanhua Huang -- 12/04/08  00:35:00>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  12/04/08  00:25:54>>
Investigating the reason for this PR.
[10:43:09 PM] yanhua Huang says: For surface profile,how did effect BF alignment when m_bEnableIterateAndRePierceCAD is FALSE or TRUE?
[10:45:42 PM] Donald Turcotte says: when m_bEnableIterateAndRePierceCAD is TRUE, new nominal points are found by re-piercing the CAD using the meas points.  Then the nominal points correspond to the actual meas points.  This gives a better fit in some situations.
[10:59:06 PM] Donald Turcotte says: The nominal points and the intial meas points are derived by piercing the CAD surface.  However, when the program is executed, the meas points may actually be taken in a slightly different section of the part because the initial alignment is not exact.  The concept of re-piercing the CAD is to take into account that the actual meas points don't necessarily correspond to the original nominal points because of the initial misalignment of the part.
<<END>>
<< Yanhua Huang  --  12/04/08  00:22:33>>
Yanhua,
We decided in yesterday's scrum meeting that the simplest fix is to set this flag FALSE in Dim_prof.cpp method create_internal_alignment(...) when either a CPCDbf3d_align or CPCDbf2d_align alignment object is created.  Adding controls to the FCF profile dialog to allow the user to control this flag will be done in a future enhancement for V44+ (not the current V44B).
Regards,
Don
<<END>>
<< Yanhua Huang  --  08/27/08  21:40:15>>
add a new radio option to FCF dialog?
[9:29:13 PM] Donald Turcotte says: The simplest fix is to set this flag FALSE in Dim_prof.cpp method create_internal_alignment(...) when either a CPCDbf3d_align or CPCDbf2d_align alignment object is created.  This is the only possible fix for V43B and V431 since the resources for these versions cannot be changed.  For V44B we should discuss in the next meeting whether or not we want to allow the user to control this.  For now, you should just implement the same fix in V44B as for V43B.
[9:38:47 PM] yanhua Huang says: is it just effect formonly profile? or also effect formandlocation profile?
[9:39:06 PM] Donald Turcotte says: just formonly
<<END>>
<< Yanhua Huang  --  08/27/08  17:04:48>>
bestfit alignment m_bEnableIterateAndRePierceCAD can be set for profile form only calculations without user knowing about this.

The default in the CPCDbf3d_align constructor is based on:
  m_bEnableIterateAndRePierceCAD = (IsPortableMachine() && global_surface_select_mode) ? TRUE : FALSE;  
This means that for a line or surface formonly profile the repierce cad flag may or may not be on depending on the configuration of the user's system.
Since CPCDbf2d_align derives from CPCDbf3d_align , this is a problem for both line and surface formonly profile.  The m_bEnableIterateAndRePierceCAD  flag is new to the best fit alignments but the profile command does not know about this flag.  On the best fit alignment dialog, the user can turn this on/off and set the tolerance.
Andy noted this and we discussed this with Dan.  We agreed that the line profile should always set this to FALSE when creating a formonly alignment.  It may make sense to allow this flag to be TRUE for some surfaces on a formonly surface profile, but we would have to add controls to the dimension dialog to allow the user to select this since this is not always a good idea for all surfaces and can add considerable processing time if it is on.
The simplest fix is for both the line and surface profile to set this flag FALSE when creating either a 2d or 3d alignment for formonly profile.
----------------------------------------------------From PR 256740
<<END>>
<< Don Turcotte  --  08/26/08  17:14:16>>
Also see PR # 256740 for more details.  I have closed 256740 since it is a duplicate of this PR.
<<END>>
<< Changes made by Tim Wernicke -- 08/26/08  14:35:34>>
Action:  Tim Wernicke to Yanhua Huang, Assigned:  Tim Wernicke to Yanhua Huang, Priority:  to Critical
<<END>>