PR 240549 Computation of SYMMETRY not works with construction lines.

huangyhg

Computation of SYMMETRY not works with construction lines.
<< Domenico Varacalli  --  05/11/06  15:35:55>>
I have try to use the Symmetry (both style: Legacy and FCM), but the results is always 0.000.
In the program (GDT_Sym_01.PRG reproduces the classical example of symmetry [symmetry.gif]), I have made some combinations of elements, but I have not succeeded in getting a correct result.
I have also tried to used the construction lines (Lin1 and Lin2) but nothing is changed. The symmetry works only if the Lines are measured (Lin5 and Lin6), but not constructed.
This limits a lot the use of the symmetry. I have made the last two measurements (DIM12 and DIM15) to show that the middle position of the couple of planes has indeed an error.
<<END>>


<< Changes made by Neil Kay -- 02/24/09  18:47:22>>
Status:  RESOLVED to CLOSED
<<END>>
<< Changes made by Neil Kay -- 07/23/08  09:55:20>>
Action:  David Petrizze to Domenico Varacalli, Status:  REVIEW to RESOLVED
<<END>>
<< Paola Pallo  --  10/11/06  11:24:44>>
Reviewed. Ok
<<END>>
<< Changes made by Paola Pallo -- 10/11/06  11:25:03>>
Action:  Paola Pallo to David Petrizze
<<END>>
<< Don Turcotte  --  09/13/06  16:50:04>>
Reviewed.
Paola, Your changes to FEATCTRLFRM.CPP are ok.  I found other problems in DIM_SYMM.CPP related to symmetry with constructed lines that I have fixed and uploaded.  Please review my changes.
1. calls to get_points(...) were using THEO instead of MEAS
2. measpnts1, measpnts2 were not being deleted.
3. GetEndPoints(...) was not correctly finding the end points of a line.
4. I also modified GetEndPoints(...) to use the end points of the midline if there are no measure points.  This is a change to the specification but I think in the case of lines this makes more sense than simply using the centroid.
Files inserted to server
------------------------
V42\DIMENS\DIM_SYMM.CPP
V43B\DIMENS\DIM_SYMM.CPP
<<END>>
<< Changes made by Don Turcotte -- 09/13/06  16:50:23>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Changes made by Don Turcotte -- 09/13/06  16:50:04>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Paola Pallo  --  08/31/06  12:27:32>>
Fixed.
The issue was in update_internal_command() : I reworked it for symmetry in order to accept all the cases now  supported. They are either two features ( lines, points, planes measured or constructed)  or  1 feature ( midline, midplane, midpoint, and a circular feature) .
For review:
V42\DIMENS\FEATCTRLFRM.CPP
V43B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Paola Pallo -- 08/31/06  12:28:27>>
Action:  Paola Pallo to Don Turcotte, Assigned:  Don Turcotte to Paola Pallo, Status:  OPEN to REVIEW
<<END>>
<< Paola Pallo  --  08/30/06  17:56:18>>
Working to fix an issue when two constructed features are selected.
<<END>>
<< Changes made by Paola Pallo -- 08/30/06  17:56:43>>
Action:  Domenico Varacalli to Paola Pallo, Status:  RESOLVED to OPEN
<<END>>
<< Domenico Varacalli  --  08/30/06  08:34:27>>
I have tried to verify this report with the version 4.2 (20 Aug 06), but another problem still exists. (report: 242749). I remain waiting for the correction of this problem.
<<END>>
<< Paola Pallo  --  08/01/06  16:22:25>>
This should be resolved per task 102155. Since review is already done in the task, I set the action back for testing. Mimmo, please  verify it with latest build, and re-open if you see something still not working. Thanks
<<END>>
<< Changes made by Paola Pallo -- 08/01/06  16:22:55>>
Action:  Paola Pallo to Domenico Varacalli, Status:  OPEN to RESOLVED
<<END>>
<< Paola Pallo  --  07/14/06  10:54:53>>
Per  task 102155 the symmetry will be improved in v4.2.
I'm taking a look to  verify if the proposed design for the enhancement could fit also this request.
<<END>>
<< Changes made by Paola Pallo -- 07/14/06  10:55:05>>
Action:  Don Turcotte to Paola Pallo
<<END>>
<< Changes made by Tim Wernicke -- 05/11/06  08:44:19>>
Priority:  to High
<<END>>