PR 254654 Flatness per unit area does not use Y14.5 flatness

huangyhg · 发表于 2009-5-4 19:45:17

Flatness per unit area does not use Y14.5 flatness
<< Don Turcotte  --  04/25/08  10:32:38>>
Flatness per unit area does not use Y14.5 flatness.  The overall flatness in an FCF now uses Y14.5 flatness (Chebychev).  The flatness per unit area calculates the deviation from the least squares plane when evaluating the flatness of each unit area.
<<END>>

<< Jared Hess (Development Notes)  --  04/08/09  23:10:24>>
This has been addedtoreadme for v44 (or ignored if internal item).
<<END>>
<< Changes made by Don Turcotte -- 05/27/08  09:40:54>>
Status:  RESOLVED to CLOSED
<<END>>
<< David Petrizze  --  05/07/08  11:01:23>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 05/07/08  11:01:27>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  05/02/08  14:53:07>>
I have merged my changes into V43R except for the files :
  AFPLANE.H
  AFPLANELASER.H
  AFPLANECONTACT.H
  AFPLANE.CPP
  AFPLANELASER.CPP
  AFPLANECONTACT.CPP
These files do not have Dan Zwick's changes for the "flatness" method (although the V43B, V44B versions do) so I did not include my changes for "flatness_per_unit".  This is consistent with how V43R handles Y14.5 flatness with measured features which inherit from CPCDplane_feature.  Since autofeature planes also inherit from CPCDplane_feature, they will behave the same as measured features in V43R.  I have verified this with test programs that I have attached for both measured and autofeature planes.  The results for V43R flatness per unit area are consistent.
I sent the following e-mail to Dan expressing my concerns:
"Dan,
In V43B and V44B, AFPLANE.CPP (CPCDAFPlane), AFPLANECONTACT.CPP (CPCDAFPlaneContact) and AFPLANELASER.CPP (CPCDAFPlaneLaser) implement a flatness(¡) method.  The flatness(¡)  in AFPLANE.CPP and AFPLANECONTACT.CPP call flatnessDSFitCompensate(¡) to implement Y14.5 flatness, and AFPLANELASER.CPP calls flatnessPrecompensate(¡).  None of these flatness(¡) implementations are included in V43R.  I¡¯m not sure why they are in V43B and V44B since both CPCDAFPlaneContact and CPCDAFPlaneLaser inherit from CPCDAFPlane which in turn inherits from CPCDplane_feature which implements a flatness(¡) method that calls flatnessPrecompensate(¡) to implement Y14.5 flatness.
"
His reply was:
"Hi Don,
  In 4.3B and 4.4B, any plane that uses flatnessDSFitPrecompensate (in particular, if there are no tips and no vectors) doesn¡¯t need to implement a flatness method since it inherits the one in basic_pl.cpp. Those that require probe compensation should have a method similar to the one in bfre_pl, which calls flatnessDSFitCompensate. However, flatnessDSFitCompensate is equivalent to flatnessDSFitPrecompensate
when there are no vectors and no tips, so ADPlaneLaser, for instance, could also call flatnessDSFitCompensate.
  I don¡¯t see any problem having AFPlane default to flatnessDSFitCompensate. In fact, I think it would be better if the one in basic_pl.cpp used flatnessDSFitCompensate. For example, measured planes are now using Precompensate where they should be using Compensate. I should change that. But I assume that 4.3B and 4.3R are functionally equivalent, and I¡¯d rather not mess with them right now. Maybe later I¡¯ll try to clean up 4.4B.
Bye,
  Dan
"
Files inserted to server
------------------------
V43R\CONSFEAT\BASIC_PL.CPP
V43R\DIMENS\DIM_FLAT.CPP
V43R\INCLUDE\BASIC_PL.H
V43R\INCLUDE\COMMAND.H
V43R\INCLUDE\DIM_FLAT.H
V43R\INCLUDE\SEARCHID.H
V43R\SOURCE\COMMAND.CPP
V43R\SOURCE\SEARCHID.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/02/08  14:53:24>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  05/02/08  08:04:46>>
Please go ahead in V43R Don.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 05/02/08  08:05:16>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to OPEN, Priority:  High to Stop Rel.
<<END>>
<< Don Turcotte  --  05/02/08  08:28:09>>
I have uploaded these changes to V43B and V44B.  In the report for composite flatness, overall flatness and per unit flatness now both report the Y14.5 flatness (Chebychev).
Files inserted to server
------------------------
V43B\AUTOFEAT\AFPLANE.CPP
V43B\AUTOFEAT\AFPLANECONTACT.CPP
V43B\AUTOFEAT\AFPLANELASER.CPP
V43B\CONSFEAT\BASIC_PL.CPP
V43B\DIMENS\DIM_FLAT.CPP
V43B\INCLUDE\AFPLANE.H
V43B\INCLUDE\AFPLANECONTACT.H
V43B\INCLUDE\AFPLANELASER.H
V43B\INCLUDE\BASIC_PL.H
V43B\INCLUDE\COMMAND.H
V43B\INCLUDE\DIM_FLAT.H
V43B\INCLUDE\SEARCHID.H
V43B\SOURCE\COMMAND.CPP
V43B\SOURCE\SEARCHID.CPP
V44B\AUTOFEAT\AFPLANE.CPP
V44B\AUTOFEAT\AFPLANECONTACT.CPP
V44B\AUTOFEAT\AFPLANELASER.CPP
V44B\CONSFEAT\BASIC_PL.CPP
V44B\DIMENS\DIM_FLAT.CPP
V44B\INCLUDE\AFPLANE.H
V44B\INCLUDE\AFPLANECONTACT.H
V44B\INCLUDE\AFPLANELASER.H
V44B\INCLUDE\BASIC_PL.H
V44B\INCLUDE\COMMAND.H
V44B\INCLUDE\DIM_FLAT.H
V44B\INCLUDE\SEARCHID.H
V44B\SOURCE\COMMAND.CPP
V44B\SOURCE\SEARCHID.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/02/08  08:29:28>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Dan Zwick  --  05/01/08  16:55:25>>
What about straightness per unit length? I uploaded code to PCDSFit a while back that implements this.
<<END>>
<< Don Turcotte  --  05/01/08  17:17:48>>
I have completed implementation of this.  I have attached my test program.  I will complete testing and upload tomorrow.
<<END>>
<< Changes made by Tim Wernicke -- 04/25/08  09:41:01>>
Priority:  to High
<<END>>

		自动登录	找回密码
密码			注册