PR 234548 Location Dimensions not reporting correctly, headers are gone, and

huangyhg

Location Dimensions not reporting correctly, headers are gone, and dimensions don't make any sense
<< Sam Pelletier  --  08/08/05  16:50:42>>
The customers first two dimensions in the program are locations of circles (LOC1 and LOC2).  The dimensions appear fine in the command window, but if you look at the full report mode, the only thing that shows up is a bunch of 0's.  Sometimes, if you try to edit the dimensions, huge numbers replace the 0's.  I cannot create a good location dimension in this program, but I can create TP's, roundness', etc, and they all seem to be working fine.  The TP's that the customer put in here also don't seem to have a problem.  I am also having the customer send in the .prb file and user folder, but I don't think they matter, because I can just open his program and I see exactly what he is seeing.  For now, just the program is attatched.
<<END>>


<< Changes made by Neil Kay -- 02/25/09  11:37:46>>
Status:  RESOLVED to CLOSED
<<END>>
<< Changes made by Neil Kay -- 07/22/08  19:19:56>>
Action:  David Petrizze to Sam Pelletier, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  07/17/06  14:16:08>>
Reviewed.
OK
<<END>>
<< Changes made by Don Turcotte -- 07/17/06  14:16:19>>
Action:  Bret Naylor to David Petrizze
<<END>>
<< Changes made by Don Turcotte -- 07/17/06  14:16:08>>
Action:  Don Turcotte to Bret Naylor
<<END>>
<< Paola Pallo  --  07/06/06  11:31:19>>
I reworked create_text() to solve the issue 1, adding the parameter as constant instead of toggle.
For review :
V42\SOURCE\COL132.CPP
The issue 2 is by design : in fact  to allow the serialization, 123COLUMN keyword should be listed in the configuration items, and this is causing the "autocomplete" when you type it in EW .
Since immediately later  you get the warning message "123command is not supported" and the text is removed , I think it could be acceptable.
<<END>>
<< Changes made by Paola Pallo -- 07/06/06  11:31:56>>
Action:  Paola Pallo to Don Turcotte
<<END>>
<< Don Turcotte  --  07/05/06  10:10:59>>
In V42, I still see two problems here.  
1. When a legacy program is loaded that has a 132COLUMN command, the ON/OFF of the command can be toggled in the edit window with F7 or F8. (see the attached program)
2. When typing a command in the edit window (command mode), the 132COLUMN command still appears in the editor's list of available commands even though you cannot successfully create this command.  Simply start typing 1 to see this.
<<END>>
<< Changes made by Don Turcotte -- 07/05/06  10:11:28>>
Action:  Don Turcotte to Paola Pallo
<<END>>
<< Paola Pallo  --  06/30/06  12:15:34>>
123COLUMN command is removed from v42 U.I.
See task 102609 for details and review.
<<END>>
<< Changes made by Paola Pallo -- 06/30/06  12:16:16>>
Action:  Bret Naylor to Don Turcotte, Status:  PENDING to REVIEW
<<END>>
<< Paola Pallo  --  06/01/06  17:54:26>>
Using the attachec program working on task 102609.
Found a serialization problem in MEAS_PLANE command ( it should be individually addressed)
<<END>>
<< Bret Naylor  --  08/17/05  10:40:34>>
In version 4.1, let's remove this from the U.I. and cut off all other avenues of creation of this command except for serialization from legacy part programs.
<<END>>
<< Changes made by Bret Naylor -- 08/17/05  10:40:53>>
Status:  REVIEW to PENDING
<<END>>
<< Wade Burton  --  08/13/05  23:46:08>>
Reviewed.  Seems ok.
<<END>>
<< Changes made by Wade Burton -- 08/13/05  23:46:19>>
Action:  Wade Burton to Bret Naylor
<<END>>
<< Don Turcotte  --  08/10/05  07:54:45>>
I have fixed the problem with the wrong typeindex being used (see below).  So that's all I will do for this problem given the comments by Sam and Wade.
<<END>>
<< Changes made by Don Turcotte -- 08/10/05  07:54:50>>
Action:  Don Turcotte to Wade Burton, Status:  OPEN to REVIEW
<<END>>
<< Sam Pelletier  --  08/09/05  16:44:23>>
I didn't realize that this was on in the customers program, nor did I  know what 132 column did.  It's quite possible that this is working correctly.  Neither the customer nor I realized he had turned this on, and he was quite happy with the report once we turned it off.
<<END>>
<< Wade Burton  --  08/09/05  13:34:47>>
Don, I don't believe that column132 had headers.  It was printed out in a specific format, which I can see in the help file.  They did only work with location dimensions.  I have had absolutely zero requests for changes with the column132 format for at least 5-6 years, so I don't really recommend changing a lot to this, other than making them work with the dtypes.
<<END>>
<< Changes made by Wade Burton -- 08/09/05  13:35:04>>
Action:  Wade Burton to Don Turcotte, Status:  MOREINFO to OPEN
<<END>>
<< Don Turcotte  --  08/09/05  11:53:21>>
The problem here is that the user has selected column132 and CPCDend_location::column132_line() is using the wrong typeindex in calls to get_text(...).  I have fixed this.
The other issue is that there are no headers and I haven't been able to figure out how the column132 headers are supposed to work.  Wade, do you understand how the column132 headers are supposed to be generated?  Is there a header for each line of output for a location dimension or is there supposed to be only a single header per page?  It seems that only location dimensions worry about column132 format and not true position or the other dimensions.
Files inserted to server
------------------------
V37\DIMENS\END_LOCA.CPP
V40\DIMENS\END_LOCA.CPP
<<END>>
<< Changes made by Don Turcotte -- 08/09/05  11:54:02>>
Action:  Don Turcotte to Wade Burton, Status:  OPEN to MOREINFO
<<END>>
<< Changes made by Tim Wernicke -- 08/08/05  15:59:11>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>