PR #253025 Min Circumscribed cylinder coming up with incorrect values for cyl

huangyhg

Min Circumscribed cylinder coming up with incorrect values for cylinder constructed from measured points
<< Troy Johnson  --  01/31/08  15:35:47>>
In the attached part program, you will find three constructed cylinders near the end. Cyl1 (LEAST_SQR) has a measured diameter of 1.8184. Cyl2 (MAX_INSC) has a measured diameter of 1.8179 and Cyl3 (MIN_CIRCSC) has a measured diameter of 1.9751. All cylinders have the same inputs. The interesting thing is that all the input points were measured at specific levels, If you take all of the points on each level and fit them with MIN_CIRCSC circles, the results are all between 1.8181 - 1.8186. This is demonstrated with CIR2 - CIR7. The customer has measured the diameter of the cylinder with a micrometer and believes that the result should be closer to 1.81 and that1.9751 is far too big. All cylinder measurements have to be sumbitted as least squares, min circumscribed and max inscribed so all values need to correlate.
<<END>>

huangyhg

<< Jerry Naylor  --  02/11/08  09:41:19>>
wasaddedtoreadme42R
<<END>>

<< Changes made by Tim Wernicke -- 02/04/08  11:55:20>>
Priority:  Critical to Stop Rel.
<<END>>

<< Dan Zwick  --  02/04/08  10:48:25>>
Uploaded to 4.2 and 4.4B. Done.
<<END>>

<< Dan Zwick  --  02/04/08  09:32:28>>
Tested and uploaded to V4.2R.
<<END>>

<< Changes made by Dan Zwick -- 02/04/08  09:35:53>>
Action:  Dan Zwick to Troy Johnson, Status:  OPEN to RESOLVED
<<END>>

<< Dan Zwick  --  02/03/08  10:56:53>>
So far I have uploaded the fix that I had previously made to 4.3B to 4.3R.  
Files uploaded:
V43R\CONSFEAT\BEST_CIR.CPP
V43R\CONSFEAT\BEST_CYL.CPP
V43R\CONSFEAT\BFRE_CYL.CPP
<<END>>

<< Dan Zwick  --  02/01/08  12:13:07>>
This is the same problem as in PR 249845, which I only fixed in 4.3B. I've been given authorization to merge the fix to 4.2R and up.
<<END>>

<< Dan Zwick  --  02/01/08  08:04:02>>
I'll take a look.
<<END>>

huangyhg

// 1. V43R\CONSFEAT\BEST_CIR.CPP
best_fit_fet->feature() == F_CYLINDER)  //cylinder
// 2. V43R\CONSFEAT\BEST_CYL.CPP
      CPCDbest_fit_circle *pBFCircle=new CPCDbest_fit_circle(m_pPartProgram, best_fit_fet, MEAS, 2, (TCHAR) probe_recomp);
//3. V43R\CONSFEAT\BFRE_CYL.CPP
          int input_type = input_ids[h]->type();
          if (input_type != MEASURED_POINT
            && input_type != MEASURED_CIRCLE          // Added - DSZ
            && input_type != CONTACT_CIRCLE_FEATURE   // Added - DSZ
            && input_type != CONST_BFRE_CIRCLE        // Added - DSZ
            && input_type != CONST_BF_CIRCLE          // Added - DSZ
            && input_type != AUTO_VECTOR_FEATURE
            && input_type != CONTACT_VECTOR_POINT_FEATURE  // Replaces AUTO_VECTOR_FEATURE - DSZ
            && input_type != AUTO_SURFACE_FEATURE
            && input_type != CONTACT_SURFACE_POINT_FEATURE // Replaces AUTO_SURFACE_FEATURE - DSZ
            && input_type != DCCSCAN_OBJECT
            && input_type != MANSCAN_OBJECT
            && input_type != FILTER_SET
            && input_type != ADJUST_FILTER
            && input_type != CONST_SET
            && input_type != BASIC_SCAN_OBJECT
            && input_type != AUTO_EDGE_FEATURE
            && input_type != CONTACT_EDGE_POINT_FEATURE)   // Replaces AUTO_EDGE_FEATURE - DSZ