PR 254323 Profile "Form Only" not reporting correctly

huangyhg

<< Bob Hospadaruk  --  04/10/08  13:49:04>>
See the uploaded test case with each typ of profile.  Problem verified in 3.7 up.
The test cas has 4 points only that all have 1mm of deviation along their respectice normal vectors. In this case, fitting is not necessay because the pattern is located perfectly anyways, BUT there should still be 1mm of error shown, because the form is bad.
Call me before you reject this?  248-613-2476
<<END>>


<< Jared Hess (Development Notes)  --  04/08/09  22:53:11>>
This has been addedtoreadme for v44 (or ignored if internal item).
<<END>>
<< Changes made by Neil Kay -- 02/24/09  13:31:13>>
Status:  RESOLVED to CLOSED
<<END>>
<< Don Turcotte  --  05/07/08  17:11:09>>
Working on problem from Bob regarding graphical analysis with profile of line, form only.  This is a continuation of this PR (# 254323  - Profile "Form Only" not reporting correctly).  I fixed this PR so form only now includes size but the graphical analysis is still drawing the tol lines centered on the midpoint between the max and min deviations and not centered on the nominal.

<<END>>
<< Bob Hospadaruk  --  05/06/08  15:09:14>>
Woo Hoo!
<<END>>
<< David Petrizze  --  05/07/08  10:43:37>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 05/07/08  10:43:42>>
Action:  David Petrizze to Bob Hospadaruk, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  05/02/08  15:42:52>>
Merged into V43R.
Files inserted to server
------------------------
V43R\DIMENS\DIM_PROF.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/02/08  15:43:15>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  05/02/08  14:11:31>>
Hi Don, please go ahead in V43R per my e-mails.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 05/02/08  14:11:35>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte  --  05/02/08  14:34:03>>
The issue here is that profile "form only" should include size.  A circle at perfect form but too small should report a profile "form only" error even though the circularity would report zero deviation.  The definition of profile requires that the actual hits be within a tolerance of the nominal surface regardless of perfect form.  Profile with no datums (form only) is a check of both form and size by Y14.5.
I have fixed this in both legacy and FCF so that "form only" will report an error when the size is too small (or too big) even when the form is perfect.  With "form only", if max is pos and min is neg (or vice versa), the deviation is max - min.  This case will report the same profile deviation as before.  When both max and min are pos or both are neg, the deviation is reported as the larger of max or min.  This will report an error when the size of wrong.
Fixed in V43B and V44B.
Files inserted to server
------------------------
V43B\DIMENS\DIM_PROF.CPP
V44B\DIMENS\DIM_PROF.CPP
<<END>>
<< Changes made by Don Turcotte -- 05/02/08  14:34:38>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Bob Hospadaruk  --  04/28/08  16:32:32>>
You still can call me...
<<END>>
<< Changes made by Bob Hospadaruk -- 04/28/08  16:32:33>>
Action:  Bob Hospadaruk to Don Turcotte, Status:  MOREINFO to OPEN
<<END>>
<< Don Turcotte  --  04/21/08  13:27:26>>
The form is 0 since each point is offset from its nominal position by 1mm along the nominal vector.   Both the nominal and measured shape is a perfect square.  Why do yo think the form is bad?
<<END>>
<< Changes made by Don Turcotte -- 04/21/08  13:27:39>>
Action:  Don Turcotte to Bob Hospadaruk, Status:  OPEN to MOREINFO
<<END>>
<< Bill Wilcox  --  04/10/08  21:58:13>>
If this is about legacy profile. It is working as designed and no changes are planned.
<<END>>
<< Changes made by Tim Wernicke -- 04/10/08  13:09:56>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>