review PR 249849 PCDMIS crash when editing FCF true position

huangyhg

review PR 249849 PCDMIS crash when editing FCF true position
<< Thomas Pettersson  --  08/23/07  10:56:51>>
<<END>>
<< Thomas Pettersson  --  08/23/07  10:56:19>>
PCDMIS crash when editing a FCF true position. Just deleted one of feaure to the FCF calculation and open FCF true position with F9. When clicking on the form PCDMIS crash.,
Using the PCDMIS version from 3 Aug 2007
Steps to reproduce:
load test4b.prg
delete CIR3
Open FCFLOC1 with F9
Click on Clear buttom
PCDMIS crash
Results:
PCDMIS crash
Expected Results:
PCDMIS should keep running
<<END>>

huangyhg

// PR249849 - if we deleted a feature, we must rebuild the array m_leaderFeatures
      if( newptr == NULL )
      {
        CPCDcommand ** leaderFeatures = NULL;
        if( GetNumLeaderLines() > 1 )
        {
          leaderFeatures = new CPCDcommand *[GetNumLeaderLines()-1];
          int inx = 0;
          for(int j=0; j<GetNumLeaderLines(); j++ )
          {
            if( m_leaderFeatures[j] != NULL )
              leaderFeatures[inx++] = m_leaderFeatures[j];
          }
        }
        SetLeaderFeatures(leaderFeatures, GetNumLeaderLines()-1);
        delete [] leaderFeatures;
      }
      break;
    }

huangyhg

T:\V43B\INCLUDE\FEATCTRLFRM.H(935):    m_leaderFeatures = NULL; // PR249849
  T:\V43B\INCLUDE\FEATCTRLFRM.H(936):    if( in_num_feats > 0 ) // PR249849
  T:\V43B\INCLUDE\FEATCTRLFRM.H(944):    m_numLeaderLines = in_num_feats; // PR249849
  T:\V43B\DIMENS\FEATCTRLFRM.CPP(11600):      // PR249849 - if we deleted a feature, we must rebuild the array m_leaderFeatures