Review - PR 245557 The default Design Notes text does not change to match the

huangyhg

The default Design Notes text does not change to match the selected GD&T tolerance symbol selected in the FCF Editor.<< Larry Clark  --  12/11/06  12:02:20>>
When you are in the Feature Control Frame Editior, if you select a different GD&T symbol, the original Design Notes default text does not change to match the newly selected GD&T symbol.

Steps to reproduce:
For example:
1) Insert | Dimension | Circularity...   Result:  The XactMeasure GD&T -  Circularity Dimension dialog appears and the Design Notes text below the FCF in the Feature Control Frame Editor appears as "FCFCIRTY1".
2) Click on the Circularity GD&T symbol to display a drop down list of available GD&T symbols.
3) Select, for example, the cylindricity symbol and click anywhere in the white region inside the Feature Control Frame Editor to update.

Results:
The dialog box caption changes to "XactMeasure GD&T - Cylindricity Dimension", and the cylindricity symbol now appears in the FCF Editor and in the Preview pane, but the Design Notest text remains the same, "FCFCIRTY1"  for Circularity.

Expected Results:
The default Design Notes text changes to FCFCYLY1 to match the selected Cylindricity symbol, or changes to match whatever new symbol is selected.
<<END>>
<< Changes made by Neil Kay -- 07/23/08  16:32:17>>
Action:  Paola Pallo to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  11:23:54>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte  --  04/26/07  16:56:02>>
Fixed in V42 beta and V43B.
Files inserted to server
------------------------
V42\INCLUDE\FEATCTRLFRMDLG.H
V42\MENU\FEATCTRLFRMDLG.CPP
V43B\INCLUDE\FEATCTRLFRMDLG.H
V43B\MENU\FEATCTRLFRMDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/26/07  16:56:16>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 12/11/06  14:36:03>>
Action:  Tim Wernicke to Don Turcotte, Priority:  to High
<<END>>

huangyhg

// PR245557

decrement_id_count(m_pPartProgram, FEATURE_CONTROL_FRAME, old_type);

m_pPartProgram->GetDialogCommand()->set_id(_T("")); // allow duplicate id so this FCF can be reassigned original id

create_id(m_pPartProgram, m_pFCF->type(), m_id, m_pFCF->get_defines_type());

m_pFCF->set_id(m_id);

m_pFCFInit->set_id(m_id);

UpdateLine4Notes(TRUE);