Review- PR252431Program is taking an extremely long time to update.

huangyhg

Program is taking an extremely long time to update.
<< Chuck Chronicle  --  01/03/08  14:06:53>>
When a change to a feature is made(ie. depth, automove distance) in the attached program the system hangs for 15-20 seconds before responding.  If the dimensions are deleted the system responds in an acceptable amount of time.
Steps to reproduce:
1. Open up the attached program
2. Change an autofeature
3. Note the time it takes for the system to respond
4. Delete dims and try again.
5. Note the time it takes to respond
<<END>>
<< Changes made by Neil Kay -- 07/23/08  16:32:37>>
Action:  Paola Pallo to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  14:28:01>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte  --  01/18/08  15:26:09>>
I have fixed this so only the affected FCFs are updated when a feature is modified and the user answers Yes to "Do you want to update the nominals of related dimensions" (or Yes is the default answer).
Fixed in V42 beta, V43B, V44B.
Files inserted to server
------------------------
V42\DIMENS\FEATCTRLFRM.CPP
V42\EDITORS\EDITWIN.CPP
V42\INCLUDE\FEATCTRLFRM.H
V42\SOURCE\COMMAND.CPP
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\EDITORS\EDITWIN.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\SOURCE\COMMAND.CPP
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\EDITORS\EDITWIN.CPP
V44B\INCLUDE\FEATCTRLFRM.H
V44B\SOURCE\COMMAND.CPP
<<END>>
<< Changes made by Don Turcotte -- 01/18/08  15:26:55>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  01/18/08  15:16:36>>
The issue here is that when you modify a feature and aswer Yes to "Do you want to update nominals of related dimensions", the Editwin is incorrectly updating all the FCFs in the program instead of just the FCFs that were affected by the feature change.  Since there are over 150 FCFs in this program, the unnecessary processing takes a lot of time.  (Note: Using Edit | Preferences | Setup, "Warnings" button, you may have set the default answer to "Do you want to update..." to Yes, so this processing may be going on without the user being aware of it.)
<<END>>
<< Changes made by Don Turcotte -- 01/18/08  15:16:40>>
Action:  Chuck Chronicle to Don Turcotte
<<END>>
<< David Chronicle  --  01/18/08  11:40:00>>
Program still runs uber-slow.
<<END>>
<< Changes made by David Chronicle -- 01/18/08  11:40:09>>
Action:  Don Turcotte to Chuck Chronicle
<<END>>
<< Changes made by Tim Wernicke -- 01/04/08  09:06:42>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>
<< Chuck Chronicle  --  01/03/08  14:10:03>>
Dave Chronicle is currently at the customer site trying to resolve this issue.
<<END>>
<< Chuck Chronicle  --  01/03/08  14:09:28>>
I tested this in 4.3b and had the same result.
<<END>>

huangyhg

elseif (p->is_featCtrlFrm()) //238954 <20mar06 paola>: to upgrade FCF as done for legacy dimensions

{

if( ((CPCDFeatCtrlFrm*)p)->NeedUpdate() ) // PR252431 - This FCF was affected by the change.

{

((CPCDFeatCtrlFrm*)p)->ResetNeedUpdate(); // PR252431

if( ((CPCDFeatCtrlFrm *)p)->UpdateAxesListForFeature(changed) ) // PR248563 - don't update internal commands unnecessarily // PR247217

((CPCDFeatCtrlFrm *)p)->update_internal_commands(FALSE); // PR243658 - don't delete axes lists, otherwise we lose user entered nominals.

remove_gh_from_list(GMARKERS, p);

remove_gh_from_list_AppData(GMARKERS, (DWORD) p);