Review - PR 252089 Composite Surface profile does not evaluate lower frame co

huangyhg

Composite Surface profile does not evaluate lower frame correctly
<< Doug Sjogren  --  12/07/07  12:31:50>>
I will attach a program that I looked at in 4.3 Beta 12/6/07.  The customer is looking for the Composite Profile tolerance to evaluat ethe position of the surface in the upper frame to datums at one tolerance, and then the form of that surface in th elower half.
The FCF creates the upper frame OKay.
The lower frame however is reported as FORM ONLy on the report, but the toleranc eis split and the form deviation is then evaluated to half of what it should be.
<<END>>

<< Changes made by Neil Kay -- 07/23/08  16:31:19>>
Action:  Paola Pallo to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  14:57:50>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte  --  02/28/08  16:47:29>>
The source of the crash when loading the attached program was traced to changes made for Task 103855.  This has been fixed in PR253558.
The issues in this PR have been fixed in V43B and V44B.  See the changes marked "R252089".  Basically, when the lower segment profile is FORMONLY by virtue of not having a datum, the tol must not be divided between plus and minus (minus is always 0 and plus is the full tol).
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\FEATCTRLFRM.H

<<END>>
<< Changes made by Don Turcotte -- 02/28/08  16:47:51>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  02/27/08  17:13:07>>
V43B crashes trying to load this program.  I was finally able to create a V42 version of the program.  I have made the necessary code changes to V43B and will complete testing tomorrow.
<<END>>
<< Changes made by Tim Wernicke -- 12/07/07  16:55:01>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to High
<<END>>

huangyhg

// PR252089

BOOLCPCDFeatCtrlFrm::IsLine3ProfileFormOnly()

{

BOOLstatus = FALSE;

intii = 0;

for(; ii<m_InternalCmdsArray3.GetSize(); ii++)

{

CPCDcommand *p = m_InternalCmdsArray3.GetAt(ii);

if(p)

{

if(p->type() == DIMENSION_PROFILE_LINE || p->type() == DIMENSION_PROFILE_SURFACE)

{

if( !((CPCDdim_profile*)p)->m_form_and_loc || !((CPCDdim_profile*)p)->m_pPrimary )

status = TRUE;

break;

}

}

}

returnstatus;

}