PR258594 - True Position dimensions in loop, alignment in loop, do not work p

huangyhg

True Position dimensions in loop, alignment in loop, do not work properly.
<< Doug Sjogren  --  12/04/08  17:51:59>>
I will attach a program tomorrow.  
The customer program which originally ran fine offline here, graphicaly looked correct, does not now for some reason.  

The location dimension for the same feature are correct for each iteration, just the FCF TPs get strange numbers due to DRF and current alignment in loop conflict.
Legacy dimesnion does the same when datums are used, but if the datums are not used, then the values look correct.
I will attach their program, but also I will attempt to create a loop example that demonstrates this.  
<<END>>

<< Changes made by Don Turcotte -- 12/05/08  16:17:56>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  12/05/08  16:15:32>>
Since this same change works in V431, Tim has authorized merging into V431.
Files inserted to server
------------------------
V431\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Tim Wernicke -- 12/05/08  15:12:05>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte  --  12/05/08  15:22:12>>
This does not work correctly in any version (V42 MR2, V43 MR1, V43B, V44B).  
I have fixed this in V43B, V44B.  You must also used variables for the feature nominals in the FCF TP commands as follows:
FCFLOC1 =TRUE POSITION OF DATUM_E,DATUM_D
            FEATCTRLFRAME/SHOWNOMS=YES,SHOWPARAMS=YES,SHOWEXPANDED=YES
              SIZE TOLERANCES/2,DIAMETER,0.131,0.002,0.002
              PRIMARY DIMENSION/TRUE POSITION,DIAMETER,0.01,RFS,A,B,C
              SECONDARY DIMENSION/,DIAMETER,0.003,RFS,A,<dat>,<dat>
              NOTE/FCFLOC1
            FEATURES/DATUM_E,DATUM_D,,
            FEATURE SET
             X:NOM=0.975
             Y:NOM=-17.85
            <NEW>
            DATUM_E
             X:NOM=DATUM_E.TX
             Y:NOM=DATUM_E.TY
            <NEW>
            DATUM_D
             X:NOM=DATUM_D.TX
             Y:NOM=DATUM_D.TY
            <NEW>
FCFLOC2 =TRUE POSITION OF CIR1,CIR2
            FEATCTRLFRAME/SHOWNOMS=YES,SHOWPARAMS=YES,SHOWEXPANDED=YES
              SIZE TOLERANCES/2,DIAMETER,0.092,0.004,0.002
              PRIMARY DIMENSION/TRUE POSITION,DIAMETER,0.01,A,B,C
              SECONDARY DIMENSION/,0.003,A,<dat>,<dat>
              NOTE/FCFLOC2
            FEATURES/CIR1,CIR2,,
            FEATURE SET
             X:NOM=0.975
             Y:NOM=-17.85
            <NEW>
            CIR1
             X:NOM=CIR1.TX
             Y:NOM=CIR1.TY
            <NEW>
            CIR2
             X:NOM=CIR2.TX
             Y:NOM=CIR2.TY
            <NEW>
When you execute this program, if you get the dialog prompt "Carry nominals back to the feature?", you should answer NO.
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Don Turcotte -- 12/05/08  15:22:39>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 12/04/08  17:13:02>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

void CPCDFeatCtrlFrm::CheckIfLooping()
  // PR258594
  if( global_loop_start ) // we are in a loop
    update_internal_commands();