PR238593 - In election - SetUPp Options -Dimension - Angle Degrees it is impo

huangyhg

<< Hana Dichterova  --  02/21/06  19:35:20>>
In election - SetUPp Options -Dimension - Angle Degrees it is impossible hold out 0-360 as a default.

<<END>>

huangyhg

<< Yanhua Huang  --  12/06/08  16:38:40>>
Thanks, fixed PR238593 just now.
For "angle degree", the current solution is designed as below.
1. If create a new PP, use the value in registry setting (Setup-Dimension-Angle Degrees  - 0 to 360 - Defaults-OK).
2. If open an existing PP, use the value serialized in the PP.

******************************
Sat Dec 06 01:12:54 2008
******************************

Files inserted to server
------------------------
V44B\SOURCE\ARCHGVAR.CPP
void InitGlobals(CPCDpart_program *m_pPartProgram)
{
//line 4038
                KeyName = IDS_INI_DIM_ANGLE_RANGE;
                SETOPTION(ANGLERANGE360, (PCDGetProfileInt(AppName, KeyName, 0) ? TRUE : FALSE));
}
yanhua

huangyhg

PR256827 Default feature tolerance not working as expected
<< Christian Furnival  --  09/02/08  16:39:23>>
For test purposes I set my circle tolerance to 0.5 and then set my 2D profile to 1.
I measured a circle, and then used 2D Profile on the same feature.  I did a quick location dimension on both features and got the following.
Circle
X 0.500
Y 0.500
D 0.500
2DProfile
X 1.000
Y 1.000
Z 1.000
The tolerance was as expected.  I then changed the default tolerance for both feature types.
I set the circle to 1, and the 2D Profile to 0.5.
And again, measured 2 new features with location dimensions.
These were the results.
Circle
X 1.000
Y 1.000
D 0.500
2DProfile
X 1.000
Y 1.000
Z 1.000
My questions are:
On the circle, why did the X and Y tolerance change to the new default value but not the diameter??
On the 2D Profile the tolerance remained as 1.000, this did not change to to the new default value.
I have attached my PP and PRB files.
<<END>>

huangyhg

1. setup option dialog
t:\V44B\INCLUDE\DIMSETUP.H
enum{ IDD = IDD_SETUP_DIM };
IDC_FEATURE_LIST
IDC_TOLERANCE
DDX_Text(pDX, IDC_TOLERANCE, m_szDefaultFeatureTolerance);

IDC_APPLY_TO_ALL
2. location dialog

t:\V44B\INCLUDE\DIMLOCDL.H
class CDimLocDlg: public CDialog_with_feature_list

IDD_DIM_LOCATION
IDC_DIM_AXES_TOL_COMBO
DDX_Control(pDX, IDC_DIM_AXES_TOL_COMBO, m_setTolsAxes);

if (tolsStr == S_ES_ALL)

{

m_plustol_str = m_all_plus_str;

m_minustol_str = m_all_minus_str;

}

IDC_ALL_DIM_PLUSTOL
DDX_Text(pDX, IDC_ALL_DIM_PLUSTOL, m_plustol_str);

IDC_ALL_DIM_MINUSTOL
DDX_Text(pDX, IDC_ALL_DIM_MINUSTOL, m_minustol_str);




global_default_tolerances

t:\V44B\DIMENS\START_LO.CPP
CPCDcommand * CPCDstart_location::add_default_axes(int* in_axes)
PCDLRN.exe!CPCDlocation::set_minus_tol(double in_minus_tol=2.0000000000000000, int clear_dmis_label=0) Line 1127 C++
PCDLRN.exe!CPCDlocation::SetDefaultTolerance(CPCDcommand * pOwner=0x14431610) Line 1669 + 0x1d bytes C++
> PCDLRN.exe!CPCDstart_location::add_default_axes(int * in_axes=0x0013e700) Line 392 C++
PCDLRN.exe!CPCDstart_location::read_dialog(CDialog * in_dlg=0x14670938, CPCDcommand * * new_objects=0x0013ea3c) Line 2375 C++

if (GETOPTION(DEFTOLS)) //If we're not using the global_defaults //PR#250963

doubleCPCDcommand::GetPreviousTolerance(CPCDcommand* pCurrentDimension, CPCDcommand *pDimensionOwner, intnUpperLowerTolFlag)

{

intnOwnerFeatureType = pDimensionOwner ? pDimensionOwner->feature() : 0;

doubledPreviousTol = get_previous_tolerance(m_pPartProgram,pCurrentDimension,nUpperLowerTolFlag,nOwnerFeatureType);

if( dPreviousTol < DIFF_TOL && !GETOPTION(DEFTOLS) && pDimensionOwner )

{

dPreviousTol = GetDefaultFeatureTypeTolerance(pDimensionOwner);

}

return( dPreviousTol );

}

#defineglobal_number_of_decimals_reportingm_pPartProgram->number_of_decimals_reporting

huangyhg

IDC_AUTODIM_SETUP
ID_SETUP_DIM_AUTODIM_LOCATION
ID_SETUP_DIM_AUTODIM

m_AutoDimLocTP = GETINIOPTION(AUTODIMLEGACYTP) ? 1 : 0; // m_AutoDimLocTP is 0 for location dimensions, 1 for true position dimensions, only for legacy dimensions, #100576
SETINIOPTION(AUTODIMLEGACYTP, m_AutoDimLocTP); // m_AutoDimLocTP is 0 if location, 1 for true position dimensions, #100576
INIEntry.LoadString(IDS_INI_AUTOLEGACYLOCTP);
VERIFY(PCDWriteProfileInt(INISection, INIEntry, !m_AutoDimLocTP)); // m_AutoDimLocTP is 0 if Loc, 1 for TP dimensions that get creted for legacy dimensions, #100576

DDX_Check(pDX, ID_SETUP_DIM_AUTODIM, m_AutoDimPrntout);
SETINIOPTION(AUTODIM, m_AutoDimPrntout);

SETINIOPTION(AUTODIMLEGACYTP, m_AutoDimLocTP); // m_AutoDimLocTP is 0 if location, 1 for true position dimensions, #100576
// PR256827 - yanhua

huangyhg

Pr232389