PR258509 - number of dimensions does not match cad

huangyhg

number of dimensions does not match cad
<< Jean Wang  --  12/01/08  16:15:40>>
Dimension number in the Cad only reporting can't be controlled when I specified the number value. Please see the file number_dimensions.rar that I attached.
<<END>>
<< Ben Mathews  --  12/08/08  15:01:14>>
Move the new checkbox when in landscape mode and clean up the cad reporting mod.
Mon Dec 08 14:02:23 2008
V42R\SOURCE\REPORTGENERATOR.CPP
V431\SOURCE\REPORTGENERATOR.CPP
V44B\HYPER\CADREPORTINGOBJECT.CPP
V44B\HYPER\HYPERCADWINSELECTELEMENTS.CPP
V44B\SOURCE\REPORTGENERATOR.CPP

Fix position of new checkbox and move the layout rectangle to fix positioning issues.
Mon Dec 08 14:59:12 2008
V42R\RESOURCE\LANGS\ENGLISH\Resource.rc
V42R\LIB\CADONLY.RTP
V431\LIB\CADONLY.RTP
V44B\LIB\CADONLY.RTP
<<END>>
<< Changes made by Ben Mathews -- 12/08/08  15:01:21>>
Action:  Ben Mathews to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Ben Mathews  --  12/05/08  17:20:18>>
Steve's changes for 255175 directly conflict with the historical design of the CadReportingObject mod's design of affecting all pages.  Bret and I put in a checkbox on the dialog that will allow both behaviors.  
Fri Dec 05 17:16:16 2008
V42R\HYPER\HYPERCADWINSELECTELEMENTS.CPP
V42R\HYPER\LAYOUTCONTROL.H
V42R\INCLUDE\HYPERCADWINSELECTELEMENTS.H
V42R\INCLUDE\resource.h
V42R\RESOURCE\LANGS\ENGLISH\Resource.rc
V42R\SOURCE\REPORTGENERATOR.CPP
V431\HYPER\HYPERCADWINSELECTELEMENTS.CPP
V431\HYPER\LAYOUTCONTROL.CPP
V431\HYPER\LayoutControl.h
V431\INCLUDE\HYPERCADWINSELECTELEMENTS.H
V431\INCLUDE\resource.h
V431\RESOURCE\LANGS\ENGLISH\Resource.rc
V431\SOURCE\REPORTGENERATOR.CPP
V431\SOURCE\REPORTMOD.CPP
V44B\HYPER\HYPERCADWINSELECTELEMENTS.CPP
V44B\HYPER\LAYOUTCONTROL.CPP
V44B\HYPER\LAYOUTCONTROL.H
V44B\INCLUDE\HYPERCADWINSELECTELEMENTS.H
V44B\INCLUDE\REPORTMOD.H
V44B\INCLUDE\resource.h
V44B\RESOURCE\LANGS\ENGLISH\Resource.rc
V44B\SOURCE\REPORTGENERATOR.CPP
V44B\SOURCE\REPORTMOD.CPP
<<END>>
<< Tim Wernicke  --  12/04/08  11:38:24>>
I tested this in last night's V431 build.  With the supplied part program in the CAD Only report I entered the Label Layout Wizard dialog and set the Label Count to (5) and clicked OK.
What I found is that some pages did have (5) labels but they do not seem to respect the boundaries of other objects on the page.  Some label overlap each other, page footer and the color bar.  They do all seem to at least be on the page now however which is some improvement.
The other (original) issue here is the label count per page.  As I set this to (5) I would expect each page to have (5).  
Page #1: (5)
Page #2: (5)
Page #3: (8)
Page #4: (2)
<<END>>
<< Changes made by Tim Wernicke -- 12/04/08  11:40:40>>
Action:  David Petrizze to Ben Mathews, Status:  REVIEW to OPEN
<<END>>
<< Jean Wang  --  12/04/08  23:11:22>>
I tried with today's build, the problem is still existed.
<<END>>
<< Ben Mathews  --  12/03/08  15:31:31>>
Problem
Changes Steve Barber made to reportgenerator.cpp for pr 256035 and pr 256034 (checking on 7/22/08, #8 for 431).  He was trying to preserve position mods and hidden mods.  Previously, we removed old layout mods for the section, he changed this to the page/view only.  I modified this to  preserve his new behavior has long as the labels per cro had not changed.  If it had, I removed everything as we used to do.  
There was a check in hte loop that ctrlids match.  This didn't seem to be necessary with Steve's changes.  Since it prevented label mods from being removed, I removed that check.
Testing
I've tested the scenerio for all three problem reports (this one and those referenced above).
My expectation is that if I change the number of labels on a CRO, position mods are removed.  If the number of labels does not change, position should be preserved.
Wed Dec 03 15:29:07 2008
V42R\SOURCE\REPORTGENERATOR.CPP
V431\SOURCE\REPORTGENERATOR.CPP
V44B\SOURCE\REPORTGENERATOR.CPP
<<END>>
<< Changes made by Ben Mathews -- 12/03/08  15:31:43>>
Action:  Ben Mathews to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by David Petrizze -- 12/03/08  08:15:16>>
Action:  Reporting Group to Ben Mathews
<<END>>
<< Changes made by David Petrizze -- 12/03/08  08:15:08>>
Assigned:  Reporting Group to Ben Mathews
<<END>>
<< Changes made by Ben Mathews -- 12/03/08  08:11:28>>
Action:  Reporting Group to Ben Mathews, Assigned:  Reporting Group to Ben Mathews
<<END>>
<< Jean Wang  --  12/03/08  08:11:07>>
yes, I agree with Tim.
<<END>>
<< Tim Wernicke  --  12/02/08  14:34:23>>
I ran some tests on this using today's V42R build.  It does seem that the number of Dim Info boxes does not seem to always be in synch with the Label Layout Wizard.
The other problem (and more significant in my opinion) is the fact that the labels often end up completely off of the page and out of view.
<<END>>
<< Changes made by Tim Wernicke -- 12/02/08  14:34:33>>
Priority:  Critical to Stop Rel.
<<END>>
<< Jean Wang  --  12/03/08  00:12:53>>
it works fine in the earlier v42mr2, but now this problem come up  with v42mr2,v43mr1 and v44b.
<<END>>
<< Changes made by Tim Wernicke -- 12/01/08  10:04:10>>
Action:  Tim Wernicke to Reporting Group, Assigned:   to Reporting Group, Priority:  to Critical
<<END>>