PR 252015 - UseISOCalculations reports the wrong out of tolerance value when

huangyhg

UseISOCalculations reports the wrong out of tolerance value when using Legacy Surface Profile
<< Doug Sjogren  --  12/04/07  10:50:59>>
The customer has hundreds, possibly thousands of existing programs that were created prior to the new GD&T tools.  They are using the UseISOCalculations option and this works fine in the new style GD&T
Look at the dimension below.  The OOT value is reported as 0.0140" , whereas it is reported as 0.004" in the new style.  
With the USeIso, the 0.0240" Meas value should be compared to the 0.0200" tolerance band for form.  
They need this fixed and added to 4.2 MR2.

LEGACY
DIM PROF20= PROFILE OF SURFACE OF SET SCN1    FORMANDLOCATION  UNITS=IN ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH
AX    NOMINAL       +TOL       -TOL       MEAS        DEV        OUTTOL        MAX        MIN
M      0.0000            0.0100     0.0100     0.0240      0.0240     0.0140           0.0120     0.0100 ----------------->
<<END>>

<< Yanhua Huang  --  01/13/09  14:52:02>>
Tested in V44B, working.
<<END>>
<< Changes made by Yanhua Huang -- 01/13/09  14:52:41>>
Action:  Yanhua Huang to Doug Sjogren, Status:  REVIEW to RESOLVED
<<END>>
<< Yanhua Huang  --  01/13/09  14:41:47>>
Got it, thanks, Don.
<<END>>
<< Don Turcotte  --  01/05/09  11:11:57>>
This is working correctly.  The code in CPCDFeatCtrlFrm::executeprivate(...) temporarily sets the global_UseISOCalculations based on the FCF's m_GDTStandard.  The m_GDTStandard is defaulted to the registry setting in global_UseISOCalculations in the FCF constructor.   If the FCF was created using the new code, then the Serialize(...) method of the FCF will set m_GDTStandard based on the user's selection.  Otherwise the registry setting will be used since this was defaulted in the FCF constructor.
Since this is an old program, when you first load the program, the FCF profile will default based on the registry setting.  The legacy profile was originally created with UseISOCalculations true so it will initially report the ISO results.  However, if your registry has UseISOCalculations set false, then you can F9 on the legacy profile and press OK to re-evaluate the legacy profile using the new registry setting.  Then the legacy will report the same as the FCF.  If you go to the advanced tab of the FCF and select ISO 1101 and save this program, then the FCF will report the ISO deviation even though the registry setting is false.
<<END>>
<< Changes made by Don Turcotte -- 01/05/09  11:11:57>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  12/23/08  20:44:41>>
Editing FCF (surface profile), get the different deviation results if click the advanced page or not.
\\V44B\DIMENS\DIM_PROF.CPP, line 6599
    if(global_UseISOCalculations)   
Found this new issue about FCF (surface profile) taken by TK104422 in V44B, because FCF (surface profile) has an independent standard type (m_GDTStandard) which is not same as the standard type (global_UseISOCalculations) of PP.
Add SetStandardType and GetStandardType for m_GDTStandard.
void CPCDFeatCtrlFrm::SetStandardType(const int nType)
{
  m_GDTStandard = nType;
}
int CPCDFeatCtrlFrm::GetStandardType()
{
    return m_GDTStandard;
}
******************************
Tue Dec 23 20:43:13 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\FEATCTRLFRM.H
<<END>>
<< Changes made by Yanhua Huang -- 12/23/08  20:45:22>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Neil Kay -- 12/12/08  09:24:06>>
Action:  Wade Burton to Yanhua Huang, Assigned:  Don Turcotte to CMM Group
<<END>>
<< Don Turcotte  --  09/10/08  09:20:31>>
Merged into V431.
Files inserted to server
------------------------
V431\DIMENS\BASIC_DI.CPP
<<END>>
<< Changes made by Don Turcotte -- 09/10/08  09:21:18>>
Action:  Don Turcotte to Wade Burton, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  09/09/08  16:34:42>>
Hi Don, please go ahead in V431 per my e-mail.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 09/09/08  16:35:34>>
Action:  Wade Burton to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Changes made by Neil Kay -- 07/23/08  14:25:11>>
Action:  David Petrizze to Wade Burton
<<END>>
<< Changes made by Don Turcotte -- 01/17/08  15:17:45>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  01/17/08  15:09:57>>
Fixed in V42 beta , V43B, V44B.
Files inserted to server
------------------------
V42\DIMENS\BASIC_DI.CPP
V43B\DIMENS\BASIC_DI.CPP
V44B\DIMENS\BASIC_DI.CPP
<<END>>
<< Changes made by Tim Wernicke -- 12/05/07  10:24:05>>
Category:  dimensions to GD&T, Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>