PR 244173 Profile dimension using GD&T with Datums results are not re

huangyhg

Profile dimension using GD&T with Datums results are not repeatable.
<< Doug Sjogren  --  10/18/06  09:45:19>>
I am logging this for Shawn Grady who has been working with the customer.  They were trying to profile using the GD&T including a cylinder and a plane as Datums A & B respectively.  They got one value initially , but then successive runs with the same part produces vastly different results when rotating the part, radial features.  Shawn has had preliminary discussion with Don Turcotte and Don believes there is need for investigation.   The same program run using the legacy profile dimension produces repeatable results.  
Attached are the program, two prgs, two results.
<<END>>

<< Changes made by Neil Kay -- 12/12/08  09:24:02>>
Action:  Wade Burton to Yanhua Huang, Assigned:  Don Turcotte to CMM Group
<<END>>
<< Changes made by Neil Kay -- 07/23/08  10:03:59>>
Action:  David Petrizze to Wade Burton
<<END>>
<< Don Turcotte  --  11/02/06  17:30:47>>
I have fixed a couple of things here.  The first in FeatCtrlFrm.cpp was a minor issue that could result in the text mode report and the template report getting out of sync.  The second main issue here is that the datum reference frame profile fitter was setting a "slide zone" that was too restrictive.  This "slide zone" is used to keep the fitter from going to the other side of the galaxy for a "fit".  By being too restrictive, the "slide zone" was preventing the fitter from working optimally.
The other issue here is that the customer is taking only 6 points per plane on a small surface.  This doesn't affect the legacy profile dimensions since these simply evaluate the profile in the current active alignment with no fitting.  But the FCF profiles with datums are using a "fitter" to find the best solution so the more points the better.
Fixed in V41B (beta), V42 (beta), V43B (beta).
Files inserted to server
------------------------
V42\DIMENS\FEATCTRLFRM.CPP
V42\XACTGEOMETRYMATH\minimization.CPP
V42\NETDLL\XactGeometryMath.dll
V42\NETDLL\XactGeometryMathD.dll
V42\NETLIB\XactGeometryMath.lib
V42\NETLIB\XactGeometryMathD.lib
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\XACTGEOMETRYMATH\minimization.CPP
V43B\NETDLL\XactGeometryMath.dll
V43B\NETDLL\XactGeometryMathD.dll
V43B\NETLIB\XactGeometryMath.lib
V43B\NETLIB\XactGeometryMathD.lib
V41B\DIMENS\FEATCTRLFRM.CPP
V41B\XACTGEOMETRYMATH\minimization.cpp
V41B\NETDLL\XactGeometryMath.dll
V41B\NETDLL\XactGeometryMathD.dll
V41B\NETLIB\XactGeometryMath.lib
V41B\NETLIB\XactGeometryMathD.lib
<<END>>
<< Changes made by Don Turcotte -- 11/02/06  17:31:42>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 10/18/06  19:35:49>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

V43B\DIMENS\FEATCTRLFRM.CPP

void CPCDFeatCtrlFrm::draw_trihedron(BOOL bDraw)
          CPCDdim_profile * dim_profile = (CPCDdim_profile*)m_InternalCmdsArray2.GetAt(ii); // PR244173
          datum_ref = (CPCDdatum_reference*)dim_profile->m_pDrf; // PR244173
          if( !datum_ref ) // PR244173
          {
            SetFeatureNominalsFromAxes(); // PR243658
            m_InternalCmdsArray2.GetAt(ii)->do_math(THEO);
            RestoreFeatureNominalsFromAxes(); // PR243658
            datum_ref = (CPCDdatum_reference*)dim_profile->m_pDrf; // PR244173
          }