|
|
楼主 |
发表于 2009-2-19 22:02:08
|
显示全部楼层
回复: PR259379 V44 Dimension/GDT Tests: When I try to add a form axis line
hi in?
[2009-2-18 下午 09:44:02] Donald Turcotte says: yes
[2009-2-18 下午 09:44:34] yanhua Huang says: DIM CYLY1= CYLINDRICITY OF CYLINDER CYL1 UNITS=MM ,$
GRAPH=OFF TEXT=OFF MULT=10.00 OUTPUT=BOTH
AX NOMINAL +TOL -TOL MEAS DEV OUTTOL
M 0.00 0.01 0.00 0.00 0.00 0.00 #-------
>What mean "M"?
[2009-2-18 下午 09:46:29] Donald Turcotte says: M is for Measured results. This identifies the results of the cylindricity. This is also how this line is identified when sent to the statistics report.
[2009-2-18 下午 09:47:24] yanhua Huang says: Got it.
tmpPtr = new VARIABLENAMES(S_ES_T);
tmpPtr->m_CommandTypes.Add(DIMENSION_T_LOCATION);
SPCHChart::SPCVariableNames.AddSorted(tmpPtr);
What mean "T"?
[2009-2-18 下午 09:50:07] Donald Turcotte says: T is a "sheetmetal" axis. It is the deviation of a measured point from the nominal in the direction of the nominal vector. I don't know what T stands for but it is common terminology in sheetmetal applications.
[2009-2-18 下午 09:50:26] yanhua Huang says: oh
[2009-2-18 下午 09:51:03] yanhua Huang says: thickness
[2009-2-18 下午 09:52:07] Donald Turcotte says: The thickness of the sheetmetal.
[2009-2-18 下午 09:52:41] yanhua Huang says: yes, 
[2009-2-18 下午 09:54:32] yanhua Huang says: This morning and afternoon (for me) update tool could not work normally. Sometimes down, sometimes up.
[2009-2-18 下午 09:56:24] Donald Turcotte says: Please talk with Michael Monsen about this. He is in Utah so he will probably not be available for another hour.
[2009-2-18 下午 09:57:38] yanhua Huang says: ok
[2009-2-18 下午 10:22:07] yanhua Huang says: I sent an email about axes.
[2009-2-18 下午 10:22:58] Donald Turcotte says: k, I will have to research this since this has been in PC-DMIS a long time. I suspect it was never updated.
[2009-2-18 下午 10:36:45] yanhua Huang says: Q2: If status window is visible, when create a legacy true position, need axes in status window keep the same order with axes of edit window?
[2009-2-18 下午 10:38:02] Donald Turcotte says: Would be nice, but I don't think this is a critical issue. That is, if it is going to be difficult to fix, don't bother.
[2009-2-18 下午 10:39:40] yanhua Huang says: Got it.
When status window is visible, if multiple features are selected, when creating legacy location with multiple features, should one location or multiple locations be displayed in status window?
[2009-2-18 下午 10:42:48] yanhua Huang says: What mean“DF2”? the secondary feature diameter or the secondary datum diameter?
[2009-2-18 下午 10:42:50] Donald Turcotte says: Probably would be nice to show all the location dimensions in the status window when multiple features are selected. But again, don't bother implementing this if it is going to be difficult and require major changes.
[2009-2-18 下午 10:43:16] Donald Turcotte says: I have no idea what DF2 is. I will have to research this.
[2009-2-18 下午 10:43:21] yanhua Huang says: I see.
[2009-2-18 下午 10:43:47] yanhua Huang says: no questions now.
[下午 09:18:35] yanhua Huang says: hi in?
[下午 09:18:58] Donald Turcotte says: yes
[下午 09:20:23] yanhua Huang says: PR259379
<< Don Ruggieri -- 01/28/09 16:54:31>>
data is in 01282009_05a.zip. When I try to add a form axis line to an existing dimension, it is automatically converted to some other axis type.
Steps to reproduce:
I am testing form diemnsions as part of the overall v44 dimension test plan. I have 4 measured features, a plane, circle, cylinder, and cone. Ive dimensioned the location of each, no problem.
At the end of each dimension, I hit Enter to open a new axis dimension command line. Then I try to change the axis to M for form. As soon as I leave the field it reverts to some other axis letter.
I tried selecting from the lpop-up list.
I tried using the F7/F8 toggle.
I can select the M axis, but it always changes back to something else.
<<END>>
[下午 09:20:59] yanhua Huang says: need we fix the PR?
[下午 09:22:12] yanhua Huang says: t:\V44B\include\dimensio.h
#defineLOC_X_TYPE 0
#defineLOC_Y_TYPE 1
#defineLOC_Z_TYPE 2
#defineLOC_D_TYPE 3
#defineLOC_R_TYPE 4
#defineLOC_A_TYPE 5
#defineLOC_T_TYPE 6
#defineLOC_PR_TYPE 7
#defineLOC_PA_TYPE 8
#defineLOC_M_TYPE 9
#defineLOC_V_TYPE 10
#defineLOC_L_TYPE 11
#defineLOC_PD_TYPE 12
#defineLOC_RS_TYPE 13
#defineLOC_RT_TYPE 14
#defineLOC_S_TYPE 15
#defineLOC_H_TYPE 16
#defineLOC_FL_TYPE 17
#defineLOC_RN_TYPE 18
#defineLOC_ST_TYPE 19
#defineLOC_DF_TYPE 20 // special axis to display MMC, LMC conditions
#defineLOC_D1_TYPE 21 // special axis to display MMC, LMC conditions
[下午 09:22:15] yanhua Huang says: IDS_ES_LOCATN_TYPES_TOGGLE
"X \001Y \001Z \001D \001R \001A \001T \001PR\001PA\001M \001V \001L \001PD\001RS\001RT\001S \001H \001FL\001RN\001ST"
[下午 09:23:51] Donald Turcotte says: Form is either FL (flatness), RN (roundness - circularity, cylindricity) or ST (straightness) depending on the feature type. If the user can add one of these in the edit window, then this is working ok. THe M is not form.
[下午 09:24:07] yanhua Huang says: #defineLOC_M_TYPE 9
"9" is relative to the ninth string
"X \001Y \001Z \001D \001R \001A \001T \001PR\001PA\001M \001V \001L \001PD\001RS\001RT\001S \001H \001FL\001RN\001ST"
[下午 09:26:51] yanhua Huang says: "M" is not form, "M" is used to define axis of legacy dimension (excluding legacy true dimension)
[下午 09:27:16] yanhua Huang says: excluding legacy true position
[下午 09:28:30] Donald Turcotte says: M is not in the list for location dimension, Form in the location dimension is FL, RN, or ST. The M is used in reporting results in other dimensions.
[下午 09:29:03] yanhua Huang says: "X \001Y \001Z \001D \001R \001A \001T \001PR\001PA\001M \001V \001L \001PD\001RS\001RT\001S \001H \001FL\001RN\001ST"
if remove "\001M" from the toggle list, break the macro definition order (#defineLOC_M_TYPE 9) mapping with the toggle order
[下午 09:31:29] Donald Turcotte says: Please do not remove M from this list. If the user can create a FL,RN, ST axis in the location dimension, then everything is working ok. Trying to create an M in the location dimension does not make sense since M does not apply to location dimensions. M is used in other dimensions so it should remain in the toggle string in the resource file.
[下午 09:33:24] yanhua Huang says: need we fix the PR?
[下午 09:34:20] Donald Turcotte says: Have you tested this to verify that the user can add FL, RN, or ST in the location dimension or true position dimension? If this works, then please close the PR.
[下午 09:41:04] yanhua Huang says: testing......
[下午 09:47:16] yanhua Huang says: t:\V44B\MENU\DIMENSIO.CPP, line 11534
CString get_dimension_line_name(CPCDpart_program *m_pPartProgram, CPCDcommand *owner,
const CString& axis, int &type, int loctype, int &typeindex,
double nominal, double measured,
double plus_tol, double minus_tol, int dim_display,
D_TYPES:_TYPE &dtype,
int *dim_display_num_char, BOOL display,
int first, BYTE text_type,
CStringList *str_list, D_TYPES:_TYPE *type_list,
CStringList *toggle_str_list)
{
[下午 09:47:38] yanhua Huang says: CString outStr, temp_str;
// if a programmer really screws up, lets just put in "X "
if(type == LOC_M_TYPE || owner->is_dim_2dang() || owner->is_dim_3dang())
{
temp_str = display_location_field(dim_display, dim_display_num_char);
swprintf_s(global_str,ID_LTRS,temp_str, axis);
outStr = global_str;
type = CONSTANT;
}
else if(type >= LOC_X_TYPE && type <= LOC_ST_TYPE)
{
_tcscpy_s(global_str, S_ES_LOCATN_TYPES_TOGGLE);
type += TOGGLE;
outStr = global_str;
dtype = D_TYPES::AXIS;
}
[下午 09:48:02] yanhua Huang says: 1. location dimension ->S_ES_LOCATN_TYPES_TOGGLE
[下午 09:50:29] yanhua Huang says: CString get_tp_dimension_line_name(CPCDpart_program *m_pPartProgram,
line 12022
2. legacy true position -> S_ES_TP_LOCATN_TYPES_TOGGLE
[下午 09:58:07] yanhua Huang says: t:\V44B\DIMENS\DIM_2D_A.CPP
CString tmp_char(S_ES_A);line 687
dimension_line(m_pPartProgram, this, TRUE, get_nominal(), get_plus_tol(), get_minus_tol(TRUE), get_minus_tol(FALSE),
get_measured(), get_max(), get_min(), get_deviation(), get_outtol(), tmp_char, m_dim_display_num_chars);
3. angle dimension ->S_ES_A
[下午 09:59:36] yanhua Huang says: t:\V44B\DIMENS\DIM_2D_D.CPP, line 683
CString tmp_char(S_ES_M);
dimension_line(m_pPartProgram, this, TRUE, get_nominal(), get_plus_tol(), get_minus_tol(TRUE), get_minus_tol(FALSE),
get_measured(), get_max(), get_min(), get_deviation(), get_outtol(), tmp_char, m_dim_display_num_chars);
4. distance dimension ->S_ES_M
[下午 10:01:52] yanhua Huang says: t:\V44B\DIMENS\DIM_CONC.CPP, line 726
CString tmp_char(S_ES_M);
dimension_line(m_pPartProgram, this, TRUE, get_nominal(), get_plus_tol(), get_minus_tol(TRUE), get_minus_tol(FALSE),
get_measured(), get_max(), get_min(), get_deviation(), get_outtol(), tmp_char, m_dim_display_num_chars);
5. other legacy form and location dimension -> S_ES_M-
[下午 10:04:20] yanhua Huang says: I guess that we can remove "\001M" from the location toggle list, if we can keep the mapping relationship between macro definition (#defineLOC_M_TYPE 9) and the location toggle.
[下午 10:06:20] Donald Turcotte says: If it is not causing problems to have M in the location toggle list, then don't remove it This could introduce unexpected errors.
[下午 10:08:41] yanhua Huang says: Yes, I agree, the PR is a small problem |
|
IP卡
狗仔卡
发表于 2009-2-19 19:00:17
提升卡
置顶卡
沉默卡
喧嚣卡
变色卡
显身卡