Review - PR 253538 - The creation of a FCF with Dimension Info, hides the sta

huangyhg

The creation of a FCF with Dimension Info, hides the statement in the Edit Window.
<< Domenico Varacalli  --  02/28/08  15:25:09>>
To look at sequence of GIFs.
1 - To create a FCF with Dimension Info (check box = on). The statement DIMINFO/FCFLOC1;ICON.... is written.
2 - Now, for instance, try to delete this statement (Undo Command or Delete Command)
3 - The operation seems correctly effected, but now to alternate the commands: Summary Mode - Command Mode.
4 - The statement of FCF appears. In reality the FCF had previously been written but it was hidden.
<<END>>


<< Don Turcotte  --  03/12/08  10:48:42>>
There were two problems in globals.cpp method command_dialog_ok(...).
1) If an FCF was created with a DimInfo (checkbox on advanced tab), the call to paint_editbox(...) was made for the DimInfo and not the FCF.  Fixed this to make call for both.
2) Editing an FCF with a DimInfo (F9), a new DimInfo was created so the FCF would now have two DimInfo's.  Fixed this so when editing, the new DimInfo is removed, leaving only the original DimInfo.
Fixed in V43B and V44B.
Files inserted to server
------------------------
V43B\SOURCE\GLOBALS.CPP
V44B\SOURCE\GLOBALS.CPP
<<END>>
<< Changes made by Don Turcotte -- 03/12/08  10:49:09>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 02/29/08  09:52:47>>
Priority:  to Critical
<<END>>

huangyhg

CPCDcommand * command_dialog_ok(CPCDpart_program *m_pPartProgram, CDialog * dlg, int* KeepDlgOpen, int* commands_deleted)
        if( needs_insert ) // PR253538 - don't insert auxilliary command if we are editing (F9)
        {
          if (pBeginObj) //you are modifying an existing command with F9, and this is adding new commands later it : to fix 235726
            CreateText4new_objects = TRUE;
          else //you are inserting more that 1 new command of the same type: to fix 236220
            CreateText4new_objects = FALSE;
          if (new_objects->InsertAtEnd(CreateText4new_objects))  // Passed in TRUE, so text gets drawn.  If we wait until later, there is a chance it doesn't exist yet when we call EwRefreshObjectTextRange, so it won't draw the new commands.  #235726, whb 10/17/2005
          {
            new_objects = RemoveCommands(new_objects);
            if (commands_deleted)
              * commands_deleted = TRUE;
          }
          //lastobj = m_pPartProgram->GetCurrentCommand(); // PR253538 - lastobj must point to main dialog command (e.g., FCF) and not the new_object (e.g., DimInfo)
        }
        else // PR253538 - we're editing (F9) so delete auxilliary command to avoid memory leaks
          new_objects = RemoveCommands(new_objects);

huangyhg

else
      { // <rwh/AR 20050524> PR232284: Talked with Andy about this and ran some short tests
        // to make sure his previous fix is still good. This prevents the second paint on the
        // edit window when pBeginObj isn't NULL.
        paint_editbox(m_pPartProgram, lastobj);
        if(new_objects) // PR253538 - paint the auxilliary command also (e.g., DimInfo)
          paint_editbox(m_pPartProgram, new_objects);
      }