PR 255528 Symmetry dimension. Differences between legacy/ non legacy

huangyhg

Symmetry dimension. Differences between legacy/ non legacy
<< Beatriz Beraza  --  06/19/08  16:22:34>>
See attached pp. I want to calculate the simetry between PLN6, PLN7 and EjeCilPasante axis.
The distances from both planes are different so the resulting error should be not zero.
Used as legacy result is 79.608 mm or 0.  
<<END>>

<< Changes made by Neil Kay -- 02/25/09  19:24:52>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Don Turcotte  --  06/24/08  14:35:50>>
There were cases in FCF symmetry with 2 datums where the direction vector (used to compute the symmetry error) was not calculated correctly.  This was the source of the problem in SIMETRIA2.PRG with FCFSIM1NEE-1.  I have fixed this and also retested against PR#249641.

******************************
Tue Jun 24 14:30:30 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\DATUMREF.CPP
V44B\DIMENS\DIM_SYMM.CPP
V44B\INCLUDE\DATUMREF.H
<<END>>
<< Changes made by Don Turcotte -- 06/24/08  14:36:00>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  06/23/08  17:35:06>>
In the program SIMETRIA.PRG, the legacy dimension SIM3 should be done in the XPLUS workplane.  Then the deviation is 0.270 which is the same as the FCFSIM2 deviation.  
The legacy dimension SIM1 is not supported when the considered features are constructed lines.  This is why the deviation is 0.0.  The FCFSIM1 deviation is 0.211 in this case since FCF symmetry uses the endpoints of the calculated midline.
In program SIMETRIA2.PRG, the legacy SIM2 deviation is 0.0 again because constructed lines are not supported in legacy symmetry.
I am looking into the deviations reported for FCFSIM1NEE-1 and FCFSIM1NEE-2 since these do not look reasonable.  
Legacy SIM17 and FCFSIM1NEE-3 report different deviations since the legacy symmetry uses the measure points and the FCF line-line symmetry uses the endpoints of the calculated midpline.
I am verifying the deviation of FCFSIMNEE-4.
<<END>>
<< Beatriz Beraza  --  06/20/08  17:49:26>>
Could you please explain me these results too? From Cil2 on in simetria2.prg attached. Many thanks.
<<END>>
<< Bill Wilcox  --  06/20/08  09:16:39>>
It sounds like the legacy dimension is not created correctly. Don, can you comment on why the nee FCF symmetry is giving zero for an answer?
<<END>>
<< Changes made by Bill Wilcox -- 06/20/08  09:16:40>>
Action:  Paola Pallo to Don Turcotte, Assigned:  Paola Pallo to Don Turcotte
<<END>>
<< Changes made by Tim Wernicke -- 06/19/08  14:34:53>>
Action:  Tim Wernicke to Paola Pallo, Assigned:   to Paola Pallo, Priority:  to High
<<END>>

huangyhg

// PR254204
            CPCDtp_truediam_location * pTpTrueDiam = dynamic_cast<CPCDtp_truediam_location*>(pCmd);
            if( pTpTrueDiam )
            {
              CPCDcommand * pStartPtr = pTpTrueDiam->get_start_ptr();
              if( pStartPtr && pStartPtr->get_feature1() == in_feature)
              {
                // PR242750
                if( ret_val > 0.0 )
                {
                  if( pCmd->get_plus_tol() < ret_val )
                    ret_val = pCmd->get_plus_tol();
                }
                else
                {
                  ret_val = pCmd->get_plus_tol();
                }
              }