PR 260010 Can not input 0.0 for positional tolerance in FCF of true position

huangyhg

Can not input 0.0 for positional tolerance in FCF of true position
<< Rick Haduch  --  02/23/09  10:14:36>>
Should be able input 0.0 for positional tolerance. Customer says its very common dimension for their products.
Steps to reproduce:
Will not let you input 0.0 for a positional tolerance
Expected Results:
Should be able to use 0.0 for a tolerance.
<<END>>

<< Changes made by Neil Kay -- 02/25/09  19:23:35>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Don Turcotte  --  02/24/09  11:00:19>>
I have completed implementation of this and attached my test programs.  I have uploaded only to V44B pending review of these changes.
Files inserted to server
------------------------
V44B\DIMENS\DATUMREF.CPP
V44B\DIMENS\FEATCTRLFRMUTIL.CPP
V44B\FCF\FCFREPORT.CPP
V44B\INCLUDE\FEATCTRLFRM.H
V44B\INCLUDE\PARTPROG.H
V44B\MENU\DIMENSIO.CPP
V44B\SOURCE\PARTPROG.CPP

<<END>>
<< Changes made by Don Turcotte -- 02/24/09  11:01:16>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  02/23/09  17:27:46>>
PC-DMIS already supports 0 tol at MMC/LMC.  However, the customer wants to do 0 tol at RFS with the tolerance coming from the datum shift (datums at material condition).
The issue here is that with 0 tol at RFS, the datum fitter solves to a very small non-zero deviation, so PC-DMIS thinks this is out-of-tol since the deviation is larger than the tol (0 + 0 bonus at RFS).  This will result in the true position being reported at RFS (datums at RFS).  I am working at fixing this.
There are also other caveats:
1.  True position of a set of circles with 0 tol at RFS will probably always show at least one circle of the set out of tol since there is no fit to bring all the circles of the set to 0 deviation. (Also true of set of cylinders.)
2.   True position of a cylinder requires that the primary datum be a cylinder at material condition.  Else with a primary plane, there is no math fit to zero the deviation of the two end points of the considered cylinder.
<<END>>
<< Changes made by Tim Wernicke -- 02/23/09  10:01:05>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Stop Rel.
<<END>>

huangyhg

double get_dimension_percentage(CPCDpart_program *m_pPartProgram, double deviation,
   
if( (DOUBLE_DIM_EQ(dimDispTol, dimPlusTol)) && (DOUBLE_DIM_EQ(dimDispTol, 0.)) ) // PR260010
      percentage = 0.;