Tk 104660 Redesign the location dimension dialog so the axes are all in one

huangyhg

Redesign the location dimension dialog so the axes are all in one row and the +/- tolerance fields directly behind it.
<< Don Turcotte  --  08/15/08  13:36:36>>
This is for ER 504220.
<<END>>
<< Don Turcotte  --  08/15/08  13:36:09>>
From Werner H.
"If possible please add a data grid.
"
<<END>>


<< Changes made by Don Turcotte -- 10/22/08  16:48:32>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  10/22/08  16:46:43>>
Fixed bugs 1,2 listed below.  Also fixed problem with initialization of >> button.
Reviewed Jared's documentation.  Looks good.
Files inserted to server
------------------------
V44B\MENU\DIMLOCDL.CPP
<<END>>
<< Jared Hess  --  10/18/08  12:47:39>>
Passing this back to you since I made the changes you recommended in the documentation topics you specified. Let me know if there's anything else needed.
<<END>>
<< Changes made by Jared Hess -- 10/18/08  12:47:41>>
Action:  Jared Hess to Don Turcotte, Status:  MOREINFO to OPEN
<<END>>
<< Don Turcotte  --  10/17/08  17:28:56>>
In further testing I found two more problems:
1.  Location dialog grid when feature is cone gives wrong nominal length (L axis)
2.  Editing an existing Location dimension corrupts the summary mode edit window command.  The command mode edit window command is ok.
<<END>>
<< Don Turcotte  --  10/16/08  13:36:00>>
Reviewed Jared's documentation and sent e-mail:
"Jared,
I have reviewed the documentation for Task # 104660 (add a grid to the Location dimension dialog).  In the section on (or maybe a new section to show the grid and discuss the options?)
   Tolerances for Location dimensions
    2) New method ?use the expanding grid

We should add that the user can also select which axes to report by using the grid as well as entering dimension nominals for each axis (previously this could only be done from the edit window).  In addition to changing dimension nominals on the grid, the user can select (via ?pdate Feature Nominal?checkbox) that the feature nominal be changed as well.  This basically follows the format of the grid on the advanced tab of the FCF dialog.

To see the grid, select a feature and press the >> button.




In a separate issue, on the page for Dimensioning Location there is a box which explains the difference between legacy and FCF form dimensions.  We should add here that for V44 the FCF form dimensions using a Chebychev algorithm include flatness and straightness.

"
<<END>>
<< Jerry Naylor  --  10/16/08  10:51:30>>
I have made some changes with Mike's help to get this working.
<<END>>
<< Don Turcotte  --  10/15/08  17:34:05>>
Jared,
I cannot get to the .htm file you listed below to check the documentation.  Could you please verify the address>
<<END>>
<< Changes made by Don Turcotte -- 10/15/08  17:34:16>>
Action:  Don Turcotte to Jared Hess, Status:  OPEN to MOREINFO
<<END>>
<< Don Turcotte  --  10/15/08  17:33:04>>
I have fixed the problem of the crash when editing a location dimension with the status window open.  I also fixed some other minor update problems.
Files inserted to server
------------------------
V44B\MENU\BASEDLG.CPP
V44B\MENU\DIMLOCDL.CPP
<<END>>
<< Jared Hess  --  10/14/08  12:39:41>>
Documentation Note: This is now documented in the "Tolerances for Location Dimensions" topic in the v44 beta help. Please review the topic and let me know if anything should be modified.
http://10.57.112.13/WAIhelp/Core/19_dimen_topics/Tolerances_for_Location_Dimensions.htm
<<END>>
<< Don Turcotte  --  10/14/08  17:16:41>>
I have fixed #5. -- added V axis to grid of Location dimension.
There still is a crash when editing an existing Location dimension with the Status window displayed.  I am looking for this problem.
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\DIMLOCDL.H
V44B\INCLUDE\FEATCTRLFRM.H
V44B\INCLUDE\PCDSCHEMA.H
V44B\INCLUDE\resource.h
V44B\MENU\DIMLOCDL.CPP
V44B\RESOURCE\LANGS\ENGLISH\RESOURCE.RC
<<END>>
<< Don Turcotte  --  10/09/08  17:24:47>>
Problems noted by Mike and myself during testing:
1.  When the status window is displayed, the grid is blank.
2.  Selecting/deselecting axes on the grid does not select/deselect axes on the main dialog.
3.  Moving the dialog, then close the grid, the dialog is sized incorrectly so the grid button is no longer visible.
4.  F9 on existing location dimension with the status window displayed causes crash.
5.  V axis not included on grid.
I have fixed 1 through 4, but still have crash when editing an existing location dimension with the status window displayed and select Create.
Files inserted to server
------------------------
V44B\DIMENS\START_LO.CPP
V44B\INCLUDE\DIMLOCDL.H
V44B\MENU\DIMLOCDL.CPP

<<END>>
<< Changes made by Don Turcotte -- 10/09/08  17:25:04>>
Action:  CMM Group to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Don Turcotte -- 09/08/08  08:17:17>>
Action:  Don Turcotte to CMM Group, Status:  CODING to REVIEW
<<END>>
<< Don Turcotte  --  09/04/08  16:26:36>>
I have this all working now.  Just need to do more testing and possible re-factoring of the code.
I have uploaded my latest changes.
Files inserted to server
------------------------
V44B\DIMENS\START_LO.CPP
V44B\INCLUDE\DIMLOCDL.H
V44B\MENU\DIMLOCDL.CPP
<<END>>
<< Don Turcotte  --  09/03/08  17:20:03>>
Continuing to hook up the grid data with the creation of the dimensions.  Working on "Nominals" and "Update Features".
<<END>>
<< Don Turcotte  --  09/02/08  17:24:03>>
I have the grid hooked up now so I can create Location dimensions with axes based on the "Report" checkbox settings.  I still have to hook up the "Nominals" and "Update Features" columns which are not on the main dialog.
I have uploaded what I have done so far.
<<END>>
<< Don Turcotte  --  08/28/08  17:38:26>>
I have begun implementing the grid. Selecting features on the Location dialog will now display the grid data.  
I have uploaded the changes that I have made so far.
Files inserted to server
------------------------
V44B\INCLUDE\DIMLOCDL.H
V44B\INCLUDE\FCFGridCtrl.h
V44B\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V44B\MENU\DIMLOCDL.CPP
V44B\RESOURCE\LANGS\ENGLISH\RESOURCE.RC
<<END>>
<< Don Turcotte  --  08/27/08  17:24:37>>
I have implemented the changes to the location dialog to allow it to expand/contract in order to display the grid.  I have uploaded these resource changes.  Now I am working on the code to populate the grid.
Files inserted to server
------------------------
V44B\INCLUDE\DIMLOCDL.H
V44B\INCLUDE\resource.h
V44B\MENU\DIMLOCDL.CPP
V44B\MENU\PCDLRN.CPP
V44B\RESOURCE\LANGS\ENGLISH\RESOURCE.RC
<<END>>
<< Changes made by Don Turcotte -- 08/27/08  17:24:37>>
Status:  DESIGN to CODING, Priority:  to Critical
<<END>>
<< Don Turcotte  --  08/26/08  17:23:51>>
Implementing code/resource changes to make the dialog expandable to accomodate the grid.
<<END>>
<< Don Turcotte  --  08/20/08  17:28:41>>
Looking at allowing the Location dimension dialog to expand/contract to display/hide the grid control rather than have a separate pop-up dialog.  This would work like the Advanced button on other dialogs (e.g., auto feature dialog).
<<END>>
<< Don Turcotte  --  08/15/08  17:28:01>>
I have been looking into the implementation for this and have attached a preliminary design document.
<<END>>

huangyhg

V44B\MENU\DIMLOCDL.CPP

void CDimLocDlg::OnGridButton() // 104660
{
  m_bGridOn ^= TRUE;
  CWnd * pGridButton = GetDlgItem(IDC_DIM_LOC_GRID_BUTTON);
  if( pGridButton )
    pGridButton->SetWindowText(m_bGridOn ? L"<<" : L">>");
  SetupGridWindow();
}

void CDimLocDlg::SetupGridWindow()
{
  if( m_bGridOn )
  {
    SetWindowPos(NULL, 0,0, m_fullDialog.Width(), m_fullDialog.Height(), SWP_NOMOVE|SWP_NOZORDER);
  }
  else
  {
    CWnd *gridbox = GetDlgItem(IDC_DIM_LOC_GRID_GROUP_BOX);
    if (gridbox)
    {
      CRect grid;
      gridbox->GetWindowRect(&grid);
      SetWindowPos(NULL, 0,0, m_fullDialog.Width(), grid.top - m_fullDialog.top, SWP_NOMOVE|SWP_NOZORDER);
    }
  }
}