PR260254 Form graphic contains weird lines, lines LINES! Circularity, straig

huangyhg

Form graphic contains weird lines, lines LINES!  Circularity, straightness what else? GRAPH=ON dimension
<< Bob Hospadaruk  --  03/05/09  09:59:53>>
Look at the uploaded picture. See all those green lines everywhere?  Please make them go away.
Has something to do with form dimensions with GRAPH=ON
<<END>>


<< Don Turcotte  --  03/09/09  15:46:39>>
Merged into V432.
Files inserted to server
------------------------
V432\DIMANALYSIS ACTIVEX\GraphicalAnalysis.CPP
V432\DIMENS\GraphicalAnalysis.CPP
V432\DLL\DIMANALYSIS ACTIVEX D.OCX
V432\DLL\DIMANALYSIS ACTIVEX.OCX
V432\DLL\DIMANALYSIS ACTIVEX.pdb
<<END>>
<< Changes made by Don Turcotte -- 03/09/09  15:46:56>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  03/09/09  14:07:49>>
Hi Don, please go ahead in V432 as well.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 03/09/09  14:07:54>>
Action:  Tim Wernicke to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Changes made by Don Turcotte -- 03/09/09  14:02:50>>
Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  03/09/09  13:59:54>>
Fixed in V44B.  
The multiplier factor is ignored when drawing the + signs.
Files inserted to server
------------------------
V44B\DIMANALYSIS ACTIVEX\GRAPHICALANALYSIS.CPP
V44B\DIMENS\GraphicalAnalysis.CPP
V44B\DLL\DIMANALYSIS ACTIVEX D.OCX
V44B\DLL\DIMANALYSIS ACTIVEX.OCX
V44B\DLL\DIMANALYSIS ACTIVEX.pdb
<<END>>
<< Bob Hospadaruk  --  03/09/09  13:48:37>>
Tim - Don said the change was "easy".  Can he merge into v432?  This is serious graphical reporting issue for precision form plots.
<<END>>
<< Changes made by Bob Hospadaruk -- 03/09/09  13:48:55>>
Action:  Don Turcotte to Tim Wernicke
<<END>>
<< Don Turcotte  --  03/09/09  11:26:14>>
Talked with Bob about this.  Customer has parts with very small tols, so they use a large MULT.  So points have deviations close to zero which results in very large + signs on graphical plot.
I will change this so + signs are always drawn with using MULT factor.  This way + signs will always be the same size.
<<END>>
<< Changes made by Don Turcotte -- 03/09/09  11:26:24>>
Action:  Bob Hospadaruk to Don Turcotte, Status:  RESOLVED to OPEN
<<END>>
<< Don Turcotte  --  03/06/09  11:37:43>>
The problem here is that all these form dimensions have MULT=500.00, probably because this multiplier value was used in another program and is now the default.  Since this is a newly created program there are no point deviations, so PC-DMIS draws a plus sign (+) at each point (+ signs are always drawn at points were there is 0 deviation).  With a MULT of 500 these are drawn as enormous plus signs.  If you set the MULT to something small such as 10 (or even 1), then the graphical analysis will look ok.  
I suppose we could modify PC-DMIS so the plus signs are drawn ignoring the MULT factor so the plus signs would always be small.  This would have to be done for all the form types. I don't think this is a Critical issue.
I did find another problem trying to execute this program "online" with the simulator -- in V44B PC-DMIS crashes.  I have submitted PR#260304 concerning this.
<<END>>
<< Changes made by Don Turcotte -- 03/06/09  11:38:04>>
Action:  Don Turcotte to Bob Hospadaruk, Status:  OPEN to RESOLVED
<<END>>
<< Changes made by Tim Wernicke -- 03/05/09  09:18:59>>
Category:  graphics to analysis, Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

void CGraphicalAnalysis:imDrawHit(PDRAWPARAMS pDrawParams,double* point, double* vector, double size,BOOL DrawArrow)
{
if( m_bSendToDisplay )
{
GRAPHELEM dl;

if( m_arrow_mult != 0.0 )
size /= m_arrow_mult; // PR260254 - always draw the hit point the same size regardless of multiplier

dl = draw_hit(pDrawParams, point, vector, size,(DrawArrow?true:false));
if(!dl)
{
AfxThrowUserException();
}