PR 259860 dimension decimal of FCF can't follow the default decimal value o

huangyhg

dimension decimal of FCF can't follow the default decimal value of F5 setting

<< Jean Wang  --  02/18/09  12:05:25>>
Dimension decimal of FCF can't follow the default decimal value of F5 setting, only the location dimension works fine in FCF, I tried TP,perpendicualrity and concentricity and some others, they are wrong,see the file fcf_dim.rar.
<<END>>

<< Don Turcotte  --  03/02/09  16:56:36>>
Created Task #105473 to fix the V44B resource file.
<<END>>
<< Changes made by Don Turcotte -- 03/02/09  16:57:39>>
Status:  OPEN to CLOSED
<<END>>
<< Don Turcotte  --  02/23/09  09:55:48>>
Uploaded source code fix for V44B.  However, still need resource.rc fix.  I uploaded the source code fix so that when the resource file is fixed, the testing group can verify that this problem is resolved.
Files inserted to server
------------------------
V44B\MENU\PCDMIVW.CPP
<<END>>
<< Changes made by Tim Wernicke -- 02/20/09  11:55:52>>
Priority:  Stop Rel. to Critical
<<END>>
<< Don Turcotte  --  02/19/09  16:18:58>>
I tracked this to a problem in CPcdmislView::Gen3DLists(...).  I modified the logic to agree with what is done in similar cases in SOURCE\Archgvar.cpp.
V44B also has a resource.rc problem.  The tab order on the “Number of decimal places” radio buttons on the Dimension Setup dialog is incorrect.  This means that the wrong radio button is turned on when you load a program.  For example, the radio button for 2 places is lit when in fact 3 places are being used.
I have uploaded the code fix for V432 to resolve the Stop Release issue.
I have not uploaded anything for V44B, pending approval to upload the fixed resource.rc.  
The priority of this PR can be reduced to Critical but should remain open pending approval to upload to V44B.

Files inserted to server
------------------------
V432\MENU\PCDMIVW.CPP
<<END>>
<< Changes made by Tim Wernicke -- 02/19/09  14:47:16>>
Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte  --  02/18/09  17:19:53>>
The issue here is the initialization (or lack thereof) of CReportVar::iNumDecimalPlaces when the program is loaded.  This seems to get set only when a DISPLAYPRECISION command is used.  Also, legacy dimensions seem to do their own formatting whereas FCFs pass doubles to the report engine and expect the report engine to format number of decimal places correctly.
<<END>>
<< Changes made by Tim Wernicke -- 02/18/09  10:23:20>>
Category:  dimensions to GD&T, Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

void CPcdmislView::Gen3DLists(int List)
    // PR259860 - don't use Report5Places line unless "DimensionDecimalPlaces" not found
    CString KeyName;
    KeyName.LoadString(IDS_INI_DIM_DEC_PLACES);
    global_dim_decimal_places = PCDGetProfileInt(AppName, KeyName, -1);
    if (global_dim_decimal_places == -1)
    {   // couldn't find it, so try the Report5Places line
      global_dim_decimal_places = PCDGetProfileInt(AppName, _T("Report5Places"), 0);
      if (global_dim_decimal_places)
        global_dim_decimal_places = REPT5PLCS;
      else
        global_dim_decimal_places = REPT4PLCS;
    }
    CReportVar::iNumDecimalPlaces = global_dim_decimal_places;