PR 257172 Multiple Feature Control Frame cause system to slow

huangyhg

Multiple Feature Control Frame cause system to slow
<< Marc Stalker  --  09/22/08  02:00:27>>
The attached program has 289 circle which the customer wants to use a control feature to report. When this is created the program takes several minutes to refresh
Steps to reproduce:
Load attached program Marc.prg
Create a datum on the plane and circle 1
Create True Position Control frame for the 289 Features
Results:
Takes several minutes to create the control frame
Also move the cursor before the alignment which causes the editwindow to refresh again taking several minutes.
This makes the program un-usable
<<END>>


<< Jerry Naylor  --  12/31/08  15:26:15>>
wasaddedtoreadme44B
<<END>>
<< Marc Stalker  --  11/14/08  13:20:19>>
Tested in the latest beta, major improvement. Calculations took about 50 seconds. When you take into account what its doing I believe thats acceptable.
<<END>>
<< Changes made by Marc Stalker -- 11/14/08  13:20:34>>
Action:  Marc Stalker to Don Turcotte, Status:  RESOLVED to CLOSED
<<END>>
<< David Petrizze  --  10/13/08  08:43:56>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 10/13/08  08:44:00>>
Action:  CMM Group to Marc Stalker, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  10/09/08  11:01:21>>
Same problem in V44B must be changed in V43B.  Symptom in V43B is that after F9 on FCF to change, the change is not reflected in report after repaint of report.
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Don Turcotte  --  10/09/08  08:52:49>>
Found another problem in V44B.  Report was not being set up on program load.
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Don Turcotte  --  10/02/08  11:46:48>>
I have fixed this so it also works correctly with V44B while maintaining most of the speed improvements.
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\FEATCTRLFRM.H
V44B\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V44B\MENU\FEATCTRLFRMDLG.CPP
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 10/02/08  11:47:42>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  10/01/08  17:16:34>>
I have fixed V43B so it now works correctly again although I have lost some of the speed gains made previously.
These same changes do not work correctly with V44B since many other changes have been made to V44B for enhancements so I will have to continue to work on V44B.
Uploaded fixes only to V43B.
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V43B\MENU\FEATCTRLFRMDLG.CPP
V43B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Don Turcotte  --  09/30/08  15:30:13>>
I have made progress on this.  The updates are working correctly but there are still multiple calls to the math (although not as many as originally).  I have to work on a Stop Release issue so I am putting this aside for now.
<<END>>
<< Don Turcotte  --  09/25/08  17:21:12>>
I have found the change that is causing the update problem but I haven't figured out how to fix this without resulting in multiple calls to the math.
<<END>>
<< Don Turcotte  --  09/25/08  15:46:45>>
I have found a problem where doing and F9 on a true position FCF, then OK messes up the dimension nominals.  Use the program attached to PR#257250 to see this.  I have reopened this PR as a result.
<<END>>
<< Changes made by Don Turcotte -- 09/25/08  15:46:48>>
Action:  CMM Group to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Don Turcotte  --  09/24/08  13:26:00>>
I was able to create an FCF with 289 features using Marc's program in 46 seconds on my computer (3 gigahertz, 2 gig ram). I can also F9 to edit this FCF in about 20 seconds.
After I saved this program, I found that loading it took over 2 minutes.  This was not because the math was being called more than once but because of other code inefficiencies that I found and corrected using Glowcode.  I can now load this program containing a true position FCF with 289 features in about 1 minute.
I have verified that the math is called only once for each FCF during creation and editing.   Editing the dialog still works correctly with the changes that I have made.
Fixed in V43B, V44B.
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\MENU\FEATCTRLFRMDLG.CPP
V43B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\FEATCTRLFRM.H
V44B\MENU\FEATCTRLFRMDLG.CPP
V44B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 09/24/08  13:26:37>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  09/23/08  17:26:52>>
I have this working now but I need to do more testing to make sure this works for all types of creating and editing of the FCF.
<<END>>
<< Bill Velle  --  09/22/08  20:01:42>>
Don,
Let me know when you update the source.  I came across many instances where the same feature's graphics and label are created over & over.  I want to investigate that a little further when your changes are ready.  Just drop me an email - don't assigne the PR to me.  Thanks...
BV
<<END>>
<< Don Turcotte  --  09/22/08  17:17:04>>
I have fixed this so the math is called only once when a true position FCF is created or edited.  This has reduced the time to create a true position FCF with 289 holes from 3 minutes on my computer to about 46 seconds.
However, these changes have introduced other problems in updating an FCF.  In particular, when F9 on a true position FCF and change the output alignment from Datum reference frame to Current alignment or vice versa, the update is not performed.  I am working on resolving these issues with the changes I made to reduce the number of times the math is called.
<<END>>
<< Don Turcotte  --  09/22/08  11:40:57>>
This is not a graphics issue.  It is an issue of the true position math which is being called 4 times when the FCF is being created.
<<END>>
<< Changes made by Don Turcotte -- 09/22/08  11:41:01>>
Category:  graphics to dimensions, Action:  Bill Velle to Don Turcotte, Assigned:  Bill Velle to Don Turcotte
<<END>>
<< Changes made by Marc Stalker -- 09/22/08  14:57:57>>
Status:  MOREINFO to OPEN
<<END>>
<< Changes made by Tim Wernicke -- 09/22/08  08:37:25>>
Category:  dimensions to graphics, Action:  Tim Wernicke to Bill Velle, Assigned:  Don Turcotte to Bill Velle, Status:  MOREINFO to OPEN, Priority:  to Critical
<<END>>
<< Marc Stalker  --  09/22/08  14:30:10>>
Hi Tim,
I have tried with both settings, I have also tried on my 2 other computers all suffering from the same issue
<<END>>
<< Changes made by Marc Stalker -- 09/22/08  14:30:26>>
Action:  Marc Stalker to Tim Wernicke
<<END>>
<< Tim Wernicke  --  09/22/08  08:19:09>>
Have you verified that the Z-Buffer is set to 32-bit under OpenGL Settings?
If it already is, then you may want to adjust the value of "TextBoxMaximumActive" to a lower number.
<<END>>
<< Changes made by Tim Wernicke -- 09/22/08  08:19:18>>
Action:  Don Turcotte to Marc Stalker, Status:  OPEN to MOREINFO
<<END>>