PR 239837 Bonus refinement not being applied correctly.

huangyhg

Bonus refinement not being applied correctly.
<< Don Turcotte -- 04/13/06 13:55:55>>
When calculating the bonus on a datum, if there is a previous tp or orientation dimension on that datum feature, then the tp and/or orientation tolerance should be added to the datum bonus to calculate the virtual size of the datum. This is the GetFRTZFTolValue(...) method in FeatCtrlFrm.cpp. This method should be looking for previous FCF or legacy dimensions that have tp or orientation dimensions on the input feature. It is incorrectly looking at the line3 internal commands of the current FCF.
<<END>>


<< Changes made by Don Turcotte (Field Changes) -- 05/19/09  16:30:24>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Don Turcotte (Resolution Data) -- 05/19/09  16:30:03>>
** Bug Fix - New In Current Version -  -  -  **
<<END>>
<< Changes made by Don Turcotte (Field Changes) -- 05/19/09  16:29:45>>
Status:  RESOLVED to OPEN
<<END>>
<< Don Turcotte (Development Notes)  --  05/19/09  16:29:45>>
Now that #261818 has been fixed, I retested this and found a problem with V44B.  I have re-opened this for V44B.
When you first load the program and display the report, everything looks ok -- the size table shows the correct datum bonuses.  However, if you F9 on the perpendicularity FCF at the end of the program, change the tolerance and press OK to force a recalculation, then the report now shows the datum bonus as 0.010 instead of 0.013.  The datum bonus no longer reflects the full virtual condition of the datum.
I have fixed this in V44B.
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Tim Wernicke (Field Changes) -- 05/13/09  14:11:31>>
Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte (Development Notes)  --  05/13/09  11:04:31>>
Reviewed - Needs further testing.
This works in V432, but not with compound datums.  I can't test this in V44B since PC-DMIS crashes when trying to load the program.  I have filed #261818 about this.

<<END>>
<< Changes made by Yanhua Huang (Field Changes) -- 05/06/09  15:03:49>>
Status:  REVIEW to RESOLVED
<<END>>
<< Jared Hess -- 10/30/08 14:50:56>>
Thanks Don. I've modified these topics by adding in a "Bonus Refinement" subtopic with the info suggested:

In GD&T FCF section: http://10.57.112.13/WAIhelp/Core/feature_control_frames/Defining_Datums.htm
In Legacy Dimension section:
http://10.57.112.13/WAIhelp/Core/19_dimen_topics/Using_Datums.htm
Let me know if anything else is needed.
<<END>>
<< Changes made by Jared Hess -- 10/30/08 14:51:26>>
Action: Jared Hess to Don Turcotte, Status: DOCUMENT to REVIEW
<<END>>
<< Don Turcotte -- 10/29/08 08:10:58>>
Jared,
I would add the following:
"When calculating the bonus on a datum, if there is a previous tp or orientation dimension on that datum feature, then the tp and/or orientation tolerance is added to the datum bonus to calculate the virtual size of the datum.""
<<END>>
<< Changes made by Don Turcotte -- 10/29/08 08:11:30>>
Action: Don Turcotte to Jared Hess, Status: MOREINFO to DOCUMENT
<<END>>
<< Jared Hess -- 07/23/08 12:42:31>>
Don, could you please let me know what I should add to the help file per Paola's recommendation here? Should I massage this sentence of yours from the description abvoe, and put that in the documentation?
"When calculating the bonus on a datum, if there is a previous tp or orientation dimension on that datum feature, then the tp and/or orientation tolerance should be added to the datum bonus to calculate the virtual size of the datum."
Or is something else needed. I don't have access to the ASME standard. Thanks.
<<END>>
<< Changes made by Jared Hess -- 07/23/08 14:18:57>>
Action: Jared Hess to Don Turcotte
<<END>>
<< Changes made by Jared Hess -- 07/23/08 12:42:34>>
Status: DOCUMENT to MOREINFO
<<END>>
<< Changes made by Neil Kay -- 07/22/08 18:54:10>>
Action: Bret Naylor to Jared Hess, Status: REVIEW to DOCUMENT
<<END>>
<< Don Turcotte -- 05/16/06 09:20:00>>
Please also see "ASME Y14.5M-1994 Dimensioning and Tolerancing" section 4.5.4 Specifying Datum Features at MMC. In particular, section 4.5.4.2 Size of a Secondary or Tertiary Datum Feature and section 2.11.1 Virtual Condition.
<<END>>
<< Paola Pallo -- 05/16/06 12:00:46>>
Reviewed.
Perhaps adding some notes in the online documentation should be useful.
<<END>>
<< Changes made by Paola Pallo -- 05/16/06 12:00:57>>
Action: Paola Pallo to Bret Naylor
<<END>>
<< Don Turcotte -- 04/20/06 10:06:26>>
Fixed in V41B and V42. Attached test program.
Files inserted to server
------------------------
V41B\DIMENS\DATUMREF.CPP
V41B\DIMENS\DIM_PROF.CPP
V41B\DIMENS\FEATCTRLFRM.CPP
V41B\DIMENS\XactOrientation.cpp
V41B\INCLUDE\DATUMREF.H
V41B\INCLUDE\FEATCTRLFRM.H
V41B\INCLUDE\XactOrientation.h
V41B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V42\DIMENS\DATUMREF.CPP
V42\DIMENS\DIM_PROF.CPP
V42\DIMENS\FEATCTRLFRM.CPP
V42\DIMENS\XactOrientation.CPP
V42\INCLUDE\DATUMREF.H
V42\INCLUDE\FEATCTRLFRM.H
V42\INCLUDE\XactOrientation.H
V42\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/20/06 10:06:31>>
Action: Don Turcotte to Paola Pallo, Status: OPEN to REVIEW
<<END>>
<< Don Turcotte -- 04/20/06 09:35:41>>
I have fixed the problem (#1 below) with the +/- tols on the size of the datum not being remembered. The problem (#2 below) with the perpendicularity was because I had mistakenly used a plane which was parallel to the datum. I have corrected my test program and attached it to this PR.
I will upload the files as soon as the Wilcox server comes back online.
<<END>>
<< Don Turcotte -- 04/19/06 17:41:35>>
I have this working now for true position , profile and orientation (perpendicularity, parallelism, angularity). I still see two problems :
1. Profile FCFs don't remember the +/- tols on the size of the datums. When you save and reload a program, the report shows that the datum size +/- tols are 0.0. If you F9 on the profile FCF and go to advanced page and look at the axes for the considered feature, the datum axis has correct size tols. Pressing OK and repainting the report now shows the correct +/- size tols. The refinement to the bonus is always correct since this is found dynamically and not serialized.
2. Perpendicularity result is incorrect although bonus on datum is correct. Datum size tols are remembered and refinement is correct.
<<END>>
<< Don Turcotte -- 04/18/06 17:41:15>>
I now have this completely working for true position dimensions. I am looking at profile and orientation dimensions.
<<END>>
<< Don Turcotte -- 04/13/06 17:24:44>>
I have made changes to GetRefinementTolValue(...) as a result of debugging and will continue to test next week.
<<END>>
<< Don Turcotte -- 04/13/06 15:00:34>>
Rob Jensen called me about this. I had forgotten that we were doing this, but when I looked at the code I realized it was not working. Also, Jan DeNijs of Lockheed has requested this for PC-DMIS NC. He was here at B&S this week for training and talked to me this morning about implementing this.
I have rewritten GetFRTZFTolValue(...) which was completely wrong and renamed it GetRefinementTolValue(...). I will test my changes later. Tim wants me to look at another problem right now.
<<END>>

huangyhg

// PR239837 - <19May2009>
      if( p1->is_dimension() )
      {
        if(!m_line2DatA_ID.IsEmpty()) // dimension has datums
          p1->sequence = 0; // redo math to create datum reference frame which is not serialized
      }