PR 256922 Profile: Form Only (Legacy & XactMeasure) report Out of Tol

huangyhg

Profile: Form Only (Legacy & XactMeasure) report Out of Tolerance incorrectly when MAX and MIN deviations are both negative values.
<< Rob Jensen  --  09/05/08  15:36:17>>
Profile: Form Only (Legacy & XactMeasure) reports Out of Tolerance incorrectly when MAX and MIN deviations are both negative values.
This causes the MEAS value to be a negitive value and is reported Out of Tolerance because Form Only only allows a positive tolerance to be entered. There is no work around.

Steps to reproduce:
See attached program for example. Don Turcott has the example files and we have discussed the problem in detail.
Results:
New and migrated programs will report Profile Form Only dimensions Out ofTolerance (when MEAS is negative) when they are not Out of Tolerance.  This needs to be fixed in 4.3MR1 or many customers will have to stay on 4.2MR1.
Expected Results:
Report all out of Tolerance conditions correctly
<<END>>
<< Changes made by Rob Jensen (Field Changes) -- 04/30/09  21:59:00>>
Action:  Rob Jensen to Rex Heagy, Status:  RESOLVED to CLOSED
<<END>>
<< Rob Jensen (Customer Notes)  --  04/30/09  21:58:56>>
Tested in 4.3MR1 - fixed
Thanks Don
<<END>>
<< Jared Hess (Development Notes)  --  04/09/09  08:25:48>>
This has been addedtoreadme for v44 (or ignored if internal item).
<<END>>
<< Rex Heagy  --  02/25/09  08:22:04>>
Reviewed.
<<END>>
<< Changes made by Rex Heagy -- 02/25/09  08:22:08>>
Action:  CMM Group to Rob Jensen, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  11/04/08  13:30:39>>
The m_form_and_loc flag was not initialized correctly on the lower segment.
Fixed in V431, V43B, V44B.
Files inserted to server
------------------------
V431\DIMENS\DIM_PROF.CPP
V43B\DIMENS\DIM_PROF.CPP
V44B\DIMENS\DIM_PROF.CPP
<<END>>
<< Changes made by Don Turcotte -- 11/04/08  13:31:20>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Rob Jensen  --  10/31/08  16:19:37>>
Look at the original attached program Xact_Profile FCFPROF2 the lower segment of the composite (.010 to A). It shows out of tolerance until you F9 the command (executing the program didn't update).
<<END>>
<< Rob Jensen  --  10/31/08  16:07:02>>
This is t resolved in 4.3MR1rc build 10-28-08 however when I executed the original program the results were still wrong. When I F9 the command it updated the results and they look good. I don't think we should need to F9 the command for the change to be effective.
<<END>>
<< Changes made by Rob Jensen -- 10/31/08  16:07:48>>
Action:  Rob Jensen to Don Turcotte, Status:  REVIEW to OPEN
<<END>>
<< Don Turcotte  --  10/21/08  15:27:38>>
The issue here is that the changes for 252089 (Composite Surface profile does not evaluate lower frame correctly) were never merged into V431.  I have now merged them into V431 in response to this issue.
Files inserted to server
------------------------
V431\DIMENS\FEATCTRLFRM.CPP
V431\INCLUDE\FEATCTRLFRM.H
<<END>>
<< Changes made by Don Turcotte -- 10/21/08  15:29:28>>
Action:  Don Turcotte to Rob Jensen, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Don Turcotte -- 10/20/08  16:00:07>>
Status:  REVIEW to OPEN
<<END>>
<< Rob Jensen  --  10/20/08  14:12:03>>
Note: this occurs in the 10-2-08 4.3MR1RC build. Legacy and Xact both are fixed for Form Only. The lower segment of Xact Composite is the problem (Xact_Profile.zip).
<<END>>
<< Rob Jensen  --  10/20/08  14:08:33>>
The lower segmant of an XactMeasure Profile is reporting out fo tolerance when results are not out of tolerance (see attaced files)
<<END>>
<< Changes made by Rob Jensen -- 10/20/08  14:09:16>>
Action:  CMM Group to Don Turcotte
<<END>>
<< Don Turcotte  --  09/17/08  17:08:42>>
I also discovered a problem with the linear graphic for both legacy and FCF profiles when formonly is selected.  I have fixed this in V431 (V43 MR1), V43B, V44B.
Files inserted to server
------------------------
V43B\DIMENS\DIM_PROF.CPP
V43B\INCLUDE\DIM_PROF.H
V43B\MENU\DIMENSIO.CPP
V431\DIMENS\DIM_PROF.CPP
V431\INCLUDE\DIM_PROF.H
V431\MENU\DIMENSIO.CPP
V44B\DIMENS\DIM_PROF.CPP
V44B\INCLUDE\DIM_PROF.H
V44B\MENU\DIMENSIO.CPP
<<END>>
<< Don Turcotte  --  09/10/08  09:04:04>>
Fixed in V431 (V43 MR1), V43B, V44B
1.  For form only (legacy & xactmeasure), the outtol is based on max/min (except when the considered feature is a plane or line type feature).
2.  For form only, if both the max and min are negative, the MEAS and DEV are reported as a positive value.

Files inserted to server
------------------------
V431\DIMENS\BASIC_DI.CPP
V431\DIMENS\DIM_PROF.CPP
V431\DIMENS\FEATCTRLFRMUTIL.CPP
V431\INCLUDE\BASIC_DI.H
V431\INCLUDE\DIM_PROF.H
V431\INCLUDE\FEATCTRLFRMUTIL.H
V431\INCLUDE\GLOBALS.H
V431\MENU\DIMENSIO.CPP
V43B\DIMENS\BASIC_DI.CPP
V43B\DIMENS\DIM_PROF.CPP
V43B\DIMENS\FEATCTRLFRMUTIL.CPP
V43B\INCLUDE\BASIC_DI.H
V43B\INCLUDE\DIM_PROF.H
V43B\INCLUDE\FEATCTRLFRMUTIL.H
V43B\INCLUDE\GLOBALS.H
V43B\MENU\DIMENSIO.CPP
V44B\DIMENS\BASIC_DI.CPP
V44B\DIMENS\DIM_PROF.CPP
V44B\INCLUDE\BASIC_DI.H
V44B\INCLUDE\DIM_PROF.H
V44B\INCLUDE\PCDSCHEMA.H
V44B\MENU\DIMENSIO.CPP
<<END>>
<< Changes made by Don Turcotte -- 09/10/08  09:06:59>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  09/09/08  17:18:10>>
I have made two fixes here:
1.  For form only (legacy & xactmeasure), the outtol is based on max/min (except when the considered feature is a plane or line type feature).
2.  For form only, if both the max and min are negative, the MEAS and DEV are reported as a positive value.
I will finish testing and upload tomorrow.
<<END>>
<< Changes made by Tim Wernicke -- 09/08/08  08:55:50>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Stop Rel.
<<END>>