PR 246674 Angle dimensions not recognizing the sign when angle is either side

huangyhg

Angle dimensions not recognizing the sign when angle is either side of zero degrees
<< Neil Ryan  --  02/15/07  15:10:39>>
Please see attached program.
Please note the vectors of the generic line:
                           ,The Nominal is the opposite sign to the measured
                           ,Yet the dimensions do not differentiate between the sign
For example: If a face is supposed to be machined with an angle of -0.5 degrees, but there is an error in the machining setup and it has been machined at 0.5 degrees, we need pcdmis to show an error of 1degree in the dimension.
Steps to reproduce:
Follow steps explained in program.
Create dimensions: Insert, Dimensions, Angle
Dimension 1 : Created without entering Nominal value in Angle box
Dimension 2 : Created with entering Nominal value of +1 in Angle box
Dimension 3 : Created with entering Nominal value of -1 in Angle box
Results:
Measured Angle sign has changed to match that of Nominal!
Expected Results:
Pcdmis to differeniate the sign of the angle
<<END>>

<< Changes made by Yanhua Huang (Field Changes) -- 05/19/09  16:17:33>>
Action:  Wade Burton to Yanhua Huang
<<END>>
<< Wade Burton  --  08/07/08  18:04:11>>
Reviewing.  Need to ask some questions still, since this has been a complicated area in the past.
<<END>>
<< Changes made by Neil Kay -- 07/23/08  10:54:07>>
Action:  David Petrizze to Wade Burton
<<END>>
<< Paola Pallo  --  03/07/07  16:01:36>>
Done. For review:
------------------------
V42R\DIMENS\DIM_2D_A.CPP
V42R\DIMENS\DIM_3D_A.CPP
<<END>>
<< Changes made by Paola Pallo -- 03/07/07  16:01:54>>
Action:  Paola Pallo to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  03/07/07  08:12:44>>
Hi Paola, could you please merge your changes into V42R per our Skype?  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 03/07/07  08:12:49>>
Action:  David Petrizze to Paola Pallo, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Neil Ryan  --  03/07/07  11:33:41>>
This has been tested and verified the 42 Beta dated 7th March.
Could this be implemented in the release code now?
Thanks,
Neil
<<END>>
<< Neil Ryan  --  03/02/07  08:11:47>>
I have emailed Tim asking that the priority of this be Stop release due to the fact that  Pcdmis is giving incorrect measurement results.
Neil
<<END>>
<< Paola Pallo  --  03/01/07  17:43:48>>
Fixed in v42B and v43B.
Dimension Angle do_math() repeatedly changed in past months to fix different bad situations( see 238599,235967,238753), so the calculation became complicated , but evidently not still completely ok.
To summarize : 'True/complement' toggle is no more supported , and PC-DMIS is internally calculating all four possible angles. Then it gives the meas value closer to the nominal: it should  choose this angle between the supplementary angles ( adiancent angles having sum equal to 180 degrees) , and I fixed a bug in this choice.
I also verified that the issues 238599,235967 and 238753 are still working fine.
For review :
------------------------
V42\DIMENS\DIM_2D_A.CPP
V42\DIMENS\DIM_3D_A.CPP
V43B\DIMENS\DIM_2D_A.CPP
V43B\DIMENS\DIM_3D_A.CPP

<<END>>
<< Changes made by Paola Pallo -- 03/01/07  17:44:56>>
Action:  Paola Pallo to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Paola Pallo  --  02/28/07  17:45:56>>
Thanks for the additional example .
I added a fix, that works fine for the generic line, but I'm still testing it with other feature types.
I will upload tomorrow.
<<END>>
<< Neil Ryan  --  02/28/07  07:57:15>>
Paola,
I have a program that highlights the problem with measured features too.
The program measures an angle bar of 1deg. When we turn the angle bar round to replicate a machining error, and re execute the program. The measured angle dimension flips the sign.
I am offsite at the moment, but I will contact one of my colleagues to upload the program.
Neil ryan
<<END>>
<< Paola Pallo  --  02/27/07  18:18:11>>
Resuming the activity.
It seems to me that this is a very specific case that is causing trouble to the angle calculation since theo and meas of the feature don't belong to the same quadrant.
Investigating.
<<END>>
<< Paola Pallo  --  02/19/07  17:40:55>>
Started the analysis.
<<END>>
<< Changes made by Tim Wernicke -- 02/15/07  10:13:24>>
Action:  Tim Wernicke to Paola Pallo
<<END>>
<< Neil Ryan  --  02/15/07  15:29:47>>
I've uploaded the probe file as well.
Neil
<<END>>
<< Changes made by Neil Ryan -- 02/15/07  15:30:24>>
Status:  MOREINFO to OPEN
<<END>>
<< Changes made by Neil Ryan -- 02/15/07  15:30:16>>
Action:  Neil Ryan to Tim Wernicke
<<END>>
<< Tim Wernicke  --  02/15/07  09:24:17>>
OK.
<<END>>
<< Changes made by Tim Wernicke -- 02/15/07  09:24:20>>
Action:  Tim Wernicke to Neil Ryan
<<END>>
<< Neil Ryan  --  02/15/07  15:21:43>>
Hopefully it should be upload now.
Neil
<<END>>
<< Neil Ryan  --  02/15/07  15:17:51>>
Hi Tim,
I'm having problems uploading the file, I keep getting an error message. I will try again in a bit.
Neil
<<END>>
<< Changes made by Neil Ryan -- 02/15/07  15:18:01>>
Action:  Neil Ryan to Tim Wernicke
<<END>>
<< Tim Wernicke  --  02/15/07  09:14:36>>
Nothing attached.
<<END>>
<< Changes made by Tim Wernicke -- 02/15/07  09:14:46>>
Action:  Tim Wernicke to Neil Ryan, Assigned:   to Paola Pallo, Status:  OPEN to MOREINFO, Priority:  to Critical
<<END>>