PR 254246 - FCF report shows negative bonus on tertiary datum

huangyhg

<< Don Turcotte  --  04/07/08  11:19:42>>
In attached program, FCF at end of program shows a -0.137 bonus on tertiary datum in report.  Datum bonus should never be less than 0.0.   Resulting TP deviation on CIR_H of 0.043 is suspect since unfitted deviation is 0.144 and datums don't appear to have enough bonus to reduce fitted TP deviation of CIR_H to 0.043.

Steps to reproduce:
Load attached program in V43R and look at report for last FCF in program.
<<END>>

huangyhg

<< Don Turcotte  --  05/19/08  13:11:06>>
Restore original code for setting the TOL field in the "osition" table for datums of size.  The TOL field in the "osition" table reports any preceding TP or Orientation Tol on the datum feature.

Restored in V42 beta, V42R, V43R, V431, V43B, V44B.


Files inserted to server
------------------------
V42R\DIMENS\FEATCTRLFRM.CPP
V43B\DIMENS\FEATCTRLFRM.CPP
V43R\DIMENS\FEATCTRLFRM.CPP
V431\DIMENS\FEATCTRLFRM.CPP
V44B\DIMENS\FEATCTRLFRM.CPP
V42\DIMENS\FEATCTRLFRM.CPP
<<END>>

<< Don Turcotte  --  04/23/08  10:35:13>>
Merged into V42R per Tim's request.

Files inserted to server
------------------------
V42R\DIMENS\FEATCTRLFRM.CPP
V42R\INCLUDE\FEATCTRLFRM.H
V42R\XACTGEOMETRYMATH\DATUMMINIMIZATION.CPP
V42R\NETDLL\XactGeometryMath.dll
V42R\NETDLL\XactGeometryMathD.dll
V42R\NETLIB\XactGeometryMath.lib
V42R\NETLIB\XactGeometryMathD.lib
<<END>>

<< David Petrizze  --  04/22/08  03:46:25>>
Reviewed.
<<END>>

<< Changes made by David Petrizze -- 04/22/08  03:46:30>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>

<< Don Turcotte  --  04/16/08  09:57:38>>
Merged into V43R.

Files inserted to server
------------------------
V43R\DIMENS\FEATCTRLFRM.CPP
V43R\INCLUDE\FEATCTRLFRM.H
V43R\XACTGEOMETRYMATH\DATUMMINIMIZATION.CPP
V43R\NETDLL\XactGeometryMath.dll
V43R\NETDLL\XactGeometryMathD.dll
V43R\NETLIB\XactGeometryMath.lib
V43R\NETLIB\XactGeometryMathD.lib
<<END>>

<< Changes made by Don Turcotte -- 04/16/08  09:58:18>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>

<< Tim Wernicke  --  04/15/08  13:30:45>>
Please merge with V43R.  Thanks.
<<END>>

<< Changes made by Tim Wernicke -- 04/15/08  13:30:51>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>

<< Don Turcotte  --  04/14/08  16:59:42>>
In continuing to test, I found a significant problem here.  The fitter is allowing too much rotation when the planar zone on the tertiary is in Z (as in this program).  This error also resulted in the remaining bonus for the tertiary being miscalculated and the graphic in the report "osition" table for the tertiary being drawn incorrectly.  I have fixed this problem in datumminimization.cpp. This was a simple typo but with serious consequences.  This problem applies to any datum which has a planar zone in Z applied.  THIS SHOULD BE A STOP RELEASE ISSUE.

I also fixed the FCF report for the datums in the "osition" table.  The TOL field now shows the total available bonus for the datums.  The BONUS field in the "osition" table shows the remaining datum bonus after fitting and the DEV field shows the amount of bonus that was used  (this is unchanged from previous versions).  This was fixed in FeatCtrlFrm.cpp.

These fixes have been uploade to V42 beta, V43B, V44B.

Files inserted to server
------------------------
V42\DIMENS\FEATCTRLFRM.CPP
V42\INCLUDE\FEATCTRLFRM.H
V42\XACTGEOMETRYMATH\DATUMMINIMIZATION.CPP
V42\NETDLL\XactGeometryMath.dll
V42\NETDLL\XactGeometryMathD.dll
V42\NETLIB\XactGeometryMath.lib
V42\NETLIB\XactGeometryMathD.lib

V43B\DIMENS\FEATCTRLFRM.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\XACTGEOMETRYMATH\datumminimization.cpp
V43B\NETDLL\XactGeometryMath.dll
V43B\NETDLL\XactGeometryMathD.dll
V43B\NETLIB\XactGeometryMath.lib
V43B\NETLIB\XactGeometryMathD.lib

V44B\DIMENS\FEATCTRLFRM.CPP
V44B\INCLUDE\FEATCTRLFRM.H
V44B\XACTGEOMETRYMATH\DATUMMINIMIZATION.CPP
V44B\NETDLL\XactGeometryMath.dll
V44B\NETDLL\XactGeometryMathD.dll
V44B\NETLIB\XactGeometryMath.lib
V44B\NETLIB\XactGeometryMathD.lib
<<END>>

<< Changes made by Don Turcotte -- 04/14/08  17:00:24>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>

<< Don Turcotte  --  04/11/08  17:23:06>>
I have fixed this so the tertiary datum reports correctly in the FCF position table.  The DEV field shows the correct "bonus used", the BONUS field shows the correct "remaining bonus" and the deviation graphic for the datum is drawn correctly.  This fix applies to any datum that has a planar zone (controls clocking in the datum reference frame).

I will complete testing Monday with V43B and merge/upload changes.
<<END>>

<< Don Turcotte  --  04/10/08  17:36:21>>
The negative bonus (remaining bonus after fitting) reported for the tertiary datum is only an error in the remaining bonus as calculated for the report.  The TP deviation and Summary Y,Z deviation values are correct.  The TP analysis is being done correctly with the correct datum bonuses.  The unfitted TP deviation is 0.144 which is a linear deviation of 0.072 mm.  The fitted result includes a rotation of 0.0296 degrees.  Since CIR_H (considered feature) is over 134 mm from the datum origin (CIR_E), this rotation gives an arc length of 0.069mm so the resulting TP fitted deviation of 0.043 (linear deviation of 0.0215 mm) is certainly within reason.

I will continue to look at why the reported remaining bonus after fitting for the tertiary datum is shown as a negative value.
<<END>>

<< Changes made by Tim Wernicke -- 04/07/08  10:51:29>>
Priority:  to Critical
<<END>>

<< Don Turcotte  --  04/07/08  11:25:30>>
This is from Bob Hospadaruk who is working with Allison Transmission.


I am unable to upload the attached file.  I will try again later.
<<END>>

huangyhg

1.
  T:\V44B\INCLUDE\FEATCTRLFRM.H(1533):  double GetDatumTpTolValue(CPCDcommand *in_feature,CPCDcommand *in_start_ptr,int whichDatum); // PR254246 // PR244554
2.
      m_line2_tol.Add(GetDatumTpTolValue(pSetFeatures[ii],start_ptr,whichDatum)); // PR254246 // PR244554
3.
  T:\V44B\DIMENS\FEATCTRLFRM.CPP(3380):      m_line3_tol.Add(GetDatumTpTolValue(pSetFeatures[ii],start_ptr,whichDatum)); // PR254246 // PR244554
4.
  T:\V44B\DIMENS\FEATCTRLFRM.CPP(26511):// PR254246 - restored to original (This reports to TOL field any preceding TP or Orientation Tol on the datum feature.)
5.
T:\V44B\XACTGEOMETRYMATH\DATUMMINIMIZATION.CPP
          if( tmp.size() == 3 ) // PR231981 // PR254246 - there are three intersection points