Review- PR 246135 Using tp from datum to refine datum virtual condition, use

huangyhg

Using tp from datum to refine datum virtual condition, use lower segment of datum composite tp value

<< Don Turcotte -- 01/19/07 14:05:55>>
When refining the datum virtual condition based on a preceding true position dimension on the datum, if the datum true position is a composite (or two single segments) use the lower (tighter) tolerance as the virtual condition refinement.
<<END>>


<< Don Turcotte  --  03/18/09  16:41:07>>
I have fixed this so it now works with a datum which is a set of holes (cylinders).  The bonus refinement is applied to the features of the datum set.
Fixed in V432, V44B.
Files inserted to server
------------------------
V432\DIMENS\DATUMREF.CPP
V44B\DIMENS\DATUMREF.CPP
<<END>>
<< Changes made by Don Turcotte -- 03/18/09  16:41:40>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  03/18/09  10:02:12>>
As noted below this is not working when the datum is a set of cylinders so I have re-opened.
<<END>>
<< Changes made by Don Turcotte -- 03/18/09  10:02:29>>
Status:  RESOLVED to OPEN
<<END>>
<< Yanhua Huang  --  10/29/08  19:19:02>>
Reviewed code of V43B.
test comment: select axis feature as datum & MMC.
<<END>>
<< Changes made by Yanhua Huang -- 10/29/08  19:19:14>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  08/18/08  09:24:25>>
Responded to Yanhua's e-mail request:
"Yanhua,
I have attached a V42R test program.  When the datum is a set of cylinders, this is not working (FCFLAGE1 is the composite true position on the datum set, FCFLAGE2 is the true position that uses the datum set).  When the datum is a single cylinder, this does work correctly (FCFLAGE3 is the composite true position on the datum, FCFLAGE4 is the true position that uses the datum).  So there still are some problems here.   I also tried this in V42 beta and V43B with the same problems (does not work when the datum is a set of cylinders).

Regards,
Don


--------------------------------------------------------------------------------
From: Yanhua HUANG
Sent: Monday, August 18, 2008 5:30 AM
To: Don Turcotte
Subject: Could you create a test part program (>= V42) for me?

Don,
Question about PR 246135 - Using tp from datum to refine datum virtual condition, use lower segment of datum composite tp value.
Could you create a test part program (>= V42) for me? The test part program was not attached with the PR. I do not know how to walk into your changed code for the PR when testing.
yanhua
"
<<END>>
<< Changes made by Neil Kay -- 07/23/08 10:36:25>>
Action: David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte -- 01/23/07 16:43:51>>
Merged into V42R.
Files inserted to server
------------------------
V42R\DIMENS\DATUMREF.CPP
<<END>>
<< Changes made by Don Turcotte -- 01/23/07 16:44:23>>
Action: Don Turcotte to David Petrizze, Status: OPEN to REVIEW
<<END>>
<< Tim Wernicke -- 01/23/07 15:34:56>>
Please add to V42R per our Skype. Thanks Don.
<<END>>
<< Changes made by Tim Wernicke -- 01/23/07 15:34:58>>
Action: David Petrizze to Don Turcotte, Status: REVIEW to OPEN, Priority: Critical to Stop Rel.
<<END>>
<< Don Turcotte -- 01/22/07 11:18:19>>
Fixed in V42 beta and V43B.
Files inserted to server
------------------------
V42\DIMENS\DATUMREF.CPP
V43B\DIMENS\DATUMREF.CPP
<<END>>
<< Changes made by Don Turcotte -- 01/22/07 11:18:37>>
Action: Don Turcotte to David Petrizze, Status: OPEN to REVIEW
<<END>>

huangyhg

From: Don Turcotte
Sent: 2008年8月18日 21:05
To: Yanhua HUANG
Subject: RE: Could you create a test part program (>= V42) for me?



Yanhua,

I have attached a V42R test program.  When the datum is a set of cylinders, this is not working (FCFLAGE1 is the composite true position on the datum set, FCFLAGE2 is the true position that uses the datum set).  When the datum is a single cylinder, this does work correctly (FCFLAGE3 is the composite true position on the datum, FCFLAGE4 is the true position that uses the datum).  So there still are some problems here.   I also tried this in V42 beta and V43B with the same problems (does not work when the datum is a set of cylinders).



Regards,

Don

From: Yanhua HUANG
Sent: Monday, August 18, 2008 5:30 AM
To: Don Turcotte
Subject: Could you create a test part program (>= V42) for me?



Don,

Question about PR 246135 - Using tp from datum to refine datum virtual condition, use lower segment of datum composite tp value.

Could you create a test part program (>= V42) for me? The test part program was not attached with the PR. I do not know how to walk into your changed code for the PR when testing.

yanhua