Review - PR 245566 Perpendicularity FCF problems with Diameter and Projected

huangyhg

Perpendicularity FCF problems with Diameter and Projected Tolerance Zone
<< Larry Clark  --  12/11/06  15:17:25>>
The attached PRG contains a Perpendicularity FCF dimension of two cylinder features of the same diameter.  An F9 to edit the dimension is changing the specified diameter.  Also, deleting the projected tolernace zone symbol in the FCF editor deletes the PZ length from the FCF editor and Preview pane but not from the edit window dimension definition nor the FCF in the graphics window.
Steps to reproduce:
1) Open PERP.PRG.  Note in the FCFPERP1 dimension the diameter of the cylinders is 13.99 (previously edited from the default CAD value of 15), and the projected tolerance zone length of 23.45.
2) F9 on FCFPERP1. Note that the diameter in the FCF editor and Preview pane changes to the CAD value of 15.
3) Click OK.  Note that the diameter value in the edit window and in the FCF in the graphics window is now 15.
4) F9 again on FCFPERP1.
5) In the FCF editor, click on the projected tolerance zone symbol and select [X] from the drop-down list.  Note that the FCF updates properly in the FCF editor and in the Preview pane and no longer displays the projected tolerance zone symbol nor the PZ length.  However...
6) Click OK.  Note that the edit window dimension definition still contains the PZ length of 23.45, and this value is also displayed in the FCF in the graphics window.  
NOTE1:  I did not observe the changing diameter problem when only a single cylinder was selected.  In this case, I could edit the diameter and the new value would not be overwritten with the CAD value.
NOTE2:  You can delete the value of the PZ length in the FCF editor and both the PZ symbol and the length value will be deleted in all locations as expected.  
<<END>>

<< Changes made by Neil Kay -- 07/23/08  16:32:11>>
Action:  Paola Pallo to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  10:25:52>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte  --  12/19/06  16:34:40>>
Merged into V42R.

Files inserted to server
------------------------
V42R\DIMENS\FEATCTRLFRM.CPP
V42R\INCLUDE\FEATCTRLFRM.H
V42R\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V42R\MENU\BASEDLGCHK.CPP
V42R\MENU\FEATCTRLFRMDLG.CPP
V42R\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 12/19/06  16:34:55>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  12/19/06  14:26:18>>
Hi Don, please merge your changes into V42R.  Thanks.
<<END>>
<< Changes made by Tim Wernicke -- 12/19/06  14:26:21>>
Action:  David Petrizze to Don Turcotte, Status:  REVIEW to OPEN, Priority:  Critical to Stop Rel.
<<END>>
<< Don Turcotte  --  12/19/06  15:13:28>>
This is now all working correctly including canceling out.
Fixed in V42, V43B.
Files inserted to server
------------------------
V42\DIMENS\FEATCTRLFRM.CPP
V42\INCLUDE\FEATCTRLFRM.H
V42\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V42\MENU\BASEDLGCHK.CPP
V42\MENU\FEATCTRLFRMDLG.CPP
V42\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\INCLUDE\FEATCTRLFRMOUTPUTDLG.H
V43B\MENU\BASEDLGCHK.CPP
V43B\MENU\FEATCTRLFRMDLG.CPP
V43B\MENU\FEATCTRLFRMOUTPUTDLG.CPP

<<END>>
<< Changes made by Don Turcotte -- 12/19/06  15:14:22>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  12/18/06  17:24:25>>
Some of the problems with the nominal diamter were created by the changes for 240945.  I have implemented changes that fix this PR and don't break 240945.  I am still testing these changes.
<<END>>
<< Don Turcotte  --  12/15/06  17:30:58>>
I have fixed the problems with the projection zone.  I am looking at the problems with the nominal diameter not sticking...
<<END>>
<< Changes made by Tim Wernicke -- 12/11/06  16:54:17>>
Action:  Tim Wernicke to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

void CFeatCtrlFrmOutputDlg::OnCancel()
{
  // PR245566 - restore original axes list
  if (! m_arrays_save.IsEmpty())
  {
    int featCnt = m_pFCFEditing->GetFeatureListSize();

    for (int idx = 0; idx < featCnt; idx++)
    {
      CPCDFeatCtrlFrm::AXES_ARRAY tmpArray;
      m_pFCFEditing->GetAxesList(tmpArray, idx);

      if (! tmpArray.IsEmpty())
      {
        int infoCnt = tmpArray.GetCount();

        for (int j = 0; j < infoCnt; j++)
        {
          AXIS_INFO *info1 = &tmpArray.GetAt(j);
          AXIS_INFO *info2 = &m_arrays_save[idx]->GetAt(j);

          info1->SetReportAxis(info2->ReportAxis());

          info1->SetUpdateFeatureNominals(info2->UpdateFeatureNominals()); // PR237923

          // PR233722
          info1->SetNominal(info2->Nominal());

          if (info1->HasPlusTol())
            info1->SetPlusTol(info2->lusTol());

          if (info1->HasMinusTol())
            info1->SetMinusTol(info2->MinusTol());
        }
        //240975: a change in the axes is not applied to the selected features , unless you changed the last feature's ones,
        // using third parameter EnforceSameAxes== TRUE,it is applying current feature's Axes to all features,
        // so any previous ones are covered by the last feature's selection.
        //m_pFCFEditing->SetAxesList(tmpArray, TRUE, idx, TRUE, (idx==0) ? TRUE : FALSE); // PR237360
        m_pFCFEditing->SetAxesList(tmpArray, TRUE, idx, FALSE, (idx==0) ? TRUE : FALSE); // PR237360
      }
    }

    m_pFCFEditing->SetLine1Str2(m_line1Str2);
    m_pFCFEditing->SetLine1Str3(m_line1Str3);
    m_pFCFEditing->SetLine1Str4(m_line1Str4);
  }

  Cancel();
}