Review - PR 247487 F9 on TP FCF and delete tertiary datum, then OK ==>

huangyhg

F9 on TP FCF and delete tertiary datum, then OK ==> axis nominals are now wrong
<< Don Turcotte  --  04/03/07  10:10:45>>
If you F9 on a TP FCF and delete the teritary datum, then press OK the axis nominals are updated incorrectly so the TP value reported is incorrect.  Also if you change axis nominals when Output alignment=Current, then select Output alignment=Datum reference, the changes are lost.  You must first tab to Feature control frame tab and come back to output tab to get changes to stick.
Steps to reproduce:
Load the program in PR# 247444.
Unmark all, then mark LOC1
Display report in table format.
F9 LOC1 and remove tertiary datum, then OK
Repaint report.
Results:
Report results are wrong.
If you F9 on LOC1 again and look at output tab dimension nominals with Output alignment=datum reference frame, you will see the X nominal is not 0 as it should be.  
Expected Results:
Axis nominals should update with new datum reference frame alignment when you delete a datum in the tp.  Also, when editing the axis nominals, then switch output alignment, then changes should be reflected in the new output alignment.
<<END>>

<< Changes made by Neil Kay -- 07/23/08  16:32:57>>
Action:  Paola Pallo to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  11:11:31>>
Action:  David Petrizze to Paola Pallo
<<END>>
<< Don Turcotte  --  04/03/07  10:28:52>>
Fixed in V42 beta and V43B.
Files inserted to server
------------------------
V42\MENU\FEATCTRLFRMDLG.CPP
V42\MENU\FEATCTRLFRMOUTPUTDLG.CPP
V43B\MENU\FEATCTRLFRMDLG.CPP
V43B\MENU\FEATCTRLFRMOUTPUTDLG.CPP
<<END>>
<< Changes made by Don Turcotte -- 04/03/07  10:29:27>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>

huangyhg

<< Changes made by Yanhua Huang (Field Changes) -- 04/01/09  14:40:35>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>

<< Yanhua Huang (Review Notes)  --  04/01/09  14:40:08>>
Reviewed and tested in V44B, working.
<<END>>

<< Don Turcotte  --  03/31/09  15:11:51>>
I fixed this so that any user modified dimension nominals will not be lost when simply changing a datum selection in the dialog.

Fixed in V44B.


Files inserted to server
------------------------
V44B\INCLUDE\FEATCTRLFRMDLG.H
V44B\MENU\FEATCTRLFRMDLG.CPP
<<END>>

<< Changes made by Don Turcotte -- 03/31/09  15:12:30>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>

<< Don Turcotte  --  03/30/09  17:19:42>>
Spending time trying to come up with a good solution here.
<<END>>

<< Don Turcotte  --  03/24/09  17:16:37>>
Back to trying to find a better way to do this.
<<END>>

<< Don Turcotte  --  03/23/09  17:16:12>>
I submitted PR#260728 about the serialization error.  Still looking for a better way to fix this problem.
<<END>>

<< Don Turcotte  --  03/19/09  17:12:26>>
Also found that this does not work correctly all the time in V432 as well.  In addition, I created a V432 test program that does not load in V44B (serialization error).
<<END>>

<< Don Turcotte  --  03/19/09  15:36:45>>
I have reopened this since this change can result in dimension nominals being lost.
<<END>>

<< Changes made by Don Turcotte -- 03/19/09  15:36:52>>
Status:  CLOSED to OPEN
<<END>>

<< Changes made by Don Turcotte -- 03/19/09  13:20:45>>
Status:  RESOLVED to CLOSED
<<END>>

<< Yanhua Huang  --  03/18/09  21:04:47>>
Reviewed, OK.
<<END>>

<< Changes made by Yanhua Huang -- 03/18/09  21:05:19>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>

<< Don Turcotte  --  03/17/09  10:00:33>>
Fixed in V44B (not a problem in V432)

Files inserted to server
------------------------
V44B\MENU\FEATCTRLFRMDLG.CPP
<<END>>

<< Changes made by Don Turcotte -- 03/17/09  10:01:03>>
Action:  Don Turcotte to Yanhua Huang, Status:  OPEN to REVIEW
<<END>>

<< Don Turcotte  --  03/16/09  17:23:08>>
I have re-opened this.  It is still a problem in V44B when the output alignment is DRF (ok with Current Active Alignment and ok in V432).  Changing the primary datum on LOC2 in the referenced program from X to A or vice versa causes the dimension nominals to get messed up resulting in a huge TP deviation.
<<END>>

<< Changes made by Don Turcotte -- 03/16/09  17:23:08>>
Status:  RESOLVED to OPEN
<<END>>

<< Yanhua Huang  --  10/28/08  16:37:41>>
Reviewed code of V43B.
<<END>>

<< Changes made by Yanhua Huang -- 10/28/08  16:39:05>>
Action:  Yanhua Huang to Don Turcotte, Status:  REVIEW to RESOLVED
<<END>>