PR258579 - location report the wrong values out of tolerance

huangyhg

location report the wrong values out of tolerance.
<< Jean Wang  --  12/04/08  23:07:37>>
When I report the location data, pc-dmis display the wrong out of tolerance values,please see the location.rar.
<<END>>

<< Don Turcotte  --  12/04/08  16:07:20>>
In this program the plus tol for all four location dimensions X,Y is set to -0.1 and the minus tol is set to -0.3.  In order to get this to report as expected, you will need to invert these tolerances in those cases where the nominal is negative (<0).  That is, when the nominal axis value is <0, set the plus tol to +0.3 and the minus tol to +0.1.  Then you will get the following results (note that in this program "Show minus tols as negative" is turned off):
DIM ???1= LOCATION OF CIRCLE O1  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
Y     -58.2000     0.3000    -0.1000   -58.1244     0.0756     0.0244 <-------
END OF DIMENSION ???1
DIM ???2= LOCATION OF CIRCLE O2  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
Y       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
END OF DIMENSION ???2
DIM ???3= LOCATION OF CIRCLE O3  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X      58.1000    -0.1000     0.3000    57.9589    -0.1411     0.0000 ------#-
Y       0.1286    -0.1000     0.3000     0.2042     0.0756     0.1756 ------->
END OF DIMENSION ???3
DIM ???4= LOCATION OF CIRCLE O4  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X      58.0607    -0.1000     0.3000    58.0607     0.0000     0.1000 ------->
Y     -57.8446     0.3000    -0.1000   -57.7690     0.0756     0.0244 <-------
END OF DIMENSION ???4

You should also be able to do this by turning on POSITIVEREPORTING without manually changing the tols (the positive reporting will do this for you).  However, there is a bug in POSITIVEREPORTING and not all cases worked correctly when I did this.  I have fixed this problem in V44B so that with POSITIVEREPORTING on in X,Y with DEVONLY selected, I now get the same results as above:
            POSITIVEREPORTING/X,Y, /DEVONLY
DIM ???1= LOCATION OF CIRCLE O1  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
Y     -58.2000     0.3000    -0.1000   -58.1244    -0.0756     0.0244 <-------
END OF DIMENSION ???1
DIM ???2= LOCATION OF CIRCLE O2  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
Y       0.0000    -0.1000     0.3000     0.0000     0.0000     0.1000 ------->
END OF DIMENSION ???2
DIM ???3= LOCATION OF CIRCLE O3  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X      58.1000    -0.1000     0.3000    57.9589    -0.1411     0.0000 ------#-
Y       0.1286    -0.1000     0.3000     0.2042     0.0756     0.1756 ------->
END OF DIMENSION ???3
DIM ???4= LOCATION OF CIRCLE O4  UNITS=MM ,$
GRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  HALF ANGLE=YES
AX    NOMINAL       +TOL       -TOL       MEAS        DEV     OUTTOL
X      58.0607    -0.1000     0.3000    58.0607     0.0000     0.1000 ------->
Y     -57.8446     0.3000    -0.1000   -57.7690    -0.0756     0.0244 <-------
END OF DIMENSION ???4
Files inserted to server
------------------------
V44B\DIMENS\LOCATION.CPP

<<END>>
<< Changes made by Don Turcotte -- 12/04/08  16:14:58>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Tim Wernicke  --  12/04/08  10:27:22>>
This seems to be casued by both the +/- tolerances being entered as "-".  Why would anyone do this?
<<END>>
<< Changes made by Tim Wernicke -- 12/04/08  10:27:24>>
Priority:  Stop Rel. to Medium
<<END>>
<< Changes made by Tim Wernicke -- 12/04/08  09:18:02>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Stop Rel.
<<END>>

huangyhg

double CPCDlocation::get_plus_tol()

double CPCDlocation::get_minus_tol(BOOL show_as_neg)
  if (use_positive_reporting() && (nominal < -1e-6)) // PR258579 - only flip plus/minus when we are on negative side of origin (with 1e-6 epsilon)
    rept_val = plus_tol;
------------------------------------Don T