PR 240988 - Probably some problems with Multiple FCF

huangyhg

Probably some problems with Multiple FCF
<< Domenico Varacalli  --  05/30/06  19:41:18>>
Look at the GIFs.
Why under these conditions I don't succeed in inserting this tolerance? (gif 1)
Why in this other condition I have succeeded there? Does it have sense the circularity? (gif 2)
Do they have sense the other symbols? (gif 3) In the manual ANSI-ASME I have not seen this representation.
Why I have succeeded in inserting these tolerances? (gif  A1/A2    B1/B2)
<<END>>

<< Changes made by Neil Kay -- 12/12/08  09:26:34>>
Action:  Daniel Wilcox to Yanhua Huang
<<END>>
<< Changes made by Neil Kay -- 07/23/08  12:24:55>>
Action:  David Petrizze to Daniel Wilcox
<<END>>
<< Don Turcotte  --  08/20/07  17:30:49>>
There are two issues here :
1.  The only dimensions allowed on the lower tier should be
     a. true position
     b. profile line
     c. profile surface
     d. perpendicularity
     e. parallelism
      f. angularity
2.  A dimension should not be created with zero tolerance unless a material condition is specified.
I have fixed both of these problems in V43B.
Files inserted to server
------------------------
V43B\DIMENS\FEATCTRLFRM.CPP
V43B\DIMENS\FEATCTRLFRMUTIL.CPP
V43B\INCLUDE\FEATCTRLFRM.H
V43B\INCLUDE\resource.h
V43B\MENU\FEATCTRLFRMDLG.CPP
V43B\RESOURCE\LANGS\ENGLISH\RESOURCE.RC
<<END>>
<< Changes made by Don Turcotte -- 08/20/07  17:30:57>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 05/30/06  14:12:45>>
Priority:  to Medium
<<END>>

huangyhg

1. t:\V44B\DIMENS\FeatCtrlFrm.CPP
boolCPCDFeatCtrlFrm::SetDimensionValidityForType(CPCDcommand *pFeature, BOOL *bValid/*=NULL*/, intlineno/*=2*/) // PR240988


bResult = SetDimensionValidityForType(pSetFeatures[jj], bValid, lineno); // PR240988

2. t:\V44B\DIMENS\FeatCtrlFrmUtil.CPP

BOOL VerifyDim(CPCDpart_program *m_pPartProgram,
CPCDFeatCtrlFrm *pFCF,
CArray <CString, CString> &in_errorStrArray,
CArray <int, int> &in_errorIDSArray,
BOOL in_UseMessageBox, CFeatCtrlFrmDlg *pFCFDlg/*=NULL*/) // #236761, whb 12/17/2005



else
{
isValid = VerifyDRF(m_pPartProgram, pFCF, in_errorStrArray, in_errorIDSArray, in_UseMessageBox, pFCFDlg);
}
// PR240988 - Make sure we don't have zero tolerance unless MMC/LMC.
CString tolstr = pFCF->GetLine2TolStr();
double tol = _ttof(tolstr);
if( tol == 0.0 )
{
if( (pFCF->GetLine2MMCRes() != ID_GDT_MMC) && (pFCF->GetLine2MMCRes() != ID_GDT_LMC) )
{
CString title;
title.LoadString(IDS_ERR_DRF);
CString message;
message.LoadString(IDS_ERR_UPPERTIER_ZERO_TOL);
in_errorStrArray.Add(message);
in_errorIDSArray.Add(IDS_ERR_UPPERTIER_ZERO_TOL);
if ( !global_automated.IsAutomated() && in_UseMessageBox)
PCDMessageBox( NULL, message, title, MB_OK, pFCFDlg ); // #236761, whb 12/17/2005
isValid = FALSE;
}
}