PR 259360 Using Auto to dimension a group of features, if they're selected u

huangyhg

Using Auto to dimension a group of features, if they're selected using the SHIFT key all features are dimensioned as the first in the list (location dimension)

<< Alessandro Zanetti  --  01/28/09  18:20:34>>
This is quite funny, but very bad on the other hand.
I've been able to get dimensioned the length of a circle.
Steps to reproduce:
See attached clip.
Load the attached program.
Insert|Dimension|Location.
In the dialog, select all Laser features from SLT3 to SLT4 ( note that the selection includes CIR7 and CIR8 ) clicking first on SLT3, then holding down SHIFT, then clicking SLT4.
Leave the Auto option enabled and hit Create.
Results:
All Location dimensions have the same axes, and this of course applies also to the report.
Circles have Length.
Expected Results:
Look at the clip.
If I select the features one by one clicking on them and then hit Create, all is correct.
<<END>>

<< Don Turcotte  --  02/11/09  16:37:54>>
Reviewed.
I found two scenarios that do not work correclty:
1.  Select all features from SLT3 to SCN1 and Create.  Then all location dimensions get X,Y,Z axes only.
2.  Select all features from SLT3 to SLT4. Then in Tolerances group box for ALL, enter Plus of .1, Minus of .1, then Create.  All location dimensions get X,Y,Z,D,L axes including circles.  Note that if you don't enter any tolerances but just select Create then slots get X,Y,Z,D,L, but circles correctly get only X,Y,Z,D.
<<END>>
<< Changes made by Don Turcotte -- 02/11/09  16:38:07>>
Action:  David Petrizze to Yanhua Huang, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Don Turcotte -- 02/11/09  16:37:54>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  02/10/09  13:53:30>>
******************************
Tue Feb 10 13:50:24 2009
******************************
Files inserted to server
------------------------
V44B\INCLUDE\DIMLOCDL.H
V44B\MENU\DIMLOCDL.CPP
<<END>>
<< Changes made by Yanhua Huang -- 02/10/09  13:59:36>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  02/09/09  22:32:45>>
Fix the PR into V44B, but need do lots of tests on selecting multiple feature types.
******************************
Mon Feb 09 22:27:03 2009
******************************
Files inserted to server
------------------------
V44B\INCLUDE\DIMLOCDL.H
V44B\MENU\DIMLOCDL.CPP
<<END>>
<< Yanhua Huang  --  02/09/09  22:23:36>>
Tim,
I think this is an issue with other lists in location dialog, because "m_l "represents  the status of the last feature when multiple features  are selected..
Please do most tests on selecting the multiple feature types.
<<END>>
<< Yanhua Huang  --  02/08/09  20:16:02>>
Can reproduce the PR in V44B
<<END>>
<< Changes made by Neil Kay -- 01/29/09  10:38:28>>
Category:  UI-Dialogs to dimensions, Action:  Systems Group to Yanhua Huang, Assigned:  Systems Group to Yanhua Huang
<<END>>
<< Tim Wernicke  --  01/28/09  11:23:43>>
Seems like a general UI problem.  I wonder if this will be an issue with other lists in dialogs?
<<END>>
<< Changes made by Tim Wernicke -- 01/28/09  11:23:46>>
Category:  dimensions to UI-Dialogs, Action:  Don Turcotte to Systems Group, Assigned:  Don Turcotte to Systems Group, Priority:  to Critical
<<END>>

huangyhg

void AddAxis(CPCDcommand *pCmd, CPCDFeatCtrlFrm::AXES_ARRAY & AxesToReport, CString & axis, int dim_type, double nom, double ptol, double mtol, BOOL bHasNominal = TRUE, BOOL bHasPlustol = TRUE, BOOL bHasMinustol = TRUE, BOOL bReport = TRUE, int iUpdateFeatureNominals = 0);

// PR259360 - yanhua - Using Auto to dimension a group of features, if they're selected using the SHIFT key all features are dimensioned as the first in the list

voidCDimLocDlg::AddAxis(CPCDcommand *pCmd, CPCDFeatCtrlFrm::AXES_ARRAY & AxesToReport, CString & axis, intdim_type, doublenom, doubleptol, doublemtol, BOOLbHasNominal/*=TRUE*/, BOOLbHasPlustol/*=TRUE*/, BOOLbHasMinustol/*=TRUE*/, BOOLbReport/*=TRUE*/, intiUpdateFeatureNominals/*=0*/)

{

if (m_auto && pCmd && m_pPartProgram)

{

intnFetCnt = 0;

CPCDcommand **pnts = NULL;

nFetCnt = get_dialog_features(m_pPartProgram, this, &pnts);

if (nFetCnt > 1) // multiple features are selected

IsDefaultAxis(pCmd, dim_type, bReport);

}

AddAxis(AxesToReport, axis, dim_type, nom, ptol, mtol, bHasNominal,bHasPlustol,bHasMinustol,bReport,iUpdateFeatureNominals);

}