PR 245258 Auto dimension creates Tp FCF with no datums.

huangyhg

Auto dimension creates Tp FCF with no datums.
<< Domenico Varacalli  --  11/28/06  16:46:52>>
The FCF of True Position with Preview Window and Auto Dimensioning (1.GIF), produces an error if I try to modify this location with F9 command (2.GIF).
Is the structure of this FCF correct?
<<END>>

<< Changes made by Neil Kay -- 02/25/09  19:17:54>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Don Turcotte  --  08/15/07  13:51:58>>
I have modified V42 beta and V43B so that if no datums (DATDEF commands) exist preceding the point where the feature will be added, the message "Datums are required for this dimension." is displayed and no true position FCF is added.
Files inserted to server
------------------------
V42\SOURCE\GLOBALS.CPP
V43B\SOURCE\GLOBALS.CPP

<<END>>
<< Changes made by Don Turcotte -- 08/15/07  13:52:06>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  05/07/07  09:56:19>>
I have changed this to "roblem" since auto dimension should not create true position FCFs when there are no datums defined in the program.  
<<END>>
<< Changes made by Don Turcotte -- 05/07/07  09:54:58>>
Status:  MOREINFO to OPEN
<<END>>
<< Domenico Varacalli  --  05/04/07  14:54:32>>
Ok Don, I try to explain better this situation. The strange FCF has been created, for a forgetfulness of the operator, when in the part-program it was not present the definition of the Datum.
Then in this case should not be permitted to produce the Auto/Location Position Dimensions. Instead the location is produced but without Datum,therefore it is evident that F9 generates
an error. The error message "Datums are required for this dimension" should be also produced when the button ACCEPT is pressed in the Preview Window. If the program is executed
without the Datum, there is not any signaling of error when the location is produced on output. Is it correct? Perhaps the result of a true position without Datum is understood as position
in comparison to the zero of reference?
<<END>>
<< Changes made by Domenico Varacalli -- 05/04/07  14:54:53>>
Action:  Domenico Varacalli to Don Turcotte, Status:  RESOLVED to MOREINFO
<<END>>
<< Don Turcotte  --  04/27/07  15:47:25>>
The problem here is that FCFLOC1 is a true position with no datums.  This is not valid since the new Feature Control Frame true position dimension requires datums.  I am not sure how you were able to create such an FCF but there was an earlier bug (which has now been fixed) which created erroneous FCF's even though the FCF dialog displayed an error message.
<<END>>
<< Changes made by Don Turcotte -- 04/27/07  15:47:31>>
Action:  Don Turcotte to Domenico Varacalli, Status:  OPEN to RESOLVED
<<END>>
<< Changes made by Tim Wernicke -- 11/28/06  10:33:24>>
Priority:  to High
<<END>>

huangyhg

// PR245258 - make sure we have datums for the FCF command
      CPCDcommand * p = NULL;
      if( insert_after )
      {
        p = *end;
      }
      else
      {
        p = m_pPartProgram->GetCurrentCommand();
      }

      BOOL bHaveDatums = FALSE;
      while( p )
      {
        if( p->type() == DATDEF_COMMAND )
        {
          bHaveDatums = TRUE;
          break;
        }
        p = p->prev;
      }

      if( !bHaveDatums ) // display error message and don't create the FCF
      {
        CString title;
        title.LoadString(IDS_ERR_DRF);
        CString message;
        message.LoadString(IDS_ERR_NO_DATUMS);

        if ( !global_automated.IsAutomated() )
          PCDMessageBox( NULL, message, title, MB_OK );
      }
      else
      {
        dim = new CPCDFeatCtrlFrm( m_pPartProgram, NULL, _T(""), ID_INSERT_DIMENSION_TRUE_POSITION);
        CString str;
        str = dim->get_id();
        if ( dim->is_featCtrlFrm() )