PR 242605 No level to primary circle datums

huangyhg

No level to primary circle datums
<< David Petrizze  --  08/22/06  13:18:24>>
As SAM they are specifying circle features as primary datums.  We level to this feature which is offseting the results when the circle vector is inconsistant with the Current Active Alignment
Expected Results:
Don't level to circles when specified as primary datums, only translate the X and Y axes in this case.
<<END>>


<< Changes made by Neil Kay -- 02/25/09  19:21:43>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Jerry Naylor  --  09/26/06  10:47:09>>
This has been dodumented in the Settings Editor doc.
<<END>>
<< Guillermo Nevado  --  09/24/06  13:33:49>>
Please make sure this is documented somewhere so AEs and customer would know.
We keep adding switches to the registry and few know what for or how they work.
It just takes for someone to performa ClearWaIkeys to fix a failing system and now 100% of default settings are gone.  I know I am side stepping the PR problem, but wanted to raise the flag.  Settings are getting overwhelming.
<<END>>
<< Don Turcotte  --  08/22/06  17:25:23>>
I added a new registry entry
  Option\DatumLevelToCircle
which by default is 0 (FALSE).  If 0 (FALSE), Datumref will not level to a primary datum circle (only translate X, Y).  If 1, Datumref will level to a primary datum circle.  Tested with attached program.
Files inserted to server
------------------------
V41B\DIMENS\DATUMREF.CPP
V41B\INCLUDE\GLOBALS.H
V41B\MENU\PCDLRN.CPP
V41B\SOURCE\Archgvar.cpp
V42\DIMENS\DATUMREF.CPP
V42\INCLUDE\GLOBALS.H
V42\MENU\PCDLRN.CPP
V42\SOURCE\Archgvar.CPP
V43B\DIMENS\DATUMREF.CPP
V43B\INCLUDE\GLOBALS.H
V43B\MENU\PCDLRN.CPP
V43B\SOURCE\Archgvar.CPP
<<END>>
<< Changes made by Don Turcotte -- 08/22/06  17:32:39>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< David Petrizze  --  08/22/06  13:20:13>>
But in order to maintain backward compatibility we must create a flag in the registry that will allow the user to resort to the previous behaviour.  Even though with this fix the reported results are more correct.
<<END>>

huangyhg

else if( (m_iType[PRIMARY] == DAT_AXIS) || (m_iType[PRIMARY] == DAT_COAXIAL) )
  {
    // PR242605 - don't level to a circle datum unless the registry says to
    if( global_DatumLevelToCircle || m_pDatum[PRIMARY]->feature() != F_CIRCLE )
    {
      // AXIS
      obj = new CPCDlevel_align(m_pPartProgram);
      if (obj)
      {
        ((CPCDlevel_align *)obj)->featureid = m_pDatum[PRIMARY];
        ((CPCDlevel_align *)obj)->workpl = m_workplane;
        add_obj(align, obj);
        set_fixed_axis(DAT_LEVEL, PRIMARY, m_workplane);
        //      m_iAxis_fixed[DOF_U]= 1;
        //      m_iAxis_fixed[DOF_V]= 1;
      }
    }