PR 255459 the nominal values of true position are changed when execute the pp

huangyhg

the nominal values of true position are changed when execute the pp

<< Jean Wang  --  06/17/08  08:15:17>>
When we use the variable as the roation angle of the  alignment, the nomial X,Y values are changed after the pp execution, see the  file tp_var.rar on the server.
<<END>>
<< Changes made by Neil Kay -- 02/25/09  19:18:27>>
Action:  David Petrizze to Yanhua Huang
<<END>>
<< Don Turcotte  --  07/11/08  09:47:32>>
The way to do this is simply to use variables for the dimension nominals:
FCF001 = TRUE POSITION OF CIR4
            FEATCTRLFRAME/SHOWNOMS=YES,SHOWPARAMS=YES,SHOWEXPANDED=YES
            CADGRAPH=OFF  REPORTGRAPH=OFF  TEXT=OFF  MULT=10.00  OUTPUT=BOTH  UNITS=MM
            COMPOSITE=NO,FIT TO DATUMS=NO,OUTPUT ALIGNMENT=Current Alignment
               SIZE TOLERANCES/1,DIAMETER,25.4,0.01,0.01
               PRIMARY DIMENSION/TRUE POSITION,DIAMETER,0.01,MMC,A,B,C,<MC>
               SECONDARY DIMENSION/<Dim>,<tol>,<MC>,,<dat>,<dat>,<dat>
               NOTE/FCF001
            FEATURES/CIR4,,
               CIR4
                   X:NOM=CIR4.TX
                   Y:NOM=CIR4.TY
                  <NEW>
               DATUMS
                  D3:NOM=25.4,+TOL=0.01,-TOL=0.01
Executing the program with variables for the feature noms works correctly.  I have attached a version of the program with this change in "42MR2 with variables.7z".
Modifying PC-DMIS to work without variables for dimension nominals in this case is too complicated to implement.
<<END>>
<< Changes made by Don Turcotte -- 07/11/08  09:48:50>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  07/10/08  17:40:05>>
I am rethinking this whole thing since I cannot get it to work correctly with the path I am currently pursuing.
<<END>>
<< Don Turcotte  --  07/09/08  17:09:15>>
Looking at using DIMCREATETEXT to control how SetIgnoreCadToPart(...) behaves during executeprivate(...) of CPCDFeatCtrlFrm, but so far this has not corrected the problem.
<<END>>
<< Don Turcotte  --  07/02/08  17:16:14>>
I am making progress but still having problems getting everything to work together: executing program, report, edit window (command and summary modes).
<<END>>
<< Don Turcotte  --  07/01/08  17:15:52>>
I understand now how ConvertAxesLists(...) needs to operate in order for the edit window, dialog, and report to work correctly for current alignment versus fcf alignment by temporarily turning off ignore cad to part.  Now I need to combine this with how ConvertAxesLists(...) needs to operate during execution.
<<END>>
<< Don Turcotte  --  06/30/08  17:34:00>>
Took another look at this, but have not made any progress here.
<<END>>
<< Don Turcotte  --  06/27/08  17:08:56>>
I have found that if I keep IgnoreCadToPart set in the CPCDFeatCtrlFrm method ConvertAxesLists(...) then the report shows the correct nominal and measured values, even after executing with the simulator.  This is with update_cad_coords(...) removed from CPCDFeatCtrlFrm.  The ConvertAxesLists(...) method is used to convert dimension nominals from CAD to Current Alignment or FCF Alignment.  Making this change, however, has the effect of not updating the dimension nominals in the Advanced tab grid ctrl when switching between Current Alignment and FCF Alignment.  The dimension nominals in the edit window (both summary and command mode) are also not switched.  Only the report is correct.  This line of investigation does seem promising, though.
<<END>>
<< Don Turcotte  --  06/25/08  17:14:14>>
I have not been able to figure out an implementation of update_cad_coords(...) in CPCDFeatCtrlFrm that corrects the problem.  Continuing to look at this...
<<END>>
<< Don Turcotte  --  06/24/08  17:28:07>>
The problem here is the combination of a ROTATE_OFFSET in the alignment plus IgnoreCadToPart being set.  I can replace the variable with a hard-coded number and this is still a problem.  The issue here seems to be that CPCDFeatCtrlFrm does not implement update_cad_coords(...).  I am working on a solution.
<<END>>
<< Changes made by Don Turcotte -- 06/24/08  17:28:07>>
Action:  Yanhua Huang to Don Turcotte, Assigned:  Yanhua Huang to Don Turcotte
<<END>>
<< Changes made by Tim Wernicke -- 06/16/08  21:59:03>>
Category:  true pos to GD&T, Action:  Tim Wernicke to Yanhua Huang, Assigned:   to Yanhua Huang, Priority:  to Critical
<<END>>